[Bug 12086] New: wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

Summary: wine needs to update its timezone info?
           Product: Wine
           Version: CVS/GIT
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: ntdll
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=11466)
 --> (http://bugs.winehq.org/attachment.cgi?id=11466)
part of the +ntdll trace

Hi, I've noticed this fixme on the console started showing up recently:

fixme:ntdll:find_reg_tz_info Can't find matching timezone information in the
registry for bias 480, std (d/m/y): 2/11/2008, dlt (d/m/y): 9/03/2008

Is this due to the recent timezone changes in the US? Do we need to update the
timezone info somewhere?

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #1 from Dmitry Timoshkov   2008-03-18 00:03:44 ---
How old is your Wine git? Rob updated timezone info recently.

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #2 from Lei Zhang   2008-03-18 00:07:43 ---
The latest afaik: wine-0.9.57-247-g99f651b, fresh .wine directory. I see it on
multiple computers. It occurs every time I run Winrar. (looking at bug 11364)

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #3 from Dmitry Timoshkov   2008-03-18 00:17:25 ---
Can you verify what time zone information Windows reports for your time zone,
and compare it with what Wine has, and

fixme:ntdll:find_reg_tz_info Can't find matching timezone information in the
registry for bias 480, std (d/m/y): 2/11/2008, dlt (d/m/y): 9/03/2008

(taking into account that Windows has time zone data in day-of-week format)

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #4 from Dan Kegel   2008-03-18 02:58:45 ---
This has been bugging me lately, too; it even causes some apps to crash.

Sorry, I didn't quite follow what info you wanted.  
Can you give that to me in "just do this" mode?

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #5 from Lei Zhang   2008-03-18 03:01:51 ---
Should I write a simple test program for this?

I looked in the time zones registry key on an updated windows machine, and it
has additional time zone info for the US time zones, Australia, Egypt and many
other countries. I.e. under

HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Pacific Standard
Time

there is also:

HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Pacific Standard
Time\Dynamic DST

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #6 from Dmitry Timoshkov   2008-03-18 03:05:11 ---
Just provide an output of 'date' command under Linux, I'll try to figure out
remaining bits. (I just need a timezone name where you are).

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #7 from Lei Zhang   2008-03-18 03:08:02 ---
$ date
Tue Mar 18 01:06:22 PDT 2008

We just entered daylight savings last week. We're at -7 UTC instead of the
normal -8.

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #8 from Dmitry Timoshkov   2008-03-18 03:11:07 ---
After running 'TZ=America/Los_Angeles wine notepad' and pressing F5 I see
that fixme.

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #9 from Dmitry Timoshkov   2008-03-18 03:25:22 ---
Looks like there is no info at all for Pacific Daylight Time in WIne's
registry.

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #10 from Dmitry Timoshkov   2008-03-18 03:49:19 ---
The following patch fixes the problem for me (I updated tz info for
Mexico as well while I had an opportunity):

http://www.winehq.org/pipermail/wine-patches/2008-March/051734.html

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #11 from Lei Zhang   2008-03-18 10:05:33 ---
That fixed it for me. There's at least 10 other timezones that need updating
though.

Is there a handy page that explains what the registry values mean?

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #12 from Dmitry Timoshkov   2008-03-18 10:23:48 ---
If you provide the list of time zones that should be fixed I'll fix them.

For the registry format have a look at dlls/ntdll/time.c,find_reg_tz_info()
or http://blogs.technet.com/dst2007/Default.aspx?p=2 and look for
REG_TZI_FORMAT.

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #13 from Dmitry Timoshkov   2008-03-18 10:25:35 ---
Also http://msdn2.microsoft.com/en-us/library/ms725481(VS.85).aspx
describes the registry data format.

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #14 from Lei Zhang   2008-03-18 10:50:25 ---
(In reply to comment #12)
> If you provide the list of time zones that should be fixed I'll fix them.

Several US timezones - Alaskan (UTC-8), Mountain (UTC-6), Central (UTC-5), and
Eastern (UTC-4)

Several Australian time zones, a couple South American time zones, and possibly
others have changed as well, but I don't know what exactly the changes are.

Would it make sense to have a side project that generates these registry
entries from the time zone data here? http://www.twinsun.com/tz/tz-link.htm

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #15 from Dmitry Timoshkov   2008-03-18 11:11:24 ---
Rob atatched an updated Mike's program that was used to generate  time zone
data for Wine:

http://www.winehq.org/pipermail/wine-patches/2008-March/051455.html

You can add the time zones you need and regenerate the data.

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Lei Zhang   2008-03-18 22:28:46 ---
Maybe Rob's patch is to blame for this.

His patch:

-HKLM,%CurrentVersionNT%\Time Zones\Pacific Standard
Time,"TZI",1,e0,01,00,00,00,00,00,00,c4,ff,ff,ff,00,00,0b,00,00,00,01,00,02,00,00,00,00,00,00,00,00,00,03,00,00,00,02,00,02,00,00,00,00,00,00,00
+HKLM,%CurrentVersionNT%\Time Zones\Pacific Standard
Time,"TZI",1,e0,01,00,00,00,00,00,00,c4,ff,ff,ff,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00

Your patch:

-HKLM,%CurrentVersionNT%\Time Zones\Pacific Standard
Time,"TZI",1,e0,01,00,00,00,00,00,00,c4,ff,ff,ff,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00
+HKLM,%CurrentVersionNT%\Time Zones\Pacific Standard
Time,"TZI",1,e0,01,00,00,00,00,00,00,c4,ff,ff,ff,00,00,0b,00,00,00,01,00,02,00,00,00,00,00,00,00,00,00,03,00,00,00,02,00,02,00,00,00,00,00,00,00

Hmmmmm.

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #17 from Rob Shearman   2008-03-19 06:02:35 ---
As Dmitry said, I used a tool to automatically generate the data and it was the
resulting patch that caused this. Now the strange thing is that PST is
generated correctly now (presumably after switching to daylight time) so that
suggests there is a bug in the program.

However, there does seem to be inconsistencies with Windows in some of the
other timezones in my patch. I'm not sure whether that is because of incorrect
time zone data on my machine or a bug in the tool.

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #18 from Dmitry Timoshkov   2008-03-19 07:39:57 ---
Perhaps time zone switch time detection algorithm in that program should be
replaced with the one I've added to dlls/ntdll/time.c

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #19 from Dmitry Timoshkov   2008-03-30 04:39:46 ---
I sent the patch:

http://www.winehq.org/pipermail/wine-patches/2008-March/052474.html

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #20 from Dmitry Timoshkov   2008-03-31 10:17:55 ---
The patch has been committed.

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #21 from Alexandre Julliard   2008-04-04 10:07:13 ---
Closing bugs fixed in 0.9.59.

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

Stuart  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #22 from Stuart   2008-04-05 05:05:39 ---
I have just updated to .59, and I am still having problems.  My UK time is an
hour behind, now that we are in daylight savings.

I am not getting the "Can't find matching timezone information" on the console.

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #23 from Dmitry Timoshkov   2008-04-05 05:27:01 ---
Have you tried with fresh ~/.wine ?

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #24 from Stuart   2008-04-05 08:55:56 ---
(In reply to comment #23)
> Have you tried with fresh ~/.wine ?

Yes, and it's just the same.  I have removed all traces of wine off my system,
and reinstalled it, but I get the same problem.

/usr/bin/wine --version
wine-0.9.59

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #25 from Dmitry Timoshkov   2008-04-05 09:25:18 ---
What application does show this? Can you try with 'wine notepad', press F5,
and report whether printed time is correct?

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #26 from Stuart   2008-04-05 11:21:02 ---
Digiguide.  Notepad is an hour out too.  GMT instead of BST

I have been using this for years, without any problems with daylight savings.

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

--- Comment #27 from Stuart   2008-04-05 15:02:06 ---
Fixed it.  I noticed a Java app I use was also an hour behind (although it did
say GMT after the time, so technically it was correct)

I did two things.  In /etc/conf.d/clock I changed

CLOCK="UTC"

to

CLOCK="local"

And i also switched to a more recent kernel.

Thanks for the help.

[Bug 12086] wine needs to update its timezone info?

http://bugs.winehq.org/show_bug.cgi?id=12086

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified