http://bugs.winehq.org/show_bug.cgi?id=25856
Summary: Regression: Unable to type - in cmd anymore. Product: Wine Version: 1.3.12 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: kernel32 AssignedTo: wine-bugs@winehq.org ReportedBy: trygve.vea@gmail.com CC: eric.pouech@orange.fr
Hello,
Observed on IRC that a user complains about being unable to type - in cmd anymore after wine 1.3.12. Tested it myself, and were able to reproduce.
Doing bisect points me to the following commit:
2a219b948c451213fb4554352b86f3784a8f7e32 is the first bad commit commit 2a219b948c451213fb4554352b86f3784a8f7e32 Author: Eric Pouech eric.pouech@orange.fr Date: Tue Jan 18 22:03:19 2011 +0100
kernel32: Added support for insert/overwrite modes while editing a line.
:040000 040000 0250e1067e0dbfa95915b99f46bb834087923b3b 201965f2628e90ca411883e38e98aed8d6e9de8f M dlls :040000 040000 e689a9502dd762357df6447d92f31b7970d10fe2 1e74b4cb7785c5a0b26635c8ceb47dc93f29e4ce M server
The patch reverts just fine, and the regression is removed.
Added author of the patch as a CC to this bug.
http://bugs.winehq.org/show_bug.cgi?id=25856
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression
http://bugs.winehq.org/show_bug.cgi?id=25856
--- Comment #1 from Eric Pouech eric.pouech@orange.fr 2011-01-23 13:04:02 CST --- I can't reproduce it here what are the steps to reproduce ? A+
http://bugs.winehq.org/show_bug.cgi?id=25856
--- Comment #2 from Trygve Vea trygve.vea@gmail.com 2011-01-23 13:55:21 CST --- (In reply to comment #1)
I can't reproduce it here what are the steps to reproduce ? A+
Start with a clean wineprefix.
1) Run: wine cmd 2) try to type -
More information of my setup would include Ubuntu 10.10, x86_64 distribution with a 32 bit wineprefix, LANG=en_US.utf8, keyboard is configured to Norwegian bokmål in Gnome.
I normally use the ppa-repo, but I was also able to reproduce this with git (hence the bisect, and bugreport).
http://bugs.winehq.org/show_bug.cgi?id=25856
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |nerv@dawncrow.de Ever Confirmed|0 |1
--- Comment #3 from André H. nerv@dawncrow.de 2011-01-24 12:11:51 CST --- true, i can type, but e.g. the "-" doesnt work...
http://bugs.winehq.org/show_bug.cgi?id=25856
--- Comment #4 from Austin English austinenglish@gmail.com 2011-01-24 13:29:50 CST --- Works for me in ubuntu maverick with LANG=en_US.UTF-8 / Linux midna 2.6.35-24-generic #42-Ubuntu SMP Thu Dec 2 02:41:37 UTC 2010 x86_64 GNU/Linux
but not gentoo with a POSIX locale, 2.6.34-r3.
http://bugs.winehq.org/show_bug.cgi?id=25856
--- Comment #5 from Trygve Vea trygve.vea@gmail.com 2011-01-25 13:27:38 CST --- (In reply to comment #4)
Works for me in ubuntu maverick with LANG=en_US.UTF-8 / Linux midna 2.6.35-24-generic #42-Ubuntu SMP Thu Dec 2 02:41:37 UTC 2010 x86_64 GNU/Linux
but not gentoo with a POSIX locale, 2.6.34-r3.
Without any knowledge of the code in question - this line is added in the patch:
{/*VK_INSERT*/0x2d, WCEL_ToggleInsert },
0x2d happens to be - in the ascii table.
If I interpret this correctly, you've effectively changed - to toggle insert. And this seems to be true, - does indeed toggle insert-behaviour.
http://bugs.winehq.org/show_bug.cgi?id=25856
--- Comment #6 from Nikolay Sivov bunglehead@gmail.com 2011-01-25 13:30:20 CST --- Fixed by http://source.winehq.org/git/wine.git/?a=commit;h=5f2370b0aac2548a9764776104... I suppose?
http://bugs.winehq.org/show_bug.cgi?id=25856
--- Comment #7 from Trygve Vea trygve.vea@gmail.com 2011-01-25 13:38:34 CST --- (In reply to comment #6)
Fixed by http://source.winehq.org/git/wine.git/?a=commit;h=5f2370b0aac2548a9764776104... I suppose?
Erh, yes. I just tested and made an identical patch...
Then http://www.winehq.org/pipermail/wine-patches/2011-January/098226.html is unneccessary :)
I already started celebrating me fixing my first bug..
http://bugs.winehq.org/show_bug.cgi?id=25856
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #8 from Nikolay Sivov bunglehead@gmail.com 2011-01-25 13:47:58 CST --- Fixed.
http://bugs.winehq.org/show_bug.cgi?id=25856
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Regression: Unable to type |Unable to type - in cmd |- in cmd anymore. |anymore.
http://bugs.winehq.org/show_bug.cgi?id=25856
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org 2011-02-04 13:21:17 CST --- Closing bugs fixed in 1.3.13.
https://bugs.winehq.org/show_bug.cgi?id=25856
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |5f2370b0aac2548a97647761046 | |95da08ec38938 Regression SHA1| |2a219b948c451213fb4554352b8 | |6f3784a8f7e32
-
wine-bugs＠winehq.org