[Bug 18834] New: Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the insxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

Summary: Repeat installation of vcredist_x86.exe (vcrun2005
                    associated DLLs) deletes them permanently from the
                    insxs folder
           Product: Wine
           Version: 1.1.23
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msi
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

If winetricks is used to install vcrun2005 or vcrun2005sp1 or if a windows
program installs the dlls and associated files by running vcredist_x86.exe, the
first time it is run, the dlls, manifest, policies and associated folders are
installed.

If the packages are installed again, the files and folders are permannetly
removed and cannot be recreated by running the installation again.
Reinstallation generates a number of msi errors.

This is a problem if installing several windows applications when more than one
of the applications run vcredist_x86.exe.
> From logging the terminal output, this appears to be a fault in the msi module

not handling removal and repair of earlier installations.

fixme:msi:msi_unimplemented_action_stub RemoveExistingProducts - > 1 ignored
L"Upgrade" table values
fixme:msi:msi_unimplemented_action_stub MsiUnpublisheAssemblies - > 10 ignored
L"MsiAssembly" table values

since the change seems permanent, this appears to be related to entries to the
.reg files that are not reset/removed properly.

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Repeat installation of      |Repeat installation of
                   |vcredist_x86.exe (vcrun2005 |vcredist_x86.exe (vcrun2005
                   |associated DLLs) deletes    |associated DLLs) deletes
                   |them permanently from the   |them permanently from the
                   |insxs folder                |winsxs folder

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

--- Comment #1 from Austin English   2009-06-08 03:15:20 ---
Have you tested this on windows to ensure it's not a program bug?

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

--- Comment #2 from Hans Leidekker   2009-06-08 08:36:24 ---
Created an attachment (id=21645)
 --> (http://bugs.winehq.org/attachment.cgi?id=21645)
msi: Set REINSTALL property when the product is already installed.

Try this patch.

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

--- Comment #3 from [e-mail]  2009-06-08 11:22:23 ---
(In reply to comment #1)
> Have you tested this on windows to ensure it's not a program bug?

I had not yet deliberately tested this on Windows to see if it is a program bug
as my experience tells me this does not happen: The programs I am using to test
are Hexagon, Carrara and DAZ Studio all by DAZ 3D. I am testing these programs
as I use them regularly on Windows (XP and Vista). They are updated frequently
and each installer will run vcredist_x86.exe automatically at the end of each
install. My Windows winsxs folder remains intact and the programs continue to
run on my Windows machine.

However, I just ran vcredistX86.exe on my windows system and nothing changed in
my windows winsxs folder. Therefore, running vcredist_x86.exe repeatedly does
not destroy the winsxs folder on windows as it does in wine.

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #4 from Hans Leidekker   2009-06-08 12:39:43 ---
I can confirm that repeated installation on Windows leaves
the assemblies in place.

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

--- Comment #5 from [e-mail]  2009-06-09 03:25:01 ---
Created an attachment (id=21669)
 --> (http://bugs.winehq.org/attachment.cgi?id=21669)
Running winetricks to install vcrun2005 and vcrun2005sp1 in patched Wine 1.1.23

This is using the wine made from ./tools/wineinstall after using git to apply
the .diff file. Previous wine removed from my system and old .wine drive
deleted prior to running sh winetricks.  First install copied assemblies
correctly. The second log shows the output of the second install.

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

--- Comment #6 from [e-mail]  2009-06-09 03:26:29 ---
Created an attachment (id=21670)
 --> (http://bugs.winehq.org/attachment.cgi?id=21670)
Installing vcrun2005 and vcrun2005sp1 a second time using winetricks

This is using the wine made from ./tools/wineinstall after using git to apply
the .diff file. First install copied assemblies correctly. This second log
shows the output of the second install. The same problem occurred: previously
installed assemblies were deleted.

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

--- Comment #7 from [e-mail]  2009-06-09 03:29:35 ---
This is the first time I used git and the first time I built wine from sources.
I removed my previous wine installation and deleted the .wine folder. I cloned
the source using git, added the .diff file, did a commit and then used
./tools/wineinstall to install the (modified?) wine.  Unfortunately, as you can
see from the logs, this did not solve the problem although I cannot be certain
I applied the patch correctly being new to this.

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

--- Comment #8 from Hans Leidekker   2009-06-09 03:52:18 ---
Try this:

$ cd /path/to/git/wine
$ patch -p1 < /path/to/patch.diff
$ make
$ WINEDEBUG=+msi ./wine /path/to/vcredist_x86.exe > vcredist.txt 2>&1

And attach vcredist.txt here.

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

--- Comment #9 from [e-mail]  2009-06-09 13:15:41 ---
Created an attachment (id=21691)
 --> (http://bugs.winehq.org/attachment.cgi?id=21691)
Output of first run of /wine-git$ WINEDEBUG=+msi ./wine vcredist_x86.exe >
vcredist1.txt 2>&1

Deleted the .wine folder. Went through the steps outlined by Hans. No errors.
This is the output of the first run through of the 2005 vcredist_x86.exe file
(fresh download from MS).

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

--- Comment #10 from [e-mail]  2009-06-09 13:18:22 ---
Created an attachment (id=21692)
 --> (http://bugs.winehq.org/attachment.cgi?id=21692)
Output of second run of /wine-git$ WINEDEBUG=+msi ./wine vcredist_x86.exe >
vcredist1.txt 2>&1

Ran the command a second time as errors occur on repeat installation of this
package. This is the output of running vcredist_x86.exe (2005) a second time.
This time the winsxs folder stayed intact, no files deleted.

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

--- Comment #11 from [e-mail]  2009-06-09 13:48:15 ---
Just to test, ran the program installer for the program I want to use, Carrara
7 Pro for windows, and for the first time ever, it asked me if I wanted to
uninstall the previous version and then did the uninstall and reinstall as it
should.  However, the installer still deleted the Visual C++ 2005 runtime files
from the winesxs folder and now the behaviour of the installer appears to have
reverted to the previous behaviour: no uninstall and reinstall of previous
installation and deletion of all the files in the winsxs folder if I run the
Cararra installer a second time.

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                 CC|                            |[e-mail]

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

--- Comment #12 from [e-mail]  2009-06-27 02:17:38 ---
Created an attachment (id=22050)
 --> (http://bugs.winehq.org/attachment.cgi?id=22050)
vcredist1.txt and vcredist2.txt combined as a single zip file

the two files, vcredist1.txt and vcredist2.txt zipped to save web server space.

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21645|0                           |1
        is obsolete|                            |

--- Comment #13 from Hans Leidekker   2009-08-05 08:01:34 ---
Created an attachment (id=22825)
 --> (http://bugs.winehq.org/attachment.cgi?id=22825)
msi: Set REINSTALL property when the product is already installed.

Here's an improved patch.

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Hans Leidekker   2009-09-03 04:54:32 ---
Fixed by commit 1169aa9a58563d5182f2e301b77d35610306254e.

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard   2009-09-25 12:25:35 ---
Closing bugs fixed in 1.1.30.

[Bug 18834] Repeat installation of vcredist_x86.exe (vcrun2005 associated DLLs) deletes them permanently from the winsxs folder

http://bugs.winehq.org/show_bug.cgi?id=18834

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |1169aa9a58563d5182f2e301b77
                   |                            |d35610306254e