[Bug 43356] New: Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

Bug ID: 43356
           Summary: Mass Effect (1) Steam freezes since Steam Update from
                    8th of July 2017
           Product: Wine
           Version: 2.12
          Hardware: x86-64
                OS: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]

Used 2.12 Devel until the steam update broke the installation. Moved to 2.12
Staging and Steam could be started again. The problem now is, that Mass Effect
1, which worked fine so far, now freezes after a few minutes.

Wine reports:
err:ntdll:RtlpWaitForCriticalSection section 0xa2e65c
"../../../wine/dlls/dinput/mouse.c: SysMouseImpl*->base.crit" wait timed out in
thread 008b, blocked by 0080, retrying (60 sec)
err:ntdll:RtlpWaitForCriticalSection section 0x21fce33c
"../../../wine/dlls/dinput/dinput_main.c: dinput_hook_crit" wait timed out in
thread 0080, blocked by 008b, retrying (60 sec)

Game hangs and no way to get it out of the loop. Only by killing the process.

Tried several settings (catch/catch not mouse), reduced graphics to low level,
disabled overlay in steam, tried disabling gameoverlayrenderer.dll, tried XP as
well as Windows 7 and Windows 10. Same result everywhere.

Using macOS 10.12.5 on MacBook Pro (Retina, 15-inch, Mid 2015), 2.8 GHz Intel
Core i7, 16 GB 1600 MHz DDR3, AMD Radeon R9 M370X 2048 MB Intel Iris Pro 1536
MB

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Gijs Vermeulen  ---
(In reply to Adi from comment #0)
> Used 2.12 Devel until the steam update broke the installation. Moved to 2.12
> Staging

Does this occur with wine-git (steam fix is in that as well) as well? If not,
you should move this to the Wine-Staging product.

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

--- Comment #2 from Adi  ---
(In reply to Gijs Vermeulen from comment #1)
> (In reply to Adi from comment #0)
> > Used 2.12 Devel until the steam update broke the installation. Moved to 2.12
> > Staging
>
> Does this occur with wine-git (steam fix is in that as well) as well? If
> not, you should move this to the Wine-Staging product.

Not tried yet, always used the binaries at download location.

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

--- Comment #3 from Adi  ---
(In reply to Gijs Vermeulen from comment #1)
> (In reply to Adi from comment #0)
> > Used 2.12 Devel until the steam update broke the installation. Moved to 2.12
> > Staging
>
> Does this occur with wine-git (steam fix is in that as well) as well? If
> not, you should move this to the Wine-Staging product.

Sorry for being that dump. Where can I find the wine-git? Search brings
anything but not really related to wine-git. Download link I used is
https://dl.winehq.org/wine-builds/macosx/pool/winehq-staging-2.12.pkg.

And as mentioned, Steam works fine, only the game does not.

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

--- Comment #4 from Adi  ---
(In reply to Gijs Vermeulen from comment #1)
> (In reply to Adi from comment #0)
> > Used 2.12 Devel until the steam update broke the installation. Moved to 2.12
> > Staging
>
> Does this occur with wine-git (steam fix is in that as well) as well? If
> not, you should move this to the Wine-Staging product.

found it, sorry(In reply to Adi from comment #3)
> (In reply to Gijs Vermeulen from comment #1)
> > (In reply to Adi from comment #0)
> > > Used 2.12 Devel until the steam update broke the installation. Moved to 2.12
> > > Staging
> >
> > Does this occur with wine-git (steam fix is in that as well) as well? If
> > not, you should move this to the Wine-Staging product.
>
> Sorry for being that dumb. Download link I used is
> https://dl.winehq.org/wine-builds/macosx/pool/winehq-staging-2.12.pkg.
>
> And as mentioned, Steam works fine, only the game does not.

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from [e-mail] ---
(In reply to Adi from comment #3)
> (In reply to Gijs Vermeulen from comment #1)
> > (In reply to Adi from comment #0)
> > > Used 2.12 Devel until the steam update broke the installation. Moved to 2.12
> > > Staging
> >
> > Does this occur with wine-git (steam fix is in that as well) as well? If
> > not, you should move this to the Wine-Staging product.
>
> Sorry for being that dump. Where can I find the wine-git? Search brings
> anything but not really related to wine-git. Download link I used is
> https://dl.winehq.org/wine-builds/macosx/pool/winehq-staging-2.12.pkg.
>
> And as mentioned, Steam works fine, only the game does not.

Does the game work if you make a new prefix with an updated version of Wine and
install the game into that new prefix?

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

--- Comment #6 from Adi  ---
(In reply to fjfrackiewicz from comment #5)
> (In reply to Adi from comment #3)
> > (In reply to Gijs Vermeulen from comment #1)
> > > (In reply to Adi from comment #0)
> > > > Used 2.12 Devel until the steam update broke the installation. Moved to 2.12
> > > > Staging
> > >
> > > Does this occur with wine-git (steam fix is in that as well) as well? If
> > > not, you should move this to the Wine-Staging product.
> >
> > Sorry for being that dump. Where can I find the wine-git? Search brings
> > anything but not really related to wine-git. Download link I used is
> > https://dl.winehq.org/wine-builds/macosx/pool/winehq-staging-2.12.pkg.
> >
> > And as mentioned, Steam works fine, only the game does not.
>
> Does the game work if you make a new prefix with an updated version of Wine
> and install the game into that new prefix?

Nope, tried uninstall and reinstall even of different versions. Older versions
refuse with steam. Currently running a build on mac to see if this helps.

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

--- Comment #7 from Adi  ---
(In reply to fjfrackiewicz from comment #5)
> (In reply to Adi from comment #3)
> > (In reply to Gijs Vermeulen from comment #1)
> > > (In reply to Adi from comment #0)
> > > > Used 2.12 Devel until the steam update broke the installation. Moved to 2.12
> > > > Staging
> > >
> > > Does this occur with wine-git (steam fix is in that as well) as well? If
> > > not, you should move this to the Wine-Staging product.
> >
> > Sorry for being that dump. Where can I find the wine-git? Search brings
> > anything but not really related to wine-git. Download link I used is
> > https://dl.winehq.org/wine-builds/macosx/pool/winehq-staging-2.12.pkg.
> >
> > And as mentioned, Steam works fine, only the game does not.
>
> Does the game work if you make a new prefix with an updated version of Wine
> and install the game into that new prefix?

I lack of experience to get the build work on macOS. Sorry. So can't test this.

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

--- Comment #8 from Austin English  ---
(In reply to Adi from comment #3)
> (In reply to Gijs Vermeulen from comment #1)
> > (In reply to Adi from comment #0)
> > > Used 2.12 Devel until the steam update broke the installation. Moved to 2.12
> > > Staging
> >
> > Does this occur with wine-git (steam fix is in that as well) as well? If
> > not, you should move this to the Wine-Staging product.
>
> Sorry for being that dump. Where can I find the wine-git? Search brings
> anything but not really related to wine-git. Download link I used is
> https://dl.winehq.org/wine-builds/macosx/pool/winehq-staging-2.12.pkg.
>
> And as mentioned, Steam works fine, only the game does not.

https://source.winehq.org/git/wine.git/

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

--- Comment #9 from Adi  ---
(In reply to Austin English from comment #8)
> (In reply to Adi from comment #3)
> > (In reply to Gijs Vermeulen from comment #1)
> > > (In reply to Adi from comment #0)
> > > > Used 2.12 Devel until the steam update broke the installation. Moved to 2.12
> > > > Staging
> > >
> > > Does this occur with wine-git (steam fix is in that as well) as well? If
> > > not, you should move this to the Wine-Staging product.
> >
> > Sorry for being that dump. Where can I find the wine-git? Search brings
> > anything but not really related to wine-git. Download link I used is
> > https://dl.winehq.org/wine-builds/macosx/pool/winehq-staging-2.12.pkg.
> >
> > And as mentioned, Steam works fine, only the game does not.
>
> https://source.winehq.org/git/wine.git/

Jep found git meanwhile, used Xcode and sources but failed to get a working
cross-build. Too dumb.

Did test Mass Effect 2 and no problems of this kind so far. Occurs only with
Mass Effect 1.

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |directx-dinput

--- Comment #10 from Sebastian Lackner  ---
(In reply to Adi from comment #0)
> err:ntdll:RtlpWaitForCriticalSection section 0xa2e65c
> "../../../wine/dlls/dinput/mouse.c: SysMouseImpl*->base.crit" wait timed out
> in thread 008b, blocked by 0080, retrying (60 sec)
> err:ntdll:RtlpWaitForCriticalSection section 0x21fce33c
> "../../../wine/dlls/dinput/dinput_main.c: dinput_hook_crit" wait timed out
> in thread 0080, blocked by 008b, retrying (60 sec)

Thanks for reporting this issue. It is certainly a Wine bug (problem with the
order in which critical sections are acquired). Setting component to dinput.

For testing purposes I have pushed the following builds:

* https://dev.wine-staging.com/builder/group/182/ - Wine Staging 2.12 plus a
proposed fix for the dinput bug.

* https://dev.wine-staging.com/builder/group/181/ - Build of Wine 2.12 after
applying the Steam fix.

After the builds have finished click on "Downloads" and grab a pkg or tarball
installer (the pkg files are not signed, so you have to do right-click and open
with the installation program, instead of double-clicking). Please let me know
which of the builds above work. It is possible that the dev version does not
require the critical section fix because the input handling is slower, and does
not trigger this bug.

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

--- Comment #11 from Adi  ---
(In reply to Sebastian Lackner from comment #10)
> (In reply to Adi from comment #0)
> > err:ntdll:RtlpWaitForCriticalSection section 0xa2e65c
> > "../../../wine/dlls/dinput/mouse.c: SysMouseImpl*->base.crit" wait timed out
> > in thread 008b, blocked by 0080, retrying (60 sec)
> > err:ntdll:RtlpWaitForCriticalSection section 0x21fce33c
> > "../../../wine/dlls/dinput/dinput_main.c: dinput_hook_crit" wait timed out
> > in thread 0080, blocked by 008b, retrying (60 sec)
>
> Thanks for reporting this issue. It is certainly a Wine bug (problem with
> the order in which critical sections are acquired). Setting component to
> dinput.
>
> For testing purposes I have pushed the following builds:
> - https://dev.wine-staging.com/builder/group/182/ - Wine Staging 2.12 plus a
>
> proposed fix for the dinput bug.
> - https://dev.wine-staging.com/builder/group/181/ - Build of Wine 2.12 after
>
> applying the Steam fix.
>
> After the builds have finished click on "Downloads" and grab a pkg or
> tarball installer (the pkg files are not signed, so you have to do
> right-click and open with the installation program, instead of
> double-clicking). Please let me know which of the builds above work. It is
> possible that the dev version does not require the critical section fix
> because the input handling is slower, and does not trigger this bug.

Now the devel build works or seems at least. There are little hickups to notice
but it doesn't freeze.

The staging build still has the same problems. So probably it is the slower
input handling that avoids this problem.

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

--- Comment #12 from Sebastian Lackner  ---
(In reply to Adi from comment #11)
> The staging build still has the same problems. So probably it is the slower
> input handling that avoids this problem.

Thanks for testing! Does the terminal output still contain exactly the same
"err:ntdll:RtlpWaitForCriticalSection [...]" messages as above, or anything
else?

Please also attach a log created with WINEDEBUG=+tid,+dinput. For more
information how to collect such a debug trace take a look here:
https://wiki.winehq.org/FAQ#How_do_I_get_a_debug_trace.3F

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

--- Comment #13 from Adi  ---
(In reply to Sebastian Lackner from comment #12)
> (In reply to Adi from comment #11)
> > The staging build still has the same problems. So probably it is the slower
> > input handling that avoids this problem.
>
> Thanks for testing! Does the terminal output still contain exactly the same
> "err:ntdll:RtlpWaitForCriticalSection [...]" messages as above, or anything
> else?
>
> Please also attach a log created with WINEDEBUG=+tid,+dinput. For more
> information how to collect such a debug trace take a look here:
> https://wiki.winehq.org/FAQ#How_do_I_get_a_debug_trace.3F

It contains exact the same error message. Will take a while to create a debug
log, currently RL is forcing me to do other stuff.

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

--- Comment #14 from Adi  ---
(In reply to Sebastian Lackner from comment #12)
> (In reply to Adi from comment #11)
> > The staging build still has the same problems. So probably it is the slower
> > input handling that avoids this problem.
>
> Thanks for testing! Does the terminal output still contain exactly the same
> "err:ntdll:RtlpWaitForCriticalSection [...]" messages as above, or anything
> else?
>
> Please also attach a log created with WINEDEBUG=+tid,+dinput. For more
> information how to collect such a debug trace take a look here:
> https://wiki.winehq.org/FAQ#How_do_I_get_a_debug_trace.3F

No I tested it, but strange, activating the debug solved the problem in the
staging build. Even after running it without debug it worked. No idea what this
behaviour could be. Possibly a library was not loaded correctly or the two
parallel installations influence each other. So there is no error log at the
moment.

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

Kimmo Myllyvirta  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from Kimmo Myllyvirta  ---
Created attachment 58716
  --> https://bugs.winehq.org/attachment.cgi?id=58716
+tid,+dinput debug log

It varies when this happens and is not limited to macOS. With Ubuntu I can play
the game for ~45 minutes until it freezes. With +tid,+dinput it happens
earlier, in the main menu. debug log attached.

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

--- Comment #16 from Kimmo Myllyvirta  ---
The previous was without dinput-fix.diff, sorry for not mentioning it. With the
dinput-fix.diff I can't reproduce any freezes with this game, if it happens it
is at least rare.

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
    Staged patchset|                            |https://github.com/wine-com
                   |                            |pholio/wine-staging/tree/ma
                   |                            |ster/patches/dinput-Deadloc
                   |                            |k
                 CC|                            |[e-mail],
                   |                            |erich.e.hoover@wine-staging
                   |                            |.com, [e-mail]
             Status|UNCONFIRMED                 |STAGED

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Staged patchset|https://github.com/wine-com |https://github.com/wine-sta
                   |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast
                   |ster/patches/dinput-Deadloc |er/patches/dinput-Deadlock
                   |k                           |
                 CC|                            |[e-mail]

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|STAGED                      |RESOLVED
                 CC|                            |[e-mail]
      Fixed by SHA1|                            |02f0342833f6a6affced8205190
                   |                            |03d954681a7b4

--- Comment #17 from Alistair Leslie-Hughes  ---
Fixed by
https://source.winehq.org/git/wine.git/?a=commit;h=02f0342833f6a6affced82051...

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #18 from Alexandre Julliard  ---
Closing bugs fixed in 4.6.

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.x

[Bug 43356] Mass Effect (1) Steam freezes since Steam Update from 8th of July 2017

https://bugs.winehq.org/show_bug.cgi?id=43356

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.x                       |---

--- Comment #19 from Michael Stefaniuc  ---
Removing the 4.0.x milestone from bug fixes included in 4.0.2.