[Bug 20732] New: Icons are not rendered 100% correctly in VB6 apps (regression)

http://bugs.winehq.org/show_bug.cgi?id=20732

Summary: Icons are not rendered 100% correctly in VB6 apps
                    (regression)
           Product: Wine
           Version: 1.1.33
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: oleaut32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Created an attachment (id=24783)
 --> (http://bugs.winehq.org/attachment.cgi?id=24783)
Example application

An icon rendering problem is born between 1.1.25 and 1.1.26

In attachment there is a VB6 test project and screenshots of various
applications that suffer of this rendering problem.

(I hope is correct add Roderick Colenbrander mail to cc, otherwise sorry for
the mistake)

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps (regression)

http://bugs.winehq.org/show_bug.cgi?id=20732

--- Comment #1 from Gabriele Moabiti   2009-11-16 08:53:57 ---
Created an attachment (id=24784)
 --> (http://bugs.winehq.org/attachment.cgi?id=24784)
icons rendered correctly

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps (regression)

http://bugs.winehq.org/show_bug.cgi?id=20732

--- Comment #2 from Gabriele Moabiti   2009-11-16 08:54:30 ---
Created an attachment (id=24785)
 --> (http://bugs.winehq.org/attachment.cgi?id=24785)
icons rendered not so correctly

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps (regression)

http://bugs.winehq.org/show_bug.cgi?id=20732

--- Comment #3 from Gabriele Moabiti   2009-11-16 08:55:09 ---
Created an attachment (id=24786)
 --> (http://bugs.winehq.org/attachment.cgi?id=24786)
program 1 - icons ok

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps (regression)

http://bugs.winehq.org/show_bug.cgi?id=20732

--- Comment #4 from Gabriele Moabiti   2009-11-16 08:55:37 ---
Created an attachment (id=24787)
 --> (http://bugs.winehq.org/attachment.cgi?id=24787)
program 1 - icons not so ok

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps (regression)

http://bugs.winehq.org/show_bug.cgi?id=20732

--- Comment #5 from Gabriele Moabiti   2009-11-16 08:56:01 ---
Created an attachment (id=24788)
 --> (http://bugs.winehq.org/attachment.cgi?id=24788)
program 2 - icons ok

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps (regression)

http://bugs.winehq.org/show_bug.cgi?id=20732

--- Comment #6 from Gabriele Moabiti   2009-11-16 08:56:24 ---
Created an attachment (id=24789)
 --> (http://bugs.winehq.org/attachment.cgi?id=24789)
program 2 - icons not so ok

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps (regression)

http://bugs.winehq.org/show_bug.cgi?id=20732

--- Comment #7 from Gabriele Moabiti   2009-11-16 09:07:16 ---
Created an attachment (id=24790)
 --> (http://bugs.winehq.org/attachment.cgi?id=24790)
Example application on XP

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps

http://bugs.winehq.org/show_bug.cgi?id=20732

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
          Component|oleaut32                    |-unknown
            Summary|Icons are not rendered 100% |Icons are not rendered 100%
                   |correctly in VB6 apps       |correctly in VB6 apps
                   |(regression)                |

--- Comment #8 from Dmitry Timoshkov   2009-11-16 13:05:11 ---
Please post the results of your regerssion testing:
http://wiki.winehq.org/RegressionTesting

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps

http://bugs.winehq.org/show_bug.cgi?id=20732

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Wylda   2009-11-16 18:34:55 ---

Hi Gabriele, this is duplicate of bug 20164. Probably this bug will be closed,
so put yourself to CC in 20164. In 20164 i also pinpoint your test application
for testing.

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps

http://bugs.winehq.org/show_bug.cgi?id=20732

--- Comment #10 from Roderick Colenbrander   2009-11-17 03:16:23 ---
Well both bugs are affected by the same patch but I'm not certain if both are
the same issue.

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps

http://bugs.winehq.org/show_bug.cgi?id=20732

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps

http://bugs.winehq.org/show_bug.cgi?id=20732

--- Comment #11 from Gabriele Moabiti   2010-02-18 08:20:50 ---
Created an attachment (id=26296)
 --> (http://bugs.winehq.org/attachment.cgi?id=26296)
Example rebuilded with ICO files attached

To verify the render behaviuour with the icons inserted in Imagelist

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps

http://bugs.winehq.org/show_bug.cgi?id=20732

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |comctl32

--- Comment #12 from Roderick Colenbrander   2010-02-18 08:34:17 ---
Initially I expected this bug to be related to XRender code. During debugging I
noticed that 32x32 icons were scaled to 16x16 which seemed strange. Contact
with Gabriele on irc learned that the vb6 app ships both 16x16 and 32x32 icons.
The 16x16 version looks the same as Windows.

The issue is likely that the imagelist code loads the 32x32 icon instead of the
16x16 version.

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps

http://bugs.winehq.org/show_bug.cgi?id=20732

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|regression                  |

--- Comment #13 from Alexandre Julliard   2010-05-26 13:27:18 ---
The problem is that OleLoadPictureEx ignores the specified size and always
loads a 32x32 icon. It's not really a regression, this has never worked.

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps

http://bugs.winehq.org/show_bug.cgi?id=20732

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|comctl32                    |oleaut32

--- Comment #14 from Nikolay Sivov  2011-09-30 13:53:01 CDT ---
Gabriele, do you have a working recipe to start this test application? I mean
vb6run from winetricks is not enough apparently. Once it runs we could probably
dump stream data (from resources right?) to see what's actually passed to
loading call. If I got this right this function should detect multiple icons in
a stream and use appropriate one.

Also changing component to oleaut32.

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps

http://bugs.winehq.org/show_bug.cgi?id=20732

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from Bruno Jesus  2011-09-30 14:04:02 CDT ---
You need this: http://www.microsoft.com/download/en/details.aspx?id=10019

I'm not sure if it's in winetricks.

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps

http://bugs.winehq.org/show_bug.cgi?id=20732

--- Comment #16 from Austin English  2011-10-01 08:55:42 CDT ---
(In reply to comment #15)
> You need this: http://www.microsoft.com/download/en/details.aspx?id=10019
>
> I'm not sure if it's in winetricks.

comctl32.ocx is, these are not. Patches welcome.

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps

http://bugs.winehq.org/show_bug.cgi?id=20732

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #17 from Austin English  ---
Still in wine-1.7.11-206-g82b3813

austin@aw25 ~ $ sha1sum vb6example.zip 
9d30ac39d2cbad6cc42d964f402c823be6942e25  vb6example.zip
austin@aw25 ~ $ du -h vb6example.zip 
12K    vb6example.zip
austin@aw25 ~ $ wine --version
wine-1.7.11-206-g82b3813

needs 'winetricks comctl32ocx vb6run' first.

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps

https://bugs.winehq.org/show_bug.cgi?id=20732

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #18 from [e-mail] ---
Still an issue to me 1.9.12. It's really hard to spot the difference.

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps

https://bugs.winehq.org/show_bug.cgi?id=20732

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #19 from Fabian Maurer  ---
Still in wine-3.9.

[Bug 20732] Icons are not rendered 100% correctly in VB6 apps

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=20732

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |patch

--- Comment #20 from Damjan Jovanovic  ---
Patch sent: https://source.winehq.org/patches/data/179819