[Bug 30618] New: Common dialogs should use icons from Linux system icon theme

http://bugs.winehq.org/show_bug.cgi?id=30618

Bug #: 30618
           Summary: Common dialogs should use icons from Linux system icon
                    theme
           Product: Wine
           Version: 1.5.3
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: comdlg32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Currently, the common dialogs like Open/Save use the Tango icon theme,
regardless of what the Linux desktop is configured to use. (They also seem to
use the plaintext icon for anything that isn't an EXE with its own embedded
one)

It'd probably require an ugly hack (and not necessarily be a good idea anyway)
to intercept ALL requests to read standard icons normally bundled with Windows.

However, using the system icon theme to populate toolbars and file lists in
common dialogs should be reasonably simple for someone already familiar with
the codebase and would help to reduce the alienness of Windows UIs on a Linux
desktop.

Of course, a checkbox or registry key to disable it would be necessary since
Wine doesn't automatically use the GTK+ color scheme and some icon themes are
unusable without toolbars using a light-on-dark colour scheme.

I doubt I'll have time to implement this myself (especially given that I have
no experience with the Wine codebase and almost none with C or C++) but I'll
leave myself a note to research retrieving system icons without GtkIconTheme or
QIcon once I'm finished my exam preparation.

[Bug 30618] Common dialogs should use icons from Linux system icon theme

http://bugs.winehq.org/show_bug.cgi?id=30618

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |integration
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #1 from Jerome Leclanche  2012-05-08 07:18:02 CDT ---
Retrieving the icon theme without qicon/gtkicontheme requires interacting with
xsettings, which is something I do not believe Wine does currently.
Then, wine would have to implement theme fallbacks and a final fallback to
hicolor.

Additionally, this would need a mapping of standard windows icons -> fd.o
icon-naming.

Finally, since Wine runs on platforms that do not use fd.o standards, this
would need:
 - An OSX implementation
 - A final fallback to Tango

So all in all, much work for not much gain. I'd be all for it but who's going
to do it? :)

[Bug 30618] Common dialogs should use icons from Linux system icon theme

http://bugs.winehq.org/show_bug.cgi?id=30618

--- Comment #2 from Stephan Sokolow  2012-05-08 07:37:00 CDT ---
I'll keep it in mind in case I can spare the time.

Since, once my exam study is over, I plan to provide "just change this to that"
solutions in the bug reports I file on various Java apps and on WinPDB, I'll
probably need to implement something like this for Java and wxPython apps
anyway. If/when I do, porting it for use in Wine probably wouldn't be too
difficult.

Obviously a fallback would be important. My plan was to do something along the
lines of how fallback can be handled in QIcon::fromTheme and just keep the
existing icon lookup around as the fallback.

As for writing up a mapping table, that's actually the one kind of drudge-work
I don't mind when I do it on my own initiative.

Thanks for mentioning xsettings. How you look up the name of the currently
active icon theme is the one glaring detail not included in the pseudocode in
the XDG icon theme spec.

[Bug 30618] Common dialogs should use icons from Linux system icon theme

http://bugs.winehq.org/show_bug.cgi?id=30618

--- Comment #3 from Jerome Leclanche  2012-05-08 07:45:38 CDT ---
(In reply to comment #2)
http://git.gnome.org/browse/gtk+/tree/gdk/x11/gdksettings.c

So Net/IconThemeName gtk-icon-theme-name

[Bug 30618] Common dialogs should use icons from Linux system icon theme

http://bugs.winehq.org/show_bug.cgi?id=30618

--- Comment #4 from Austin English  ---
This is your friendly reminder that there has been no bug activity for 2 years.
Is this still an issue in current (1.7.18 or newer) wine?

[Bug 30618] Common dialogs should use icons from Linux system icon theme

http://bugs.winehq.org/show_bug.cgi?id=30618

--- Comment #5 from Stephan Sokolow  ---
(In reply to Austin English from comment #4)
> This is your friendly reminder that there has been no bug activity for 2
> years. Is this still an issue in current (1.7.18 or newer) wine?

Still an issue.

[Bug 30618] Common dialogs should use icons from Linux system icon theme

https://bugs.winehq.org/show_bug.cgi?id=30618

Qian Hong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 30618] Common dialogs should use icons from Linux system icon theme

https://bugs.winehq.org/show_bug.cgi?id=30618

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]