[Bug 26482] New: Typo in c2man.pl leads to FTBFS

http://bugs.winehq.org/show_bug.cgi?id=26482

Summary: Typo in c2man.pl leads to FTBFS
           Product: Wine
           Version: 1.3.16
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: tools
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Created an attachment (id=33715)
 --> (http://bugs.winehq.org/attachment.cgi?id=33715)
Trival patch to fix the typo

The recent changes to c2man.pl [0] introduced an typo leading to an build
error:
> make[3]: Entering directory `/tmp/buildd/wine-unstable-1.3.16/build32/dlls/acledit'
> ../../../tools/c2man.pl -o ../../documentation/man3w -R../.. -C../../../dlls/acledit -S3w -I../../../dlls/acledit -I. -I../../../include -I../../include  -w acledit.spec main.c
> Global symbol "$FLAGS_DOCUMENTED" requires explicit package name at ../../../tools/c2man.pl line 1993.
> Execution of ../../../tools/c2man.pl aborted due to compilation errors.
> make[3]: *** [manpages] Error 255
> make[3]: Leaving directory `/tmp/buildd/wine-unstable-1.3.16/build32/dlls/acledit'
> make[2]: *** [manpages] Error 2
> make[2]: Leaving directory `/tmp/buildd/wine-unstable-1.3.16/build32'
> make[1]: *** [install-man] Error 2
> make[1]: Leaving directory `/tmp/buildd/wine-unstable-1.3.16/build32/documentation'

Attached you'll find a trivial patch to fix the issue.

Cheers,
Kai

P.S.: CCed Alexandre as he was the commiter

[0]
http://source.winehq.org/git/wine.git/commitdiff/1d79674150d53f124febbb2d35e...

[Bug 26482] Typo in c2man.pl leads to FTBFS

http://bugs.winehq.org/show_bug.cgi?id=26482

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #1 from Austin English  2011-03-19 16:50:13 CDT ---
Patches should be sent to [e-mail], they aren't picked up from
bugzilla.

[Bug 26482] Typo in c2man.pl leads to FTBFS

http://bugs.winehq.org/show_bug.cgi?id=26482

--- Comment #2 from Cùran  2011-03-20 08:55:06 CDT ---
In reply to comment #1:
I've sent the patch be e-mail to wine-patches ([0]), but it hasn't shown up in
the archives [1] yet. Do I need to be subscribed (didn't get a reply from the
list server to that effect)?.

[0] Message-ID: 
[1] http://www.winehq.org/pipermail/wine-patches/2011-March/thread.html

[Bug 26482] Typo in c2man.pl leads to FTBFS

http://bugs.winehq.org/show_bug.cgi?id=26482

--- Comment #3 from Henri Verbeet  2011-03-20 11:18:28 CDT ---
(In reply to comment #2)
> I've sent the patch be e-mail to wine-patches ([0]), but it hasn't shown up in
> the archives [1] yet. Do I need to be subscribed (didn't get a reply from the
> list server to that effect)?.

If you're going to send patches more often, subscribing is certainly useful.
Mail from unsubscribed addresses goes through moderation first. This may take a
few days, but it should show up eventually. Note that Alexandre is currently on
vacation, he should be back in about a week or so.

[Bug 26482] Typo in c2man.pl leads to FTBFS

http://bugs.winehq.org/show_bug.cgi?id=26482

--- Comment #4 from Cùran  2011-03-20 13:07:11 CDT ---
In reply to comment #1 and comment #3:
Ok, can then one of you two apply the patch in Git. It is really trivial, it
just removes a superfluous "S" which makes c2man.pl non-executable (as can be
seen from comment #0). And a build failure is nothing too nice.

[Bug 26482] Typo in c2man.pl leads to FTBFS

http://bugs.winehq.org/show_bug.cgi?id=26482

NSLW  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |m

--- Comment #5 from NSLW  2011-03-21 02:36:45 CDT ---
(In reply to comment #4)
> Ok, can then one of you two apply the patch in Git. It is really trivial, it
> just removes a superfluous "S" which makes c2man.pl non-executable (as can be
> seen from comment #0). And a build failure is nothing too nice.

I think Alexandre has introduced authoritarian policies and nobody beside him
can accept anything in Wine.

[Bug 26482] Typo in c2man.pl leads to FTBFS

http://bugs.winehq.org/show_bug.cgi?id=26482

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|All                         |Other
         OS/Version|All                         |other
           Severity|critical                    |minor

[Bug 26482] Typo in c2man.pl leads to FTBFS

http://bugs.winehq.org/show_bug.cgi?id=26482

Detlef Riekenberg  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Detlef Riekenberg  2011-04-01 17:10:49 CDT ---
Thanks for improving Wine.

Alexandre fixed the typo shortly after the release,
but the fix was not published, when you wrote this report:
http://source.winehq.org/git/wine.git/commitdiff/35d72134075a9f2e77d15f0e69c...

[Bug 26482] Typo in c2man.pl leads to FTBFS

http://bugs.winehq.org/show_bug.cgi?id=26482

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  2011-04-15 12:51:07 CDT ---
Closing bugs fixed in 1.3.18.