https://bugs.winehq.org/show_bug.cgi?id=50244
Bug ID: 50244 Summary: Melodyne 5: activation via internet does not work Product: Wine Version: 5.22 Hardware: x86-64 URL: https://services.celemony.com/cgi-bin/WebObjects/Licen seApp.woa/wa/demoRegistration?item=Melodyne5-Demo-Win& language=en OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: andriy.parhomenko@gmail.com Distribution: Ubuntu
Created attachment 68754 --> https://bugs.winehq.org/attachment.cgi?id=68754 Melodyne activation backtrace
I succesfully installed Melodyne 5 with Wine Staging 5.22, gdiplus and vcrun2019 overrides and this patch https://source.winehq.org/patches/data/186184 (from bug 49286).
It runs ok, but when I try to activate it, I'm getting an error instead of opening a browser window that should lead to activation page. There is no errors in the console output.
The error message from Melodyne itself has such lines:
identifier = "com.celemony.https.request_failed.12152.1"; message = "Could not receive response.";
Wine backtrace with WINEDEBUG=+winhttp,+winsock,+wininet,+secur32 is in attachment.
In Melodyne error I see HTTP error code 12152, and in wine's backtrace I see the line:
0110:trace:winhttp:read_line returning empty string
According to wine's source code in winhttp/request.c line 2393, it produces ERROR_WINHTTP_INVALID_SERVER_RESPONSE, which is that exact error code 12152.
Also, the error occurs after Celemony website returns a redirect for first POST request.
So my guess is that something might be wrong with wine handling the redirect
https://bugs.winehq.org/show_bug.cgi?id=50244
parhom andriy.parhomenko@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=49286
https://bugs.winehq.org/show_bug.cgi?id=50244
--- Comment #1 from parhom andriy.parhomenko@gmail.com --- Created attachment 68755 --> https://bugs.winehq.org/attachment.cgi?id=68755 Melodyne error message
https://bugs.winehq.org/show_bug.cgi?id=50244
--- Comment #2 from Hans Leidekker hans@meelstraat.net --- Thanks. The POST request is sent with 599 bytes of data:
0174:trace:winhttp:send_request full request: "POST /api/melodyne4/activateHost?v=1 HTTP/1.1\r\nHost: connect-v1.celemony.com\r\nAccept: application/json\r\nContent-Type: application/json; charset=utf-8\r\nUser-Agent: HTTPProcessor: com.celemony.melodyne\r\nContent-Length: 599\r\nConnection: Keep-Alive\r\n\r\n"
It's redirected and then resent without the data:
0174:trace:winhttp:send_request full request: "POST /cgi-bin/WebObjects/LicenseApp.woa/mc/Melodyne4Service/activateHost?v=1 HTTP/1.1\r\nAccept: application/json\r\nUser-Agent: HTTPProcessor: com.celemony.melodyne\r\nConnection: Keep-Alive\r\nHost: connect-v1.celemony.com\r\nContent-Length: 0\r\n\r\n"
which probably causes the empty response.
https://bugs.winehq.org/show_bug.cgi?id=50244
--- Comment #3 from Hans Leidekker hans@meelstraat.net --- (In reply to Hans Leidekker from comment #2)
It's redirected and then resent without the data:
0174:trace:winhttp:send_request full request: "POST /cgi-bin/WebObjects/LicenseApp.woa/mc/Melodyne4Service/activateHost?v=1 HTTP/1.1\r\nAccept: application/json\r\nUser-Agent: HTTPProcessor: com.celemony.melodyne\r\nConnection: Keep-Alive\r\nHost: connect-v1.celemony.com\r\nContent-Length: 0\r\n\r\n"
which probably causes the empty response.
With the Content-Length header fixed I still get an empty response.
https://bugs.winehq.org/show_bug.cgi?id=50244
--- Comment #4 from parhom andriy.parhomenko@gmail.com --- (In reply to Hans Leidekker from comment #3)
With the Content-Length header fixed I still get an empty response.
Could it be possible, that after you fixed the header, the actual request data was not sent anyway?
I'm not very experienced in C, but it seems that in receive_response function the send_request is called with total_len parameter hardcoded to 0.
https://bugs.winehq.org/show_bug.cgi?id=50244
--- Comment #5 from Hans Leidekker hans@meelstraat.net --- (In reply to parhom from comment #4)
(In reply to Hans Leidekker from comment #3)
With the Content-Length header fixed I still get an empty response.
Could it be possible, that after you fixed the header, the actual request data was not sent anyway?
It was sent just like before I fixed the header. This will need some tests on Windows.
https://bugs.winehq.org/show_bug.cgi?id=50244
--- Comment #6 from parhom andriy.parhomenko@gmail.com --- (In reply to Hans Leidekker from comment #5)
It was sent just like before I fixed the header. This will need some tests on Windows.
I have a Windows machine too. How can I help to test this?
https://bugs.winehq.org/show_bug.cgi?id=50244
--- Comment #7 from Hans Leidekker hans@meelstraat.net --- (In reply to parhom from comment #6)
(In reply to Hans Leidekker from comment #5)
It was sent just like before I fixed the header. This will need some tests on Windows.
I have a Windows machine too. How can I help to test this?
No need, I found the cause of this bug. We're not handling the "Connection: Close" header in this case. Even though the redirect is to the same host it wants you to reconnect anyway. With that fixed activation still fails. We get an error response (json format) which isn't very informative:
"{\n\t"errorCode" = "0";\n\t"errorMessage" = "general error";\n\t"resultType" = "error";\n}"
https://bugs.winehq.org/show_bug.cgi?id=50244
--- Comment #8 from parhom andriy.parhomenko@gmail.com --- (In reply to Hans Leidekker from comment #7)
Could you please send me your patch, so I could try it on my licensed version of Melodyne?
https://bugs.winehq.org/show_bug.cgi?id=50244
--- Comment #9 from Hans Leidekker hans@meelstraat.net --- Created attachment 68766 --> https://bugs.winehq.org/attachment.cgi?id=68766 patch
https://bugs.winehq.org/show_bug.cgi?id=50244
--- Comment #10 from parhom andriy.parhomenko@gmail.com --- Also no luck with the patch, licensed Melodyne and Wine Staging 6.0-rc1.
Is there anything I can do to help further investigate the issue?
https://bugs.winehq.org/show_bug.cgi?id=50244
--- Comment #11 from Hans Leidekker hans@meelstraat.net --- (In reply to parhom from comment #10)
Also no luck with the patch, licensed Melodyne and Wine Staging 6.0-rc1.
Is there anything I can do to help further investigate the issue?
If you no longer see the 12152 error then this bug is fixed by that patch. You could open a new bug for the next issue.
https://bugs.winehq.org/show_bug.cgi?id=50244
--- Comment #12 from parhom andriy.parhomenko@gmail.com --- Yes, the patch fixes the 12152 error, thank you!
I've created a separate bug report for the next issue: https://bugs.winehq.org/show_bug.cgi?id=50272
https://bugs.winehq.org/show_bug.cgi?id=50244
parhom andriy.parhomenko@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=50272
https://bugs.winehq.org/show_bug.cgi?id=50244
Aleksandr Kichev kichev.alexander@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kichev.alexander@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=50244
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com
--- Comment #13 from winetest@luukku.com --- was the patch merged into wine? If so this bug should be closed as fixed. alsa the title should be changed to match the known issue better.
https://bugs.winehq.org/show_bug.cgi?id=50244
--- Comment #14 from parhom andriy.parhomenko@gmail.com --- I'm still getting 12152 error on Wine Staging 6.7, so the patch has not yet been applied.
https://bugs.winehq.org/show_bug.cgi?id=50244
parhom andriy.parhomenko@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Melodyne 5: activation via |Melodyne 5: activation via |internet does not work |internet fails with 12152 | |error
https://bugs.winehq.org/show_bug.cgi?id=50244
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fgouget@codeweavers.com Keywords| |patch
https://bugs.winehq.org/show_bug.cgi?id=50244
--- Comment #15 from parhom andriy.parhomenko@gmail.com --- Wine Staging 6.13, still getting same error.
https://bugs.winehq.org/show_bug.cgi?id=50244
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- URL|https://services.celemony.c |https://web.archive.org/web |om/cgi-bin/WebObjects/Licen |/20201215162012/https://d1i |seApp.woa/wa/demoRegistrati |187rinc1hq3.cloudfront.net/ |on?item=Melodyne5-Demo-Win& |Demos/Melodyne.5.1.1.03-Dem |language=en |o.zip Keywords| |download Component|-unknown |winhttp CC| |focht@gmx.net
https://bugs.winehq.org/show_bug.cgi?id=50244
--- Comment #16 from parhom andriy.parhomenko@gmail.com --- Still the same on Wine Staging 6.14.
https://bugs.winehq.org/show_bug.cgi?id=50244
Hector Martin marcan@marcansoft.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |marcan@marcansoft.com
--- Comment #17 from Hector Martin marcan@marcansoft.com --- @parhom have you submitted the patch following the documentation?
https://wiki.winehq.org/Submitting_Patches
https://bugs.winehq.org/show_bug.cgi?id=50244
--- Comment #18 from Hector Martin marcan@marcansoft.com --- Sorry, not @parhom, I got confused; the patch was by Hans who is a Wine dev. Any chance of this going in?
https://bugs.winehq.org/show_bug.cgi?id=50244
Hector Martin marcan@marcansoft.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hans@meelstraat.net
--- Comment #19 from Hector Martin marcan@marcansoft.com --- +cc Hans on the bug since he's not on the CC list for some reason.
Hans, your patch fixes the first issue; the second issue is just a missing Content-Type across the redirect, I have a trivial patch for that in #50272. With that change Melodyne activation works.
https://bugs.winehq.org/show_bug.cgi?id=50244
Robbert van der Helm mail@robbertvanderhelm.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@robbertvanderhelm.nl
https://bugs.winehq.org/show_bug.cgi?id=50244
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |239964ce86ab3761c86862784c9 | |4461e5f9f516c Resolution|--- |FIXED
--- Comment #20 from Hans Leidekker hans@meelstraat.net --- Fixed with 239964ce86ab3761c86862784c94461e5f9f516c.
https://bugs.winehq.org/show_bug.cgi?id=50244
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #21 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.18.
https://bugs.winehq.org/show_bug.cgi?id=50244
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |6.0.x
https://bugs.winehq.org/show_bug.cgi?id=50244
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|6.0.x |---
--- Comment #22 from Michael Stefaniuc mstefani@winehq.org --- Removing the 6.0.x milestone from bug fixes included in 6.0.3.