[Bug 26070] New: user32/class tests show some valgrind warnings

http://bugs.winehq.org/show_bug.cgi?id=26070

Summary: user32/class tests show some valgrind warnings
           Product: Wine
           Version: 1.3.13
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: minor
          Priority: P2
         Component: user32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Invalid read of size 2
    at  RtlImageNtHeader (loader.c:2508)
    by  RtlImageDirectoryEntryToData (loader.c:2684)
    by  find_entry (resource.c:189)
    by  LdrFindResource_U (resource.c:303)
    by  find_resourceW (resource.c:139)
    by  FindResourceExW (resource.c:183)
    by  FindResourceW (resource.c:192)
    by  LoadMenuW (menu.c:4359)
    by  WIN_CreateWindowEx (win.c:1372)
    by  CreateWindowExA (win.c:1550)
    by  check_instance_ (class.c:266)
    by  test_instances (class.c:441)
    by  func_class (class.c:995)
    by  run_test (test.h:556)
    by  main (test.h:624)
  Address 0x12345678 is not stack'd, malloc'd or (recently) free'd

...

28 bytes in 1 blocks are definitely lost 
    at  notify_alloc (heap.c:254)
    by  RtlAllocateHeap (heap.c:1701)
    by  DIALOG_get_info (defdlg.c:335)
    by  DIALOG_CreateIndirect (dialog.c:669)
    by  CreateDialogIndirectParamAorW (dialog.c:755)
    by  CreateDialogIndirectParamA (dialog.c:764)
    by  CreateDialogParamA (dialog.c:729)
    by  CreateDialogParamTest (class.c:878)
    by  func_class (class.c:990)
    by  run_test (test.h:556)
    by  main (test.h:624)

...

42,420 bytes in 21 blocks are possibly lost 
    at  notify_alloc (heap.c:254)
    by  RtlAllocateHeap (heap.c:1701)
    by  get_tls_data (test.h:240)
    by  winetest_set_location (test.h:275)
    by  check_instance_ (class.c:263)
    by  thread_proc (class.c:292)
    by  ??? (signal_i386.c:2473)
    by  call_thread_entry_point (signal_i386.c:2499)
    by  start_thread (thread.c:404)
    by  start_thread (in /lib/libpthread-2.11.2.so)
    by  clone (in /lib/libc-2.11.2.so)

[Bug 26070] user32/class tests show some valgrind warnings

http://bugs.winehq.org/show_bug.cgi?id=26070

--- Comment #1 from Austin English  2012-09-26 15:46:10 CDT ---
Down to 1
==20531== Invalid read of size 2
==20531==    at 0x7BC504A3: RtlImageNtHeader (loader.c:2555)
==20531==    by 0x7BC505FA: RtlImageDirectoryEntryToData (loader.c:2731)
==20531==    by 0x7BC696A5: find_entry (resource.c:189)
==20531==    by 0x7BC69CC2: LdrFindResource_U (resource.c:303)
==20531==    by 0x7B86AC0F: find_resourceW (resource.c:139)
==20531==    by 0x7B86C8E8: FindResourceExW (resource.c:183)
==20531==    by 0x7B86C9B2: FindResourceW (resource.c:192)
==20531==    by 0x4A89DCC: LoadMenuW (menu.c:4455)
==20531==    by 0x4AC0B73: WIN_CreateWindowEx (win.c:1457)
==20531==    by 0x4AB96D6: CreateWindowExA (win.c:1635)
==20531==    by 0x48EF80D: check_instance_ (class.c:265)
==20531==    by 0x48F2CE5: func_class (class.c:440)
==20531==    by 0x48EC0D6: main (test.h:557)

wine-1.5.13-346-g0445393

[Bug 26070] user32/class tests show some valgrind warnings

https://bugs.winehq.org/show_bug.cgi?id=26070

--- Comment #2 from Austin English  ---
Created attachment 48229
  --> https://bugs.winehq.org/attachment.cgi?id=48229
valgrind log in wine-1.7.17-42-g24c5728

[Bug 26070] user32/class tests show some valgrind warnings

https://bugs.winehq.org/show_bug.cgi?id=26070

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |valgrind

[Bug 26070] user32/class tests show some valgrind warnings

https://bugs.winehq.org/show_bug.cgi?id=26070

--- Comment #3 from Sven  ---
Some leaks were fixed in

2859e7d143d40a5cec330cd6c5b37b919a04a9bc
04847e68f87b26eeef5cbe6a852b1f3914f956e4
470f7b20d468a846f9154450cf2a8000163d5534

The "Conditional jump or move depends on uninitialised value(s)" is tracked in
bug 30827

All other warnings that I found (not definite leaks) are most likely on purpose
and are not supposed to be fixed since there (HINSTANCE)0x12345678 is used as
instance.

[Bug 26070] user32/class tests show some valgrind warnings

https://bugs.winehq.org/show_bug.cgi?id=26070

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Austin English  ---
All I see in 4.0-rc2 is:
==23546== 42,420 bytes in 21 blocks are possibly lost in loss record 1,091 of
1,093
==23546==    at 0x7BC483AD: notify_alloc (heap.c:260)
==23546==    by 0x7BC4B8D1: RtlAllocateHeap (heap.c:1726)
==23546==    by 0x4D06169: get_tls_data (test.h:256)
==23546==    by 0x4D06543: winetest_set_location (test.h:291)
==23546==    by 0x4C1F00A: check_instance_ (class.c:300)
==23546==    by 0x4C1F1E1: thread_proc (class.c:329)
==23546==    by 0x7BC77F0F: ??? (in
/home/austin/wine-valgrind/dlls/ntdll/ntdll.dll.so)
==23546==    by 0x7BC7B2D5: call_thread_func (signal_i386.c:2654)
==23546==    by 0x7BC77F01: ??? (in
/home/austin/wine-valgrind/dlls/ntdll/ntdll.dll.so)
==23546==

marking fixed.

[Bug 26070] user32/class tests show some valgrind warnings

https://bugs.winehq.org/show_bug.cgi?id=26070

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 4.0-rc3.