[Bug 39770] New: "Enter/Exit Full Screen" menu didn't be localized.

https://bugs.winehq.org/show_bug.cgi?id=39770

Bug ID: 39770
           Summary: "Enter/Exit Full Screen" menu didn't be localized.
           Product: Wine
           Version: 1.8-rc3
          Hardware: x86
                OS: Mac OS X
            Status: NEW
          Severity: normal
          Priority: P2
         Component: winemac.drv
          Assignee: [e-mail]
          Reporter: [e-mail]

Created attachment 53055
  --> https://bugs.winehq.org/attachment.cgi?id=53055
Simplified Chinese - zh_CN.UTF-8

reproduce:
1. export LANG=zh_CN.UTF-8
2. wine notepad

Then you can find "窗口->Enter Full Screen" didn't be translated to Chinese
though we had translated this string in Wine.
And after you enter full screen, you can find "窗口->Exit Full Screen" didn't be
translated too.

ru_RU.UTF-8 also can reproduce this bug.

[Bug 39770] "Enter/Exit Full Screen" menu didn't be localized.

https://bugs.winehq.org/show_bug.cgi?id=39770

--- Comment #1 from Jactry Zeng  ---
Created attachment 53056
  --> https://bugs.winehq.org/attachment.cgi?id=53056
Russian - ru_RU.UTF-8

[Bug 39770] "Enter/Exit Full Screen" menu didn't be localized.

https://bugs.winehq.org/show_bug.cgi?id=39770

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 39770] "Enter/Exit Full Screen" menu didn't be localized.

https://bugs.winehq.org/show_bug.cgi?id=39770

--- Comment #2 from Ken Thomases  ---
What happens if, instead of setting LANG (or LC_ALL), you actually change the
system language in System Preferences > Language & Region?

Cocoa is replacing the menu item that the Mac driver creates programmatically
with its own.  (For example, the Mac driver doesn't have the text "Exit Full
Screen" anywhere in it, but the menu item's title changes to that
automatically.)  I expect that Cocoa is respecting the system language rather
than LANG or LC_ALL.

[Bug 39770] "Enter/Exit Full Screen" menu didn't be localized.

https://bugs.winehq.org/show_bug.cgi?id=39770

--- Comment #3 from Jactry Zeng  ---
Hi Ken,
(In reply to Ken Thomases from comment #2)
> What happens if, instead of setting LANG (or LC_ALL), you actually change
> the system language in System Preferences > Language & Region?
>
> Cocoa is replacing the menu item that the Mac driver creates
> programmatically with its own.  (For example, the Mac driver doesn't have
> the text "Exit Full Screen" anywhere in it, but the menu item's title
> changes to that automatically.)  I expect that Cocoa is respecting the
> system language rather than LANG or LC_ALL.

I always use Simplified Chinese as my system language. This my `locale`:
LANG="zh_CN.UTF-8"
LC_COLLATE="zh_CN.UTF-8"
LC_CTYPE="zh_CN.UTF-8"
LC_MESSAGES="zh_CN.UTF-8"
LC_MONETARY="zh_CN.UTF-8"
LC_NUMERIC="zh_CN.UTF-8"
LC_TIME="zh_CN.UTF-8"
LC_ALL=

It seems Cocoa doesn't do that.

Thanks! :-)

[Bug 39770] "Enter/Exit Full Screen" menu didn't be localized.

https://bugs.winehq.org/show_bug.cgi?id=39770

Ken Thomases  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #4 from Ken Thomases  ---
I believe this should be fixed by
http://source.winehq.org/patches/data/117233.

[Bug 39770] "Enter/Exit Full Screen" menu didn't be localized.

https://bugs.winehq.org/show_bug.cgi?id=39770

--- Comment #5 from Jactry Zeng  ---
(In reply to Ken Thomases from comment #4)
> I believe this should be fixed by
> http://source.winehq.org/patches/data/117233.

Thanks Ken! It works! :-)

[Bug 39770] "Enter/Exit Full Screen" menu didn't be localized.

https://bugs.winehq.org/show_bug.cgi?id=39770

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from [e-mail] ---
(In reply to Jactry Zeng from comment #5)
> (In reply to Ken Thomases from comment #4)
> > I believe this should be fixed by
> > http://source.winehq.org/patches/data/117233.
>
> Thanks Ken! It works! :-)

Got committed.

[Bug 39770] "Enter/Exit Full Screen" menu didn't be localized.

https://bugs.winehq.org/show_bug.cgi?id=39770

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |19cb98aa1de0e6a69bfd59604d9
                   |                            |b415240ffdf2d
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Jactry Zeng  ---
Fixed:
http://source.winehq.org/git/wine.git/?a=commit;h=19cb98aa1de0e6a69bfd59604d...

Thanks Ken!

[Bug 39770] "Enter/Exit Full Screen" menu isn't localized

https://bugs.winehq.org/show_bug.cgi?id=39770

Matteo Bruni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|"Enter/Exit Full Screen"    |"Enter/Exit Full Screen"
                   |menu didn't be localized.   |menu isn't localized

[Bug 39770] "Enter/Exit Full Screen" menu isn't localized

https://bugs.winehq.org/show_bug.cgi?id=39770

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.0.