http://bugs.winehq.org/show_bug.cgi?id=18811
Summary: Lexware: wine crashes during .Net 2.0 SP1 Installation Product: Wine Version: 1.1.23 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: msi AssignedTo: wine-bugs@winehq.org ReportedBy: koesterreich@gmx.net
Created an attachment (id=21615) --> (http://bugs.winehq.org/attachment.cgi?id=21615) Output of wine
I am trying to install "Lexware business office pro 2009" (http://appdb.winehq.org/objectManager.php?sClass=version&iId=15277).
When the Lexware-Installer wants to update the .Net Framework 2.0, wine crashes.
Appending log.
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #1 from Austin English austinenglish@gmail.com 2009-06-06 20:42:03 --- Try installing it with winetricks first.
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #2 from Fabian Köster koesterreich@gmx.net 2009-06-07 03:36:13 --- I already installed .Net 2.0 (dotnet20) with winetricks-20090227.
My completee winetricks execution: "winetricks msxml3 jet40 mdac28 dotnet20".
The Lexware-Installer then fails to update it to SP1, as far as I can see that.
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #3 from Fabian Köster koesterreich@gmx.net 2009-06-07 03:37:16 --- Btw: This bug was introduced in wine 1.1.23, it does not happen with the releases before.
http://bugs.winehq.org/show_bug.cgi?id=18811
Fabian Köster koesterreich@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dotnet, Installer
--- Comment #4 from Fabian Köster koesterreich@gmx.net 2009-06-07 03:53:01 --- See also Bug #16956 about Lexware not installing .Net 2.0 SP1 but failing _with an error message_.
This bug is about wine _crashing_ when installing .Net 2.0 SP1.
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #5 from Austin English austinenglish@gmail.com 2009-06-07 13:37:11 --- (In reply to comment #4)
See also Bug #16956 about Lexware not installing .Net 2.0 SP1 but failing _with an error message_.
This bug is about wine _crashing_ when installing .Net 2.0 SP1.
There are plenty of dotnet 2.0 installer bugs...no need to open a new one for every application.
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #6 from Fabian Köster koesterreich@gmx.net 2009-06-07 18:10:32 --- I am sorry, but as far as I can see this bug has not been reported yet - for no application.
Maybe reporting this bug does not help the wine developers much (because they know about existing problems), but as I am not involved into Wine+dotnet development I cannot assess that.
So I am offering my help in solving this issues by providing as much information and testing as possible.
Tell me what to do and I will try to provide more valuable help.
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #7 from Austin English austinenglish@gmail.com 2009-06-07 18:27:45 --- http://appdb.winehq.org/objectManager.php?sClass=version&iId=3754
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #8 from Fabian Köster koesterreich@gmx.net 2009-06-08 05:00:14 --- (In reply to comment #7)
http://appdb.winehq.org/objectManager.php?sClass=version&iId=3754
Yeah, this is the .NET Framework 2.0 AppDB entry. What am I supposed to see there?
None of the bug-reports listed there is about wine crashing.
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #9 from Ken Sharp kennybobs@o2.co.uk 2009-06-08 08:09:17 --- If this is a regression, then you need a regression test. http://wiki.winehq.org/RegressionTesting
http://bugs.winehq.org/show_bug.cgi?id=18811
Fabian Köster koesterreich@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
--- Comment #10 from Fabian Köster koesterreich@gmx.net 2009-06-08 10:20:44 --- Yes, this is a regression. Just tested again with wine 1.1.22 and it does not crash (Although bug #16956 occurs..).
Thanks for giving me instructions what to do for helping.
I am currently doing the regression testing so expect results later today.
http://bugs.winehq.org/show_bug.cgi?id=18811
Fabian Köster koesterreich@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16956
http://bugs.winehq.org/show_bug.cgi?id=18811
Fabian Köster koesterreich@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hib@hiberis.nl
--- Comment #11 from Fabian Köster koesterreich@gmx.net 2009-06-08 14:23:05 --- d9568722aa1c60ae402f18f7a079cb0988dd8c58 is first bad commit commit d9568722aa1c60ae402f18f7a079cb0988dd8c58 Author: Hib Eris hib@hiberis.nl Date: Sun May 24 18:51:58 2009 +0200
msi: Support transforms with binary OBJECTS.
:040000 040000 0843b2732453e265f54c8a52d118aeb9eb39d05a 9fcf49b64bf55349ce6568776904997349a536f0 M dlls
http://bugs.winehq.org/show_bug.cgi?id=18811
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hans@meelstraat.net
--- Comment #12 from Hans Leidekker hans@meelstraat.net 2009-06-08 15:22:00 --- Please attach a WINEDEBUG=+msi,+msidb,+seh,+tid trace.
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #13 from Fabian Köster koesterreich@gmx.net 2009-06-08 16:27:24 --- Bzipped output of "WINEDEBUG=+msi,+msidb,+seh,+tid wine LxSetup.exe"
http://koesterreich.de/wine/lexware/logs/wine-1.1.23_lexware_2009-06-08-23-1...
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #14 from Hans Leidekker hans@meelstraat.net 2009-06-09 02:56:20 --- 002d:warn:msidb:write_stream_data open stream failed r = 80030005 002d:warn:msidb:STREAMS_set_row failed to write stream data: 1627
80030005 is STG_E_ACCESSDENIED
Hib's patches added support for binary streams which the sp1 installer is trying to add via a transform. This fails because we open the package storage (actually a copy of it) read-only.
A naive patch to open the storage read/write makes a bunch of test fail because of sharing violations, so the proper fix is probably to read all of it into memory, like a comment in the source says.
http://bugs.winehq.org/show_bug.cgi?id=18811
Ben Klein shacklein@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |shacklein@gmail.com
--- Comment #15 from Ben Klein shacklein@gmail.com 2009-06-09 21:15:31 --- "Ultimate Spider-Man" also appears to be affected by this bug. I just completed a regression test that indicates d9568722aa1c60ae402f18f7a079cb0988dd8c58 is first bad commit.
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #16 from Ben Klein shacklein@gmail.com 2009-06-09 21:22:12 --- Created an attachment (id=21710) --> (http://bugs.winehq.org/attachment.cgi?id=21710) "Ultimate Spider-Man" installer output from 1.1.23, WINEDEBUG=+msi,+msidb,+seh,+tid
(In reply to comment #15)
"Ultimate Spider-Man" also appears to be affected by this bug. I just completed a regression test that indicates d9568722aa1c60ae402f18f7a079cb0988dd8c58 is first bad commit.
Oops, forgot to mention, the installer terminates with a dialog "1628: Failed to complete installation" and attached output (WINEDEBUG=+msi,+msidb,+seh,+tid). It looks like it doesn't complete unpacking Installshield/MSI. Windows version is set to winxp.
(In reply to comment #13)
Bzipped output of "WINEDEBUG=+msi,+msidb,+seh,+tid wine LxSetup.exe"
http://koesterreich.de/wine/lexware/logs/wine-1.1.23_lexware_2009-06-08-23-1...
Please create an attachment instead of linking to an external website.
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #17 from Hib Eris hib@hiberis.nl 2009-06-10 03:44:55 --- (In reply to comment #16)
Created an attachment (id=21710)
--> (http://bugs.winehq.org/attachment.cgi?id=21710) [details]
"Ultimate Spider-Man" installer output from 1.1.23, WINEDEBUG=+msi,+msidb,+seh,+tid
Did Ultimate Spider-Man install before? If not, this is progression, not regression ;-)
I think Hans analysis from comment 14 is correct in that the failure to set a row comes from missing functionality.
Nonetheless, missing functionality things should not crash wine. I have a small untest patch that might avoid the crash. Ben, could you test this patch please?
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #18 from Hib Eris hib@hiberis.nl 2009-06-10 03:47:17 --- Created an attachment (id=21712) --> (http://bugs.winehq.org/attachment.cgi?id=21712) 0001-Fix-a-crash-when-freeing-memory.patch
This patch is untested and I am not sure it will fix the crash, but it might, so please give it a try.
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #19 from Ben Klein shacklein@gmail.com 2009-06-10 04:19:32 --- (In reply to comment #17)
(In reply to comment #16)
Created an attachment (id=21710)
--> (http://bugs.winehq.org/attachment.cgi?id=21710) [details] [details]
"Ultimate Spider-Man" installer output from 1.1.23, WINEDEBUG=+msi,+msidb,+seh,+tid
Did Ultimate Spider-Man install before? If not, this is progression, not regression ;-)
No, it gets to the end of the installation then fails due to a different bug (I believe it's Wine failing to ask the user for the next disc). In the case of 1.1.23, the installer seems to crashes before Installshield is fully unpacked, so before the installation itself begins.
Nonetheless, missing functionality things should not crash wine. I have a small untest patch that might avoid the crash. Ben, could you test this patch please?
This patch does not change the behaviour. I still get the same installer failure as with 1.1.23 stock.
http://bugs.winehq.org/show_bug.cgi?id=18811
Hib Eris hib@hiberis.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #21712|0 |1 is obsolete| |
--- Comment #20 from Hib Eris hib@hiberis.nl 2009-06-10 04:48:36 --- Created an attachment (id=21713) --> (http://bugs.winehq.org/attachment.cgi?id=21713) 0001-Fix-a-crash-when-freeing-memory-v2.patch
Ben, my apologies for using you as a test machine, but as I cannot reproduce the bug myself, it is a bit difficult to test otherwise.
Maybe this improved patch will work.
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #21 from Ben Klein shacklein@gmail.com 2009-06-10 08:20:34 --- (In reply to comment #20)
Created an attachment (id=21713)
--> (http://bugs.winehq.org/attachment.cgi?id=21713) [details]
0001-Fix-a-crash-when-freeing-memory-v2.patch
Ben, my apologies for using you as a test machine, but as I cannot reproduce the bug myself, it is a bit difficult to test otherwise.
Maybe this improved patch will work.
This patch fixes this particular bug for me. Nice work :)
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #22 from Fabian Köster koesterreich@gmx.net 2009-06-10 08:53:50 ---
Bzipped output of "WINEDEBUG=+msi,+msidb,+seh,+tid wine LxSetup.exe"
http://koesterreich.de/wine/lexware/logs/wine-1.1.23_lexware_2009-06-08-23-1...
Please create an attachment instead of linking to an external website.
I tried to attach the log but it was too big (also with bzip -9) and Bugzilla denied it. The Bugzilla-message suggested to upload it somewhere else and to put the URL into a comment. That is what I did :)
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #23 from Fabian Köster koesterreich@gmx.net 2009-06-10 09:35:00 --- (In reply to comment #20)
Created an attachment (id=21713)
--> (http://bugs.winehq.org/attachment.cgi?id=21713) [details]
0001-Fix-a-crash-when-freeing-memory-v2.patch
Ben, my apologies for using you as a test machine, but as I cannot reproduce the bug myself, it is a bit difficult to test otherwise.
Maybe this improved patch will work.
I can also confirm, that this patches the bug for me (and Lexware). Thanks a lot for your work!
http://bugs.winehq.org/show_bug.cgi?id=18811
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=18811
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #24 from Austin English austinenglish@gmail.com 2009-06-11 11:04:18 --- (In reply to comment #23)
(In reply to comment #20)
Created an attachment (id=21713)
--> (http://bugs.winehq.org/attachment.cgi?id=21713) [details] [details]
0001-Fix-a-crash-when-freeing-memory-v2.patch
Ben, my apologies for using you as a test machine, but as I cannot reproduce the bug myself, it is a bit difficult to test otherwise.
Maybe this improved patch will work.
I can also confirm, that this patches the bug for me (and Lexware). Thanks a lot for your work!
Patch committed (8fb7fdd0295df22b19bc9ee55431ff54521a6ee8).
http://bugs.winehq.org/show_bug.cgi?id=18811
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #25 from Alexandre Julliard julliard@winehq.org 2009-06-19 11:09:12 --- Closing bugs fixed in 1.1.24.
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #26 from Fabian Köster koesterreich@gmx.net 2009-06-22 15:12:10 --- I can confirm that this bug is fixed in wine 1.1.24
http://bugs.winehq.org/show_bug.cgi?id=18811
--- Comment #27 from Ben Klein shacklein@gmail.com 2009-06-22 19:19:16 --- (In reply to comment #26)
I can confirm that this bug is fixed in wine 1.1.24
There's no need for people to post that the bug is FIXED after the patch has been committed to git, especially if it's also fixed in a new release.
If the bug reoccurs, feel free to comment or reopen.
http://bugs.winehq.org/show_bug.cgi?id=18811
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |8fb7fdd0295df22b19bc9ee5543 | |1ff54521a6ee8
http://bugs.winehq.org/show_bug.cgi?id=18811
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh@gmail.com Regression SHA1| |d9568722aa1c60ae402f18f7a07 | |9cb0988dd8c58