https://bugs.winehq.org/show_bug.cgi?id=36216
Bug ID: 36216 Summary: Hearthstone fails to start, says the game timed out Product: Wine Version: 1.7.17 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: adys.wh@gmail.com
(not related to bug 36178)
The game is started from the Battle.net client, gets to the login screen. Then the game says:
Closed Your game timed out as it was requesting data from the Hearthstone utility service. Please relaunch Hearthstone to reconnect.
This error sometimes happened before, but now it's impossible to get into the game. Looking at some wireshark logs, theres a lot of crypted communication on port 1119 between hearthstone and the battle.net agent, then it stops for a few seconds and the game says it timed out.
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #1 from Jerome Leclanche adys.wh@gmail.com --- Created attachment 48348 --> https://bugs.winehq.org/attachment.cgi?id=48348 WINEDEBUG=+winsock,+tid,-uniscribe wine Hearthstone\ Beta\ Launcher.exe
Here is a winsock,tid log. Server killed immediately after timeout. (-uniscribe because of fixme:uniscribe:ScriptShapeOpenType Ranges not supported yet spam)
https://bugs.winehq.org/show_bug.cgi?id=36216
Matteo Bruni matteo.mystral@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd@gmail.com, | |matteo.mystral@gmail.com
--- Comment #2 from Matteo Bruni matteo.mystral@gmail.com --- I ran a regression test and weirdly (for me at least) the culprit seems to be:
commit 2005be6dc92c0943ede01525cecad88f8e83c9c7 Author: Vincent Povirk vincent@codeweavers.com Date: Wed Apr 16 15:50:37 2014 -0500
shell32: Use CREATE_NEW_CONSOLE when SEE_MASK_NOCONSOLE is omitted.
Reverting it on top of wine 1.7.18 fixes the issue here. Jerome, can you confirm? I guess a +tid,+exec,+process trace might shed some light.
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #3 from Jerome Leclanche adys.wh@gmail.com --- Interesting. I will give it a shot in a bit, I really didn't think it'd be a regression.
https://bugs.winehq.org/show_bug.cgi?id=36216
Vincent Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |https://us.battle.net/accou | |nt/download/?show=hearthsto | |ne&style=hearthstone
--- Comment #4 from Vincent Povirk madewokherd@gmail.com --- I haven't had a chance to try reverting the patch, but I can reproduce the bug here.
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #5 from Jerome Leclanche adys.wh@gmail.com --- (In reply to Vincent Povirk from comment #4) I'm currently unable to reproduce the bug, so I can't test reverting it.
https://bugs.winehq.org/show_bug.cgi?id=36216
Vincent Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Regression SHA1| |2005be6dc92c0943ede01525cec | |ad88f8e83c9c7
--- Comment #6 from Vincent Povirk madewokherd@gmail.com --- Reverting the patch helps here as well.
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #7 from Vincent Povirk madewokherd@gmail.com --- I think what's breaking this is the delay in starting Agent.exe (which is a console executable) when we also start wineconsole.exe. Using DETACHED_PROCESS doesn't break it like CREATE_NEW_CONSOLE does, so I don't think it matters what happens to the stdio handles.
https://bugs.winehq.org/show_bug.cgi?id=36216
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |shell32
https://bugs.winehq.org/show_bug.cgi?id=36216
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair@hotmail.com
http://bugs.winehq.org/show_bug.cgi?id=36216
Xinkai yeled.nova@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |yeled.nova@gmail.com
--- Comment #8 from Xinkai yeled.nova@gmail.com --- (In reply to Matteo Bruni from comment #2)
I ran a regression test and weirdly (for me at least) the culprit seems to be:
commit 2005be6dc92c0943ede01525cecad88f8e83c9c7 Author: Vincent Povirk vincent@codeweavers.com Date: Wed Apr 16 15:50:37 2014 -0500
shell32: Use CREATE_NEW_CONSOLE when SEE_MASK_NOCONSOLE is omitted.
Reverting it on top of wine 1.7.18 fixes the issue here. Jerome, can you confirm? I guess a +tid,+exec,+process trace might shed some light.
Thanks, reverting this works for me as well.
http://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #9 from Vincent Povirk madewokherd@gmail.com --- Well, I'm stumped. Agent.exe is started before Hearthstone, so I assume it's not related to startup timing, and I don't know what else it could be.
http://bugs.winehq.org/show_bug.cgi?id=36216
Vijay Kamuju infyquest@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |infyquest@gmail.com
--- Comment #10 from Vijay Kamuju infyquest@gmail.com --- Can you send a patch to fix the spamming of FIXME's in usp10.
http://bugs.winehq.org/show_bug.cgi?id=36216
Ozan Türkyılmaz ozan.turkyilmaz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ozan.turkyilmaz@gmail.com
--- Comment #11 from Ozan Türkyılmaz ozan.turkyilmaz@gmail.com --- I reve(In reply to Matteo Bruni from comment #2)
I ran a regression test and weirdly (for me at least) the culprit seems to be:
commit 2005be6dc92c0943ede01525cecad88f8e83c9c7 Author: Vincent Povirk vincent@codeweavers.com Date: Wed Apr 16 15:50:37 2014 -0500
shell32: Use CREATE_NEW_CONSOLE when SEE_MASK_NOCONSOLE is omitted.
Reverting it on top of wine 1.7.18 fixes the issue here. Jerome, can you confirm? I guess a +tid,+exec,+process trace might shed some light.
I reverted and game connected just fine.
https://bugs.winehq.org/show_bug.cgi?id=36216
Tony Murray murraytony@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |murraytony@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=36216
gonzo hplgonzo@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hplgonzo@gmx.net
http://bugs.winehq.org/show_bug.cgi?id=36216
nE0sIghT update.microsoft@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |update.microsoft@mail.ru
http://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #12 from nE0sIghT update.microsoft@mail.ru --- I confirm that reverting patch works well
http://bugs.winehq.org/show_bug.cgi?id=36216
rmlipman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rmlipman@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=36216
lubosz lubosz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lubosz@gmail.com
--- Comment #13 from lubosz lubosz@gmail.com --- I can confirm that the said patch causes a regression for Hearthstone. Reverting it makes Hearthstone playable again.
Please revert it for the next release.
Related battle.net forums post: http://us.battle.net/hearthstone/en/forum/topic/12673258426
http://bugs.winehq.org/show_bug.cgi?id=36216
Chris_9 jukeller@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jukeller@gmx.de
http://bugs.winehq.org/show_bug.cgi?id=36216
Peter forreg@rinaldus.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |forreg@rinaldus.ru
--- Comment #14 from Peter forreg@rinaldus.ru --- (In reply to Ozan Türkyılmaz from comment #11)
I reve(In reply to Matteo Bruni from comment #2)
I ran a regression test and weirdly (for me at least) the culprit seems to be:
commit 2005be6dc92c0943ede01525cecad88f8e83c9c7 Author: Vincent Povirk vincent@codeweavers.com Date: Wed Apr 16 15:50:37 2014 -0500
shell32: Use CREATE_NEW_CONSOLE when SEE_MASK_NOCONSOLE is omitted.
Reverting it on top of wine 1.7.18 fixes the issue here. Jerome, can you confirm? I guess a +tid,+exec,+process trace might shed some light.
I reverted and game connected just fine.
I didn't understand is this command or what? Where should I type it?
http://bugs.winehq.org/show_bug.cgi?id=36216
Agustín Atahides dorklotus@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dorklotus@outlook.com
--- Comment #15 from Agustín Atahides dorklotus@outlook.com --- (In reply to lubosz from comment #13)
I can confirm that the said patch causes a regression for Hearthstone. Reverting it makes Hearthstone playable again.
Please revert it for the next release.
Related battle.net forums post: http://us.battle.net/hearthstone/en/forum/topic/12673258426
Sadly they didn't fix it, the problem is still present on wine 1.7.19, I hope they get it fixed for the next release...
http://bugs.winehq.org/show_bug.cgi?id=36216
Johannes Dewender wine@JonnyJD.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wine@JonnyJD.net
https://bugs.winehq.org/show_bug.cgi?id=36216
Ker noa blue-t@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |blue-t@web.de
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #16 from Ker noa blue-t@web.de --- Created attachment 48573 --> https://bugs.winehq.org/attachment.cgi?id=48573 1.7.19 trace of Hearthstone.exe
http://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #17 from Johannes Dewender wine@JonnyJD.net --- Created attachment 48575 --> http://bugs.winehq.org/attachment.cgi?id=48575 patch reverting commit 2005be6dc92c0943ede01525cecad88f8e83c9c7
I can confirm the problem and the fix for current git (704d169; 1.7.19 + 47 commits).
Without the patch I get that error message starting hearthstone (from battle.net app, login there works). Applying the patch (reverting commit 2005be6) lets me play hearthstone fine again. (played a full match)
I attach the patch that can be applied to revert the "offending" commit. (For people not having/using a git checkout)
http://bugs.winehq.org/show_bug.cgi?id=36216
Kyle kyleki@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kyleki@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=36216
Meghan Pietila pietila.meghan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pietila.meghan@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=36216
Kirill dhampik@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dhampik@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=36216
a.metaphysical.drama@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |a.metaphysical.drama@gmail. | |com
https://bugs.winehq.org/show_bug.cgi?id=36216
maxpotter0@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |maxpotter0@gmail.com
--- Comment #18 from maxpotter0@gmail.com --- (In reply to Johannes Dewender from comment #17)
Created attachment 48575 [details] patch reverting commit 2005be6dc92c0943ede01525cecad88f8e83c9c7
I can confirm the problem and the fix for current git (704d169; 1.7.19 + 47 commits).
Without the patch I get that error message starting hearthstone (from battle.net app, login there works). Applying the patch (reverting commit 2005be6) lets me play hearthstone fine again. (played a full match)
I attach the patch that can be applied to revert the "offending" commit. (For people not having/using a git checkout)
How do I download and apply this patch? I've never had to do this before. Thanks for making the patch.
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #19 from Johannes Dewender wine@JonnyJD.net --- Well, this is a bit out of scope for this ticket, but you need to build wine from source like explained a bit here: https://www.winehq.org/docs/wineusr-guide/installing-wine-source Depending on your Linux distribution there might be prepared source packages you can build (but that is really out of scope, you better ask in help channels for your distribution). If you are using Ubuntu, there is a dedicated wiki page for that: http://wiki.winehq.org/Ubuntu
Anyways, before you run "make" you do "patch -p1 < shlexec.patch". Please use other help channels (like for your distribution) if you need more assistance with that. There are 21 CCs for this bug and most probably don't want a dozen messages on how to patch and build wine in one specific distribution.
https://bugs.winehq.org/show_bug.cgi?id=36216
Jarrod Meyer jarrodmeyer+winehq@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jarrodmeyer+winehq@gmail.co | |m
--- Comment #20 from Jarrod Meyer jarrodmeyer+winehq@gmail.com --- Johannes Dewender wrote:
I can confirm the problem and the fix for current git (704d169; 1.7.19 + 47 commits).
I've installed wine-1.7.20 in fedora 20 from the updates-testing repo, and I can confirm I am still seeing the problem.
Is this not supposed to be fixed before 1.7.20? Maybe I'm missing something.
http://bugs.winehq.org/show_bug.cgi?id=36216
Ryan Davis iconoclasmandheresy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |iconoclasmandheresy@gmail.c | |om
--- Comment #21 from Ryan Davis iconoclasmandheresy@gmail.com --- Confirm, still present in 1.7.20 packages from Ubuntu 14.04 PPA. I havn't had a chance to set up a proper build environment yet so testing the reversion patch isn't simple for me.
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #22 from Jerome Leclanche adys.wh@gmail.com --- Guys, you don't need to confirm this. The bug is known, the cause is known and reverting 2005be6dc92c0943ede01525cecad88f8e83c9c7 fixes it.
A proper fix is needed to land upstream as it doesn't look like the patch will be reverted (something which could be argued but probably not worth doing so).
If you don't know how git works or how to compile Wine, then please, just stick to Wine 1.7.16 and you won't have this issue.
http://bugs.winehq.org/show_bug.cgi?id=36216
joe@nahmias.net joe@nahmias.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |joe@nahmias.net
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #23 from Jarrod Meyer jarrodmeyer+winehq@gmail.com --- Jerome Leclanche wrote:
Guys, you don't need to confirm this. The bug is known, the cause is known and reverting 2005be6dc92c0943ede01525cecad88f8e83c9c7 fixes it.
Sorry, I thought the comment about it being fixed meant 1.7.20 was unaffected, so I wanted to share the info.
http://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #24 from gonzo hplgonzo@gmx.net --- I can confirm, that building the latest git-version of wine (in my case 1.7.20.r158.g8762842-1) and including your patch works fine. Thank you Johannes Dewender and all the other guys, who keep track of that meanwhile more or less "solved problem".
http://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #25 from Ryan Davis iconoclasmandheresy@gmail.com --- I'm sure it does work with the patch. Reverting the regression doesn't really solve the problem since the regression was introduced by some code designed to fix a different problem. So... what we have are two different source programs, each of which has different problems. The folks working on the code are (we are told) trying to come up with something that includes the new feature and lacks the bug. That patch will then be included in a future mainline release. At that point the problem will be solved.
We do have a workaround providing you are willing/able to build from source.
http://bugs.winehq.org/show_bug.cgi?id=36216
yarglesnargle7@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |yarglesnargle7@gmail.com
--- Comment #26 from yarglesnargle7@gmail.com --- Created attachment 48972 --> http://bugs.winehq.org/attachment.cgi?id=48972 revert commit shell32
http://bugs.winehq.org/show_bug.cgi?id=36216
mathieu@rochette.cc changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu@rochette.cc
http://bugs.winehq.org/show_bug.cgi?id=36216
sveinelo sveinelo@getmail.no changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sveinelo@getmail.no
http://bugs.winehq.org/show_bug.cgi?id=36216
sveinelo sveinelo@getmail.no changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|sveinelo@getmail.no |
http://bugs.winehq.org/show_bug.cgi?id=36216
sveinelo erik.lovland@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |erik.lovland@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #27 from Kyle kyleki@gmail.com --- FWIW, the latest wine update for Fedora 20 (1.7.22-1) is still broken.
http://bugs.winehq.org/show_bug.cgi?id=36216
babist1st@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |babist1st@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=36216
paulemile.purnelle@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |paulemile.purnelle@gmail.co | |m
http://bugs.winehq.org/show_bug.cgi?id=36216
paulemile.purnelle@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|paulemile.purnelle@gmail.co | |m |
http://bugs.winehq.org/show_bug.cgi?id=36216
paulemile.purnelle@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |paulemile.purnelle@gmail.co | |m
http://bugs.winehq.org/show_bug.cgi?id=36216
Andreas Källberg anka.213.bacn@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |anka.213.bacn@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=36216
Erich Hoover erich.e.hoover@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |erich.e.hoover@gmail.com
--- Comment #28 from Erich Hoover erich.e.hoover@gmail.com --- Could someone provide a WINEDEBUG="+exec" log? It'd be interesting to see what kind of SHELLEXECUTEINFO the application is passing.
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #29 from Ker noa blue-t@web.de --- Created attachment 49282 --> https://bugs.winehq.org/attachment.cgi?id=49282 winedebug log with +exec
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #30 from Ker noa blue-t@web.de --- Created attachment 49283 --> https://bugs.winehq.org/attachment.cgi?id=49283 winedebug log with +exec when started from the launcher
there you go, debug log with +exec trace , game was started from the launcher. and on the other attachment run directly from the gamedir with wine
http://bugs.winehq.org/show_bug.cgi?id=36216
ghallberg@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ghallberg@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=36216
lingepumpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lingepumpe@gmail.com
--- Comment #31 from lingepumpe@gmail.com --- Any information on a proper fix that will be added to wine? Situation is rather sad with this forced downgrade or manual wine compilation...
https://bugs.winehq.org/show_bug.cgi?id=36216
willismonroe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |willismonroe@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=36216
cirilloblu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cirilloblu@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=36216
czesiekbis@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |czesiekbis@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=36216
Cyril Roelandt tipecaml@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tipecaml@gmail.com
--- Comment #32 from Cyril Roelandt tipecaml@gmail.com --- I can also confirm that reverting the specified commit fixes the issue.
https://bugs.winehq.org/show_bug.cgi?id=36216
Ing. Jan Kaláb pitlicek@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pitlicek@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=36216
Stephen Mollett molletts@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |molletts@yahoo.com
https://bugs.winehq.org/show_bug.cgi?id=36216
noryb009@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |noryb009@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #33 from Meghan Pietila pietila.meghan@gmail.com --- With wine 1.7.30, the attached patch fails with "Aborting due to unexpected upstream changes". I don't have the knowledge to create a patch file myself, is there anyone out there who can attach a patch that works with the more recent wine? (Hearthstone still fails to connect with 1.7.30.)
https://bugs.winehq.org/show_bug.cgi?id=36216
roger@mailinator.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |roger@mailinator.com
--- Comment #34 from roger@mailinator.com --- What's the cause of this problem? Is it upstream (the game) issue, or something to be fixed in wine?
https://bugs.winehq.org/show_bug.cgi?id=36216
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian@fds-team.de
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #35 from Ryan Davis iconoclasmandheresy@gmail.com --- There is, I have gathered, a timing or order of operations issue. It is in WINE to the extent that some difference of the behavior under native Windows exposes an assumption made by the Hearthstone software that other programs do not make. It may be a case of Blizzard using undocumented behavior or exploiting documented behavior in a way that is atypical. The fact that the patch fails to apply indicates someone has done some work in the neighborhood and that a solution is perhaps forthcoming.
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #36 from a.metaphysical.drama@gmail.com --- Patching works fine for me, i'm using the patch from the comment 26: https://bugs.winehq.org/attachment.cgi?id=48972&action=diff&context=...
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #37 from Meghan Pietila pietila.meghan@gmail.com --- (In reply to Meghan Pietila from comment #33)
With wine 1.7.30, the attached patch fails with "Aborting due to unexpected upstream changes". I don't have the knowledge to create a patch file myself, is there anyone out there who can attach a patch that works with the more recent wine? (Hearthstone still fails to connect with 1.7.30.)
Tried patching again using the git sources instead of the winehq repository sources and ran successfully; was able to launch and run Battle.net and Hearthstone with no issues on Oct 10. (New problem appeared on Oct 11, but out of scope of this ticket.)
Followed these directions, in case this helps any other users: http://wiki.winehq.org/Patching
https://bugs.winehq.org/show_bug.cgi?id=36216
Jo-Herman Haugholt johannes@huyderman.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |johannes@huyderman.com
https://bugs.winehq.org/show_bug.cgi?id=36216
Michael Müller michael@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |michael@fds-team.de
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #38 from Ker noa blue-t@web.de --- https://github.com/wine-compholio/wine-staging/blob/ad5dcc97522c2087727075ec...
seems to be the better approach to fix this.
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #39 from Sebastian Lackner sebastian@fds-team.de --- (In reply to Ker noa from comment #38)
https://github.com/wine-compholio/wine-staging/blob/ ad5dcc97522c2087727075ecfb323de1567486a6/patches/kernel32-Console_Handles/ 0001-kernel32-Invalid-console-handles-for-new-processes-a.patch
seems to be the better approach to fix this.
The patch was added just recently and still needs a bit more testing and probably also some more wine tests. But please give it a try and report back if it works. Especially report if you notice that any app breaks with the patch applied.
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #40 from Johannes Dewender wine@JonnyJD.net --- (In reply to Ker noa from comment #38)
https://github.com/wine-compholio/wine-staging/blob/ ad5dcc97522c2087727075ecfb323de1567486a6/patches/kernel32-Console_Handles/ 0001-kernel32-Invalid-console-handles-for-new-processes-a.patch
I rebuilt my wine from current git (1.7.34.r74.gcf92569). With vanilla wine the error message changed since my last report. I don't get the "timed out" message anymore, but after starting Hearthstone from the launcher I get the same message already mentioned in the Hearthstone comments: The game crashed. The crash report folder named "2014-12-28_131400" next to game executable. (well, with the date of today obviously and another pid/time or what that is)
With (only) the above mentioned patch added everything works fine. I can start Hearthstone and played a game till the end. Diablo 3 also doesn't break with the patch. Didn't try other programs.
So the patch seems to work fine.
PS: I previously used an older wine build with the patch reverting 2005be6dc92. I don't know when the error message changed, but I do guess this is because Hearthstone itself changed.
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #41 from lubosz lubosz@gmail.com --- I can confirm that "kernel32: Invalid console handles for new processes are 0, not INVALID_HANDLE_VALUE." fixes the timeout issue.
I hope that this will get merged soon and Hearthstone gains upstream Wine support after 9 months again.
https://bugs.winehq.org/show_bug.cgi?id=36216
Saulius K. saulius2@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |saulius2@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=36216
Johannes Dewender wine@JonnyJD.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #48575|0 |1 is obsolete| |
--- Comment #42 from Johannes Dewender wine@JonnyJD.net --- Created attachment 50881 --> https://bugs.winehq.org/attachment.cgi?id=50881 patch taken from wine-staging/compholio by Erich E. Hoover
I added the best currently known patch to the attachments to make finding it easier. I obsoleted the patch that only reverted 2005be6dc92, since that commit was made to fix other things.
What is the current status? Was the patch submitted? It is not applied in wine (git) and I also can't find it in https://source.winehq.org/patches/
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #43 from Johannes Dewender wine@JonnyJD.net --- The patch was sent to wine, but there was no reaction. Possibly because it isn't/wasn't known that this fixes a bug: https://www.winehq.org/pipermail/wine-patches/2015-January/136652.html
I got the info from https://github.com/wine-compholio/wine-staging/commit/ad5dcc97522c2087727075... (where the patch was added to wine-staging)
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #44 from Sebastian Lackner sebastian@fds-team.de --- (In reply to Johannes Dewender from comment #43)
Possibly because it isn't/wasn't known that this fixes a bug:
"""Several applications rely on the TEB value for fresh invalid console handles to be zero instead of INVALID_HANDLE_VALUE (fixes Bug #36216 and Bug #37914)."""
What was unclear about that? ;) Erich E. Hoover is planning to resubmit the patch soon, they only stay in the patches list for about one month.
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #45 from Erich E. Hoover erich.e.hoover@wine-staging.com --- (In reply to Sebastian Lackner from comment #44)
... What was unclear about that? ;) Erich E. Hoover is planning to resubmit the patch soon, they only stay in the patches list for about one month.
Yeah, it only just dropped off the list (allowing me to resend it). I'm going to resend it along with a couple other small patches as soon as I can.
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #46 from Jerome Leclanche adys.wh@gmail.com --- (In reply to Erich E. Hoover from comment #45) Any update Erich?
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #47 from Erich E. Hoover erich.e.hoover@wine-staging.com --- (In reply to Jerome Leclanche from comment #46)
(In reply to Erich E. Hoover from comment #45) Any update Erich?
Yup, made some fixes for some 64-bit warnings in the tests. I was planning on submitting Friday but some things came up, I'll likely get to submitting it and a couple other patches today or tomorrow.
https://bugs.winehq.org/show_bug.cgi?id=36216
Frédéric Delanoy frederic.delanoy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |frederic.delanoy@gmail.com Resolution|--- |FIXED
--- Comment #48 from Frédéric Delanoy frederic.delanoy@gmail.com --- Works in wine 1.7.40
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #49 from Sebastian Lackner sebastian@fds-team.de --- (In reply to Frédéric Delanoy from comment #48)
Works in wine 1.7.40
Are you sure that its fixed? The patch by Erich was not accepted yet, so it must be related to an update of the game itself (or you are using a distro which ships Wine-Staging by default, but then you shouldn't use it for bug reporting).
https://bugs.winehq.org/show_bug.cgi?id=36216
Frédéric Delanoy frederic.delanoy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |---
--- Comment #50 from Frédéric Delanoy frederic.delanoy@gmail.com --- (In reply to Sebastian Lackner from comment #49)
(In reply to Frédéric Delanoy from comment #48)
Works in wine 1.7.40
Are you sure that its fixed? The patch by Erich was not accepted yet, so it must be related to an update of the game itself (or you are using a distro which ships Wine-Staging by default, but then you shouldn't use it for bug reporting).
I used plain compiled wine to test. I retested using 2005be6dc92c0943ede01525cecad88f8e83c9c7^ and 2005be6dc92c0943ede01525cecad88f8e83c9c7 and couldn't reproduce the original issue either.
The bug probably doesn't trigger anymore due to game update itself. I'll reopen, and hopefully Jerome can retry himself.
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #51 from Jerome Leclanche adys.wh@gmail.com --- I'm using a patched wine version to play the game. But there was a major game update a couple of days ago, it's likely it was fixed by that.
I'd say keep the bug open until the patch lands.
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #52 from Frédéric Delanoy frederic.delanoy@gmail.com --- (In reply to Jerome Leclanche from comment #51)
I'm using a patched wine version to play the game. But there was a major game update a couple of days ago, it's likely it was fixed by that.
I'd say keep the bug open until the patch lands.
Problem is, you can't test whether the proposed patch fixes the bug (since *this* bug doesn't appear anymore due to changes in the Hearthstone), so you wouldn't also be able to test later for regression testing.
It would probably be better to close this bug, and create a new bug report with a simpler app showing the issue, so we can test if the proposed fix works.
Erich E. Hoover would probably be most "appropriate" for this since he found the fix and wrote a patch.
https://bugs.winehq.org/show_bug.cgi?id=36216
ghallberg@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|ghallberg@gmail.com |
https://bugs.winehq.org/show_bug.cgi?id=36216
--- Comment #53 from Erich E. Hoover erich.e.hoover@wine-staging.com --- (In reply to Frédéric Delanoy from comment #52)
... It would probably be better to close this bug, and create a new bug report with a simpler app showing the issue, so we can test if the proposed fix works.
Erich E. Hoover would probably be most "appropriate" for this since he found the fix and wrote a patch.
I'm fine with it either way, since we have no idea what other programs are affected it's really a matter of testing. I do have some tests attached to the patch that demonstrate the behavior, I'll double check things and try to get the patches submitted during my lunch break today. I've just been way to busy lately to devote any time to Wine :/
https://bugs.winehq.org/show_bug.cgi?id=36216
Tony Murray murraytony@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|murraytony@gmail.com |
https://bugs.winehq.org/show_bug.cgi?id=36216
Erich E. Hoover erich.e.hoover@wine-staging.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |4b559f02dd6ad61287fb79547c9 | |3105aaa2f7525 Status|REOPENED |RESOLVED Resolution|--- |FIXED
--- Comment #54 from Erich E. Hoover erich.e.hoover@wine-staging.com --- Should this affect any other apps, the problem is now fixed by commit 4b559f02dd6ad61287fb79547c93105aaa2f7525.
https://bugs.winehq.org/show_bug.cgi?id=36216
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #55 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.42.