[Bug 28180] New: Operation Flashpoint crashes with sound enabled

http://bugs.winehq.org/show_bug.cgi?id=28180

Summary: Operation Flashpoint crashes with sound enabled
           Product: Wine
           Version: 1.3.26
          Platform: x86
               URL: http://www.gamefront.com/files/839372/resistancedemo.z
                    ip
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-dsound
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
   Regression SHA1: 6b64e0090cb7b331dd212f0b8aba5595f013caf1

Created an attachment (id=36104)
 --> (http://bugs.winehq.org/attachment.cgi?id=36104)
terminal output

In the current git version (wine-1.3.26-312-g3ce59f5) Operation Flashpoint:Cold
War Crisis crashes if sound is enabled in winecfg's Audio tab.

The problem can be reproduced in the demo, too. Unlike the full version of the
game, the demo dies as soon as the main menu appears. The full version of the
game (v1.96) works fine in the menus but it crashes when a mission is about to
start.

This is due to the following commit:

6b64e0090cb7b331dd212f0b8aba5595f013caf1 is the first bad commit
commit 6b64e0090cb7b331dd212f0b8aba5595f013caf1
Author: Michael Stefaniuc 
Date:   Wed Aug 24 02:32:13 2011 +0200

dsound: Kill SecondaryBufferImpl with extreme prejudice.

:040000 040000 632e7bce9c2f253b7ee1f7a2670c0b782c2b4409
80dd9d214e20ad69922e39a13702fde1098a46e2 M    dlls

With the reverted patch both the demo and the full version of the game work
correctly.

Fedora 15 x86
Kernel 2.6.38.8
Alsa 1.0.24
Pulseaudio is not running
I have only Alsa available, OSSv4 is not installed on my system

[Bug 28180] Operation Flashpoint crashes with sound enabled

http://bugs.winehq.org/show_bug.cgi?id=28180

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

--- Comment #1 from GyB  2011-08-25 13:28:34 CDT ---
Added some keywords.

[Bug 28180] Operation Flashpoint crashes with sound enabled

http://bugs.winehq.org/show_bug.cgi?id=28180

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #2 from Michael Stefaniuc  2011-08-25 14:55:59 CDT ---
This doesn't make me wonder at all. The COM implementation and refcount
handling is such a mess in dsound. I have found the issue and it will be
properly fixed once the COM cleanup is done for the IDirectSoundBuffer class
for the secondary buffer.

[Bug 28180] Operation Flashpoint crashes with sound enabled

http://bugs.winehq.org/show_bug.cgi?id=28180

--- Comment #3 from Michael Stefaniuc  2011-08-25 14:57:43 CDT ---
Created an attachment (id=36105)
 --> (http://bugs.winehq.org/attachment.cgi?id=36105)
Ugly refcount hack to fix the crash

[Bug 28180] Operation Flashpoint crashes with sound enabled

http://bugs.winehq.org/show_bug.cgi?id=28180

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
         AssignedTo|[e-mail]        |[e-mail]

--- Comment #4 from Michael Stefaniuc  2011-08-25 16:47:14 CDT ---
I have submitted a less hackish patch that fixes the ref counting issue and
that should be acceptable solution for 1.3.27:
http://source.winehq.org/patches/data/77986

[Bug 28180] Operation Flashpoint crashes with sound enabled

http://bugs.winehq.org/show_bug.cgi?id=28180

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Michael Stefaniuc  2011-08-26 10:53:08 CDT ---
Patch got commited:
http://source.winehq.org/git/wine.git/?a=commit;h=6d7c38256f258dcb71d73e5739...

[Bug 28180] Operation Flashpoint crashes with sound enabled

http://bugs.winehq.org/show_bug.cgi?id=28180

--- Comment #6 from GyB  2011-08-26 11:35:37 CDT ---
Thank you for fixing this problem so quickly! 
Morrowind and Oblivion were also affected by this bug and now they're all
working correctly in wine-1.3.26-360-g187de17.

[Bug 28180] Operation Flashpoint crashes with sound enabled

http://bugs.winehq.org/show_bug.cgi?id=28180

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  2011-08-26 13:23:39 CDT ---
Closing bugs fixed in 1.3.27.

[Bug 28180] Operation Flashpoint crashes with sound enabled

http://bugs.winehq.org/show_bug.cgi?id=28180

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |6d7c38256f258dcb71d73e57395
                   |                            |4c00b77b40202