[Bug 33718] New: comctl32:propsheet Add button test failure

http://bugs.winehq.org/show_bug.cgi?id=33718

Bug #: 33718
           Summary: comctl32:propsheet Add button test failure
           Product: Wine
           Version: 1.5.19
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

A number of VMs report this random test failure:

propsheet.c:543: Test failed: The Add button has not been pressed!

While it is random this test failure is frequent enough to cause significant
pollution of the test results. It  has been seen on the following systems:

comctl32 5.82.2900.2180 Windows XP SP2 + IE7
comctl32 5.82.2900.6028 Windows XP SP3 + IE8
comctl32 5.82.3790.3959 Windows 2003 Enterprise Server SP2 + IE8 
comctl32 5.82.6002.18305 Windows Vista Home Premium SP2 + IE9
comctl32 5.82.7601.17514 Windows 7 Ultimate SP1 64-bit + IE9 (32-bit tests)
comctl32 5.82.9200.16384 Windows 8

[Bug 33718] comctl32:propsheet Add button test failure

http://bugs.winehq.org/show_bug.cgi?id=33718

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source

[Bug 33718] comctl32:propsheet Add button test failure

http://bugs.winehq.org/show_bug.cgi?id=33718

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         OS/Version|Linux                       |Windows

[Bug 33718] comctl32:propsheet Add button test failure

http://bugs.winehq.org/show_bug.cgi?id=33718

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, testcase

[Bug 33718] comctl32:propsheet Add button test failure

https://bugs.winehq.org/show_bug.cgi?id=33718

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                URL|                            |http://test.winehq.org/data
                   |                            |/tests/comctl32:propsheet.h
                   |                            |tml
    Regression SHA1|                            |32f240bfc13edaf81f772aa7f37
                   |                            |8681e3dbfe696

--- Comment #1 from François Gouget  ---
This is a random error: it does not happen in every run but given a few tries
it will happen. Some of the impacted systems are fg-winxp, fg-win2003es,
fg-win7u (all variants) as well as my Acer laptop. See:

http://test.winehq.org/data/tests/comctl32:propsheet.html

The commit that introduced this test is:

commit 32f240bfc13edaf81f772aa7f378681e3dbfe696
Author: Alex Balut 
Date:   Sat May 29 23:12:06 2010 +0200

comctl32/tests: Added a test that checks whether setting a custom default
button in a property sheet works.

[Bug 33718] comctl32:propsheet Add button test failure

https://bugs.winehq.org/show_bug.cgi?id=33718

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |dd856be316f7aac99bd70400e6d
                   |                            |5b927177d1343
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from François Gouget  ---
This failure is no longer happening. I think it was fixed by this commit:

commit dd856be316f7aac99bd70400e6d5b927177d1343
Author: Huw Davies 
Date:   Fri Oct 31 11:55:18 2014 +0000

comctl32/tests: Post a key-down message rather than use keybd_event.

[Bug 33718] comctl32:propsheet Add button test failure

https://bugs.winehq.org/show_bug.cgi?id=33718

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 1.8-rc1.