[Bug 26841] New: Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

Summary: Reaper: File extensions not saved with project file
           Product: Wine
           Version: 1.3.18
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

When trying to save a project in Reaper the resulting file appears without the
file extension, and cannot be read back by Reaper.

If the .rpp file extension is then manually added it can be read as normal.

This regression seems to have been introduced in 1.3.17 and is still present in
1.3.18.

Tested with both stable Reaper 3.75

http://www.cockos.com/reaper/download.php

and Reaper 4 alpha 65b

http://www.landoleet.org/

Elementary OS Jupiter
Intel core2duo
GeForce 9300M GS
Wine 1.3.17/1.3.18

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

Michael Todd  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

Michael Todd  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

--- Comment #1 from Dmitry Timoshkov  2011-04-19 10:03:43 CDT ---
Please post the results of your regression testing:
http://wiki.winehq.org/RegressionTesting

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

--- Comment #2 from [e-mail] 2011-04-20 11:14:18 CDT ---
Created an attachment (id=34242)
 --> (http://bugs.winehq.org/attachment.cgi?id=34242)
The save project dialog as it should look

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

--- Comment #3 from [e-mail] 2011-04-20 11:15:17 CDT ---
Created an attachment (id=34243)
 --> (http://bugs.winehq.org/attachment.cgi?id=34243)
The save dialog as it appeared in Wine 1.3.17

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

--- Comment #4 from [e-mail] 2011-04-20 11:16:31 CDT ---
I can confirm this on 1.3.17 and now 1.3.18 in Mageia. There's actually more to
it. "The Save Project As" dialog is completely different now (including not
saving the file extension unless you type it). The file dialog no longer
contains tick boxes for certain options. It also doesn't remember the file
path, either. In 1.3.17, the "Save" dialog actually said "Open" in the title
bar. In 1.3.18 it now says "Save", but the other problems persist. I have
attached a capture of what the normal save dialog looked like prior to 1.3.17,
as well as a capture of the same in 1.3.17.

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from [e-mail] 2011-04-21 01:28:31 CDT ---
Another REAPER with Wine has posted about this bug in the REAPER forums,
including some terminal output after they opened the "save project" dialog:

fixme:commdlg:IFileDialog2_fnQueryInterface Unknown interface requested:
{e6fdd21a-163f-4975-9c8c-a69f1ba37034}.
fixme:commdlg:IFileDialog2_fnSetDefaultExtension stub - 0x19fb78 (L"rpp")
fixme:commdlg:IServiceProvider_fnQueryService Interface
{e07010ec-bc17-44c0-97b0-46c7c95b9edc} requested from unknown service
{e07010ec-bc17-44c0-97b0-46c7c95b9edc}
fixme:shell:ViewModeToListStyle ViewMode 0 not implemented
fixme:shell:IShellBrowser_fnSendControlMsg stub, 0x1a1950 (2, 1026, a003, 0,
0x331a44)
fixme:shell:IShellBrowser_fnSendControlMsg stub, 0x1a1950 (2, 1026, a004, 0,
0x331a44)
fixme:shell:IShellBrowser_fnSendControlMsg stub, 0x1a1950 (2, 1025, a003, 1,
0x331a44)
fixme:shell:IShellBrowser_fnSendControlMsg stub, 0x1a1950 (2, 1025, a004, 1,
0x331a44)
fixme:nstc:NSTC2_fnSetControlStyle2 mask & style (0x00000004) contains
unsupported style(s): 0x00000004

The thread is at:

http://forum.cockos.com/showthread.php?p=726827#post726827

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from [e-mail] 2011-05-19 03:55:09 CDT ---
I have not noticed this bug before, but just noticed it when creating a new
prefix.  Am on 1.3.20 and my old wineprefix run reaper40beta6 fine and shows
the old dialog and saves the rpp extension.  Maybe a workaround is to create
the prefix in an older version of wine and then upgrade to the latest?

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

--- Comment #7 from [e-mail] 2011-05-24 01:35:25 CDT ---
This regression is due to a change in comdlg32.dll.so that happened between
1.3.16 and 1.3.17. Overwriting /usr/lib/wine/comdlg32.dll.so in an install of
wine 1.3.20 with the comdlg32.dll.so from a 1.3.16 install fixes these file
dialog issues. The announcement for 1.3.17 mentions the addition of Vista file
dialogs and shows quite a bit of work done on comdlg32 by David Hedberg. Seems
it has thrown off whatever method Reaper uses to make its file dialogs.

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

David Hedberg  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from David Hedberg  2011-05-24 02:02:28 CDT ---
It seems to be using the new Vista+ filedialog if it finds it, which happens to
be what I implemented. Executing "wine regsvr32 /u comdlg32.dll" will disable
them and should work as a workaround for the time being. (Reenable them by
changing /u to /i).

Regarding the missing tick boxes, the new file dialogs on wine does not yet
implement the customization interfaces, but I have done some work on that. I'll
see if I can get it committed too.

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

--- Comment #9 from [e-mail] 2011-05-24 03:58:34 CDT ---
Thank you, David. I will try that workaround when I get a chance.

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

--- Comment #10 from Michael Todd  2011-05-24 04:55:58 CDT ---
Workaround seems to fully restore functionality, thanks :)

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

--- Comment #11 from David Hedberg  2011-05-27 16:27:16 CDT ---
The file extension handling in the new dialogs has been improved in wine
1.3.21, which should take care of this bug.

The custom controls (checkboxes etc.) added to the dialogs by reaper should
also show up now and basically be usable, with some small glitches remaining.

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

--- Comment #12 from [e-mail] 2011-05-28 04:48:05 CDT ---
Just installed 1.3.21 and cursory testing appears to confirm that both aspects
of the bug, the missing checkboxes and the missing extension are fixed.

Will install reaper in a new prefix (was my plan anyways) and let you know
after really working with it for a while.

Many thanks for the prompt response David!

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

--- Comment #13 from [e-mail] 2011-06-21 01:56:27 CDT ---
I think you can close this bug now.  Everything appears to work fine, and no
one else has had any comment, either positive nor negative.

And many thanks David for your prompt reaction!

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

--- Comment #14 from [e-mail] 2011-07-18 08:16:54 CDT ---
Well since no one seems interested in closing this bug, I'm closing my browser
at the very least...:(

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #15 from Wylda  2011-07-18 08:58:31 CDT ---

Reported fixed per comment #11 and comment #12.

[Bug 26841] Reaper: File extensions not saved with project file

http://bugs.winehq.org/show_bug.cgi?id=26841

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Alexandre Julliard  2011-07-22 12:44:47 CDT ---
Closing bugs fixed in 1.3.25.