[Bug 41025] New: Worms 2 in-game audio no longer works

https://bugs.winehq.org/show_bug.cgi?id=41025

Bug ID: 41025
           Summary: Worms 2 in-game audio no longer works
           Product: Wine
           Version: 1.9.11
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Debian

After testing bug 41002 I noticed that Worms 2 does no longer have in-game
audio. By using PoL versions of Wine (quicker than regression testing for me) I
was able to identify that it stopped working after 1.9.10. Compiling wine (even
with ccache) takes a long time here so if anyone could help pinpoint a specific
dll/commits it would make my life easier. I will attach a log in wine-git and
1.9.10.

[Bug 41025] Worms 2 in-game audio no longer works

https://bugs.winehq.org/show_bug.cgi?id=41025

--- Comment #1 from Bruno Jesus  ---
Created attachment 55191
  --> https://bugs.winehq.org/attachment.cgi?id=55191
wine 1.9.10 audio working log (22mb decompressed)

[Bug 41025] Worms 2 in-game audio no longer works

https://bugs.winehq.org/show_bug.cgi?id=41025

--- Comment #2 from Bruno Jesus  ---
Created attachment 55192
  --> https://bugs.winehq.org/attachment.cgi?id=55192
wine 1.9.15 audo not working (33mb decompressed)

[Bug 41025] Worms 2 in-game audio no longer works

https://bugs.winehq.org/show_bug.cgi?id=41025

--- Comment #3 from Bruno Jesus  ---
Last but not least, winetricks -q dsound fixes the issue.

[Bug 41025] Worms 2 in-game audio no longer works

https://bugs.winehq.org/show_bug.cgi?id=41025

Andrew Eikum  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 41025] Worms 2 in-game audio no longer works

https://bugs.winehq.org/show_bug.cgi?id=41025

--- Comment #4 from Andrew Eikum  ---
It was probably this commit that broke it:

commit 4fbe6f3e7601f7b39f7f672ffe43553eee92ab1b
Author: Andrew Eikum 
Date:   Thu May 19 09:11:08 2016 -0500

dsound: Allow inactive devices to change the primary format.

[Bug 41025] Worms 2 in-game audio no longer works

https://bugs.winehq.org/show_bug.cgi?id=41025

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |4fbe6f3e7601f7b39f7f672ffe4
                   |                            |3553eee92ab1b
          Component|-unknown                    |directx-dsound

--- Comment #5 from Bruno Jesus  ---
(In reply to Andrew Eikum from comment #4)
> It was probably this commit that broke it:
>
> commit 4fbe6f3e7601f7b39f7f672ffe43553eee92ab1b
> Author: Andrew Eikum 
> Date:   Thu May 19 09:11:08 2016 -0500
> dsound: Allow inactive devices to change the primary format.

Yes, perfect guess. Reverting it makes the sound work again.

[Bug 41025] Worms 2 in-game audio no longer works

https://bugs.winehq.org/show_bug.cgi?id=41025

--- Comment #6 from Andrew Eikum  ---
I've reverted this commit. Please retest with current wine-git or with Wine
1.9.17 when it is released.

commit b25e1aefc7b868266042f842955a001618ef3b1d
Author: Andrew Eikum 
Date:   Mon Aug 15 09:02:36 2016 -0500

Revert "dsound: Allow inactive devices to change the primary format.".

[Bug 41025] Worms 2 in-game audio no longer works

https://bugs.winehq.org/show_bug.cgi?id=41025

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |b25e1aefc7b868266042f842955
                   |                            |a001618ef3b1d

--- Comment #7 from Bruno Jesus  ---
(In reply to Andrew Eikum from comment #6)
> I've reverted this commit. Please retest with current wine-git or with Wine
> 1.9.17 when it is released.
>
> commit b25e1aefc7b868266042f842955a001618ef3b1d
> Author: Andrew Eikum 
> Date:   Mon Aug 15 09:02:36 2016 -0500
> Revert "dsound: Allow inactive devices to change the primary format.".

Fixed, thanks.

[Bug 41025] Worms 2 in-game audio no longer works

https://bugs.winehq.org/show_bug.cgi?id=41025

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.17.