[Bug 40997] New: Fallout 4 needs DXGI_FORMAT_BC7_UNORM_SRGB

https://bugs.winehq.org/show_bug.cgi?id=40997

Bug ID: 40997
           Summary: Fallout 4 needs DXGI_FORMAT_BC7_UNORM_SRGB
           Product: Wine
           Version: 1.9.14
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 55160
  --> https://bugs.winehq.org/attachment.cgi?id=55160
Fallout 4 +d3d,+d3d11

The game freezes after;

trace:d3d:wined3d_texture_init texture 0x7ffecd33d800, texture_ops
0x7ffff331b4c0, layer_count 1, level_count 1, resource_type
WINED3D_RTYPE_TEXTURE_2D, format WINED3DFMT_BC7_UNORM_SRGB, ...
warn:d3d:texture_init Failed to initialize texture, returning 0x8876086c.

Full log attached, latest wine from git, Steam version of the game.

[Bug 40997] Fallout 4 needs DXGI_FORMAT_BC7_UNORM_SRGB

https://bugs.winehq.org/show_bug.cgi?id=40997

Behem0th  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 40997] Fallout 4 needs DXGI_FORMAT_BC7_UNORM_SRGB

https://bugs.winehq.org/show_bug.cgi?id=40997

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from [e-mail] ---
(In reply to Kimmo Myllyvirta from comment #0)
> Created attachment 55160 [details]
> Fallout 4 +d3d,+d3d11
>
> The game freezes after;
>
> trace:d3d:wined3d_texture_init texture 0x7ffecd33d800, texture_ops
> 0x7ffff331b4c0, layer_count 1, level_count 1, resource_type
> WINED3D_RTYPE_TEXTURE_2D, format WINED3DFMT_BC7_UNORM_SRGB, ...
> warn:d3d:texture_init Failed to initialize texture, returning 0x8876086c.
>
> Full log attached, latest wine from git, Steam version of the game.

Hi,

Could you update to the latest Wine-git? I *think* this format has been added
since this report was made. If you look here:

http://source.winehq.org/patches/data/125519

the WINE_D3D_TO_STR(DXGI_FORMAT_BC7_UNORM_SRGB); format is listed in the first
section.

[Bug 40997] Fallout 4 needs DXGI_FORMAT_BC7_UNORM_SRGB

https://bugs.winehq.org/show_bug.cgi?id=40997

--- Comment #2 from Kimmo Myllyvirta  ---
Created attachment 55364
  --> https://bugs.winehq.org/attachment.cgi?id=55364
hack patch

Yes, I know it recognizes the format, but the implementation is missing. I'm
looking something similar to the attached patch I made some time (months) ago.
It's not rebased or anything, but it may apply cleanly to the current wine. I
don't even know if it's even remotely correct, but it makes the game go a bit
further.

[Bug 40997] Fallout 4 needs DXGI_FORMAT_BC7_UNORM_SRGB

https://bugs.winehq.org/show_bug.cgi?id=40997

--- Comment #3 from Matteo Bruni  ---
Actually with a few changes your patch should be good for submission.

AFAICS there is no GL_EXT_texture_compression_bptc so you can drop all the
hunks which refer to it (including the ifs in wined3d_adapter_init_gl_caps()).
GL_EXT_texture_compression_bptc became core in OpenGL 4.2, so you should fix
the core_extensions entry accordingly. Also you don't need to disable 3D
textures for BPTC, the spec does allow for them.
You could also add BC6H support while you're there.

Anyway, if you feel like updating your patch and sending it, properly
formatted, to wine-patches, it would be much appreciated.

[Bug 40997] Fallout 4 needs DXGI_FORMAT_BC7_UNORM_SRGB

https://bugs.winehq.org/show_bug.cgi?id=40997

--- Comment #4 from Kimmo Myllyvirta  ---
(In reply to Matteo Bruni from comment #3)
> Anyway, if you feel like updating your patch and sending it, properly
> formatted, to wine-patches, it would be much appreciated.

Thanks for the feedback. I'll try make some patches this weekend.

[Bug 40997] Fallout 4 needs DXGI_FORMAT_BC7_UNORM_SRGB

https://bugs.winehq.org/show_bug.cgi?id=40997

Kimmo Myllyvirta  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |27f5bc5bbcc6381879699920ff9
                   |                            |38eec440e336e
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Kimmo Myllyvirta  ---
Fixed with
http://source.winehq.org/git/wine.git/commit/27f5bc5bbcc6381879699920ff938ee...

[Bug 40997] Fallout 4 needs DXGI_FORMAT_BC7_UNORM_SRGB

https://bugs.winehq.org/show_bug.cgi?id=40997

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.18.