http://bugs.winehq.org/show_bug.cgi?id=22450
Summary: Can't disable unixfs Product: Wine Version: 1.1.43 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: shell32 AssignedTo: wine-bugs@winehq.org ReportedBy: dank@kegel.com
dlls/shell32/shfldr_unixfs.c claims that you can disable unixfs by deleting the registry key HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\Explorer\Desktop\Namespace{9D20AAE8-0625-44B0-9CA7-71889C2254D9} but unfortunately wine will recreate that key the next time you run a newer version of Wine.
To repeat, do
rm -rf ~/.wine wine regedit /d 'HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\Explorer\Desktop\Namespace{9D20AAE8-0625-44B0-9CA7-71889C2254D9}' wine notepad # Do File/Open and note that / does not appear in My Computer. wineserver -w ~/wine-git/wine notepad # Do File/Open and note that / *does* appear.
If we really want to disable unixfs, we may want a configure option to not even compile it in. I have a patch ready, will send it in.
http://bugs.winehq.org/show_bug.cgi?id=22450
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement
http://bugs.winehq.org/show_bug.cgi?id=22450
Alex Bradbury asb@asbradbury.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |asb@asbradbury.org
http://bugs.winehq.org/show_bug.cgi?id=22450
--- Comment #1 from Jerome Leclanche adys.wh@gmail.com 2011-05-08 05:24:27 CDT --- Created an attachment (id=34544) --> (http://bugs.winehq.org/attachment.cgi?id=34544) patch
+patch
originally sent to wine-patches by Dan Kegel on 28/04/2010
synced for wine-1.3.19-203-gf555c2d
(untested, for archive purposes only)
http://bugs.winehq.org/show_bug.cgi?id=22450
Andrew Church achurch+wine@achurch.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |achurch+wine@achurch.org
--- Comment #2 from Andrew Church achurch+wine@achurch.org 2013-08-10 10:26:04 CDT --- At least some people (for example: http://ubuntuforums.org/showthread.php?t=510812 - see under "A few comments on wine") believe that removing the default "z: -> /" drive mapping prevents programs from accessing the host filesystem through Windows APIs, and indeed I don't see that unixfs is documented anywhere (I had to use WINEDEBUG=+all to find the relevant code path), so this could be considered a security hole. I strongly suggest incorporating this patch, and also documenting the existence of unixfs in the same place as the drive mappings so people are not misled.
http://bugs.winehq.org/show_bug.cgi?id=22450
--- Comment #3 from Andrew Church achurch+wine@achurch.org 2013-08-10 12:25:19 CDT --- Created attachment 45572 --> http://bugs.winehq.org/attachment.cgi?id=45572 Patch against wine-1.7.0
This patch extends Dan Kegel's patch (which applies more or less cleanly against 1.7.0) to also disable code in ntdll which generates unixfs pathnames. I've tested this with a few random programs and it seems to work (modulo the wineboot issue below).
The only two remaining uses of unixfs I can see are:
- krnl386.exe16 (int21.c and vxd.c): Something to do with magic device names. I don't know what the code is supposed to do, so I can't suggest how to fix it.
- wineboot: This attempts to apply wine.inf from the global Wine data directory (e.g. /usr/share/wine). If I hack wineboot.c to use "z:" instead of "\?\unix" and restore the z: -> / link, it works as expected, but of course this breaks the whole idea of avoiding full host filesystem access. I think this may need to change to have the "wine" binary itself copy the data files into a Windows-API-visible temporary directory (c:\windows\temp or whatever) before wineboot is executed.
http://bugs.winehq.org/show_bug.cgi?id=22450
Sylvain Petreolle spetreolle@yahoo.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |spetreolle@yahoo.fr
https://bugs.winehq.org/show_bug.cgi?id=22450
Themroc v-whq@69b.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |v-whq@69b.org
https://bugs.winehq.org/show_bug.cgi?id=22450
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
https://bugs.winehq.org/show_bug.cgi?id=22450
--- Comment #4 from super_man@post.com --- patching file configure.ac Hunk #1 succeeded at 28 (offset 2 lines). patching file dlls/ntdll/directory.c Hunk #1 succeeded at 3098 (offset 201 lines). Hunk #2 succeeded at 3145 (offset 203 lines). patching file dlls/ntdll/path.c patching file dlls/shell32/folders.c patching file dlls/shell32/shellole.c patching file dlls/shell32/shellpath.c Hunk #1 succeeded at 4481 (offset 1698 lines). patching file dlls/shell32/shfldr.h patching file dlls/shell32/shfldr_desktop.c Hunk #1 succeeded at 186 (offset 2 lines). patching file dlls/shell32/shfldr_unixfs.c Hunk #1 succeeded at 167 with fuzz 2 (offset -1 lines). Hunk #2 succeeded at 2569 (offset -2 lines). Hunk #3 succeeded at 2583 (offset -2 lines). patching file include/config.h.in Hunk #1 succeeded at 7 (offset 1 line).
against current wine-git
https://bugs.winehq.org/show_bug.cgi?id=22450
Andrew Church achurch+wine@achurch.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #45572|0 |1 is obsolete| |
--- Comment #5 from Andrew Church achurch+wine@achurch.org --- Created attachment 54080 --> https://bugs.winehq.org/attachment.cgi?id=54080 Patch against Wine 1.9.5
FWIW, I keep this more or less up to date at http://achurch.org/patch-pile/#wine since it doesn't look like Wine devs are interested in it.
https://bugs.winehq.org/show_bug.cgi?id=22450
Andri Möll andri@dot.ee changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |andri@dot.ee
https://bugs.winehq.org/show_bug.cgi?id=22450
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de
https://bugs.winehq.org/show_bug.cgi?id=22450
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, patch, source