[Bug 13502] New: BRenBot application fails to start

http://bugs.winehq.org/show_bug.cgi?id=13502

Summary: BRenBot application fails to start
           Product: Wine
           Version: CVS/GIT
          Platform: PC
               URL: http://new.brenbot.com/files/brenbot/br_1-
                    52_install_mini.exe
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msvcrt
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=13423)
 --> (http://bugs.winehq.org/attachment.cgi?id=13423)
BRenBot with msvcrt traces

With Wine version wine-1.0-rc2-65-g914cb22, running BRenBot, a server bot for
the Renegade FDS, fails with some msvcrt fixmes and Perl compilation failures.
If native msvcrt is used, the app starts successfully (though the Renegade FDS
is needed for it to completely work).

[Bug 13502] BRenBot application fails to start

http://bugs.winehq.org/show_bug.cgi?id=13502

--- Comment #1 from Eric Pouech   2008-05-30 07:05:17 ---
Created an attachment (id=13478)
 --> (http://bugs.winehq.org/attachment.cgi?id=13478)
patch

I looked at the issue. Basically, two different items:
- printf (and al.) don't handle correctly cases where source and destination
strings potentially overlap
- the perl lib plays trick in our back by changing the internal fdesc structure
(which luckily is compatible with native layout), and we're not quite ready to
it

the attached patch tackles those issues

but when running the program here (without fds installed), I get a different
perl error than yours. would you mind testing the patch and post the outcome ?

TIA

[Bug 13502] BRenBot application fails to start

http://bugs.winehq.org/show_bug.cgi?id=13502

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch

[Bug 13502] BRenBot application fails to start

http://bugs.winehq.org/show_bug.cgi?id=13502

--- Comment #2 from scguy318   2008-05-30 14:35:27 ---
Patch works. I find that running BRenBot multiple times without the patch
yields different errors, possibly because the failing application fails to
dispose of the temporary PAR directory it generates.

[Bug 13502] BRenBot application fails to start

http://bugs.winehq.org/show_bug.cgi?id=13502

--- Comment #3 from scguy318   2008-05-30 14:42:44 ---
On second thought, running BRenBot with proper FDS installation fails. I'll
have traces in a moment.

[Bug 13502] BRenBot application fails to start

http://bugs.winehq.org/show_bug.cgi?id=13502

--- Comment #4 from scguy318   2008-05-30 14:50:45 ---
Created an attachment (id=13497)
 --> (http://bugs.winehq.org/attachment.cgi?id=13497)
BRenBot with msvcrt traces (with patched Wine)

Seems I forgot to remove the native override. For both the standalone and
proper BRenBot installs, I get:

fixme:msvcrt:MSVCRT__sopen : pmode 0x01b6 ignored
IO/File.pm did not return a true value at -e line 305.

with the former message repeated several times. Subsequent re-runs yield
different errors, probably due to the PAR directory the installer leaves behind
when it fails. Removing the PAR directory and re-running simply yields the
traces I've quoted. Traces are attached.

[Bug 13502] BRenBot application fails to start

http://bugs.winehq.org/show_bug.cgi?id=13502

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #5 from Austin English   2008-12-01 15:19:37 ---
Still present in git.

[Bug 13502] BRenBot application fails to start

http://bugs.winehq.org/show_bug.cgi?id=13502

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified

--- Comment #6 from Austin English   2009-01-20 02:39:07 ---
Removing deprecated CVS/GIT version tag. Please retest in current git. If the
bug is still present in today's wine, but was not present in some earlier
version of wine, please update version field to earliest known version of wine
that had the bug. Thanks!

[Bug 13502] BRenBot application fails to start

http://bugs.winehq.org/show_bug.cgi?id=13502

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from [e-mail]  2009-06-26 12:38:57 ---
Still present in wine 1.1.24

[Bug 13502] BRenBot application fails to start

http://bugs.winehq.org/show_bug.cgi?id=13502

--- Comment #8 from Austin English   2010-06-12 01:13:49 ---
Still present in 1.2-rc3.

[Bug 13502] BRenBot application fails to start

http://bugs.winehq.org/show_bug.cgi?id=13502

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Piotr Caban  2011-10-06 13:19:09 CDT ---
I've sent some patches that may solve this problem:
http://source.winehq.org/patches/data/79623
http://source.winehq.org/patches/data/79624

Please retest with this patches applied. If the application is still not
working please attach a tid,msvcrt,relay log. Looking from the traces the next
problem may be related to bug 17003.

[Bug 13502] BRenBot application fails to start

http://bugs.winehq.org/show_bug.cgi?id=13502

--- Comment #10 from Austin English  2011-10-06 17:46:11 CDT ---
(In reply to comment #9)
> I've sent some patches that may solve this problem:
> http://source.winehq.org/patches/data/79623
> http://source.winehq.org/patches/data/79624
>
> Please retest with this patches applied. If the application is still not
> working please attach a tid,msvcrt,relay log. Looking from the traces the next
> problem may be related to bug 17003.

http://source.winehq.org/git/wine.git/commitdiff/c867f3324ec6fd1330c8b3228bc...
http://source.winehq.org/git/wine.git/commitdiff/190c67c70e0cd3700c04d9c2c42...

[Bug 13502] BRenBot application fails to start

http://bugs.winehq.org/show_bug.cgi?id=13502

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
            Version|unspecified                 |1.0-rc2
         Resolution|                            |FIXED

--- Comment #11 from Andrew Nguyen  2011-10-08 07:35:38 CDT ---
BRenBot seems to be working now, so this is fixed.

[Bug 13502] BRenBot application fails to start

http://bugs.winehq.org/show_bug.cgi?id=13502

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  2011-10-10 13:13:57 CDT ---
Closing bugs fixed in 1.3.30.