[Bug 48032] New: Errors when installing games in Origin (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

Bug ID: 48032
           Summary: Errors when installing games in Origin (regression)
           Product: Wine
           Version: 4.18
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

During game installations, Origin will almost always print "An unexpected error
has occurred. Please try again in a few moments. Error: 327682:11" and not flag
the game as successfully installed.
Through bisect I've found that this is a regression which was caused by commit
e4ca5dbec056c977bffce31bd7901aaec884f199 (server: Add new pipe servers to the
end of the servers list). Reverting that commit against wine-4.3 also fixed the
issue (can't revert it against 4.19 as git revert doesn't let me).
I've made a log with +server debug channel. It was too big for bugzilla so I
had to upload it to my Google Drive:
https://drive.google.com/open?id=1doEVWo1qW1ppP_VemoCu8xhFkWXEsn0z
(oh, and ignore errors about wine not finding some .exes - i disabled them
myself for certain reasons).
Let me know if anything else is needed.

[Bug 48032] Errors when installing games in Origin (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

Alexandr Oleynikov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail]
    Regression SHA1|                            |e4ca5dbec056c977bffce31bd79
                   |                            |01aaec884f199

[Bug 48032] Errors when installing games in Origin (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

Alexandr Oleynikov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 48032] Errors when installing games in Origin (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

--- Comment #1 from Alexandr Oleynikov  ---
Actually, if I apply this against 4.19:

--- b/server/named_pipe.c
+++ a/server/named_pipe.c
@@ -1162,7 +1162,7 @@
     server->pipe_end.server_pid = get_process_id( current->process );
     init_async_queue( &server->listen_q );

+    list_add_head( &pipe->listeners, &server->entry );
-    list_add_tail( &pipe->listeners, &server->entry );
     if (!(server->pipe_end.fd = alloc_pseudo_fd( &pipe_server_fd_ops,
&server->pipe_end.obj, options )))
     {
         release_object( server );

it works as well.

[Bug 48032] Errors when installing games in Origin (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

Alexandr Oleynikov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 48032] Errors when installing games in Origin (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 48032] Errors when installing games in Origin (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

--- Comment #2 from Alexandr Oleynikov  ---
I should not that the issue is not 100% deterministic if you install just one 1
game, however, if you install a bunch of them (or just 1 + a bunch of DLCs, so
something like Sims 4), the error will definitively appear.

[Bug 48032] Origin often fails to install games (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

Alexandr Oleynikov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|x86                         |x86-64
            Summary|Errors when installing      |Origin often fails to
                   |games in Origin             |install games (regression)
                   |(regression)                |

[Bug 48032] Origin often fails to install games (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

Luca Boccassi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Luca Boccassi  ---
I have this issue too on the latest wine 5.4. Any update?

[Bug 48032] Origin often fails to install games (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Olivier F. R. Dierick  ---
*** Bug 47799 has been marked as a duplicate of this bug. ***

[Bug 48032] Origin often fails to install games (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #5 from Olivier F. R. Dierick  ---
(In reply to Luca Boccassi from comment #3)
> I have this issue too on the latest wine 5.4. Any update?

Hello,

I have no news about the issue, but I can confirm the issue, when The Sims 4
needs to be updated, and the workaround is to restart Origin completely after
each failed download/update/validation step.

Regards.

[Bug 48032] Origin often fails to install games (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

--- Comment #6 from Alexandr Oleynikov  ---
Lutris ships its own wine builds that have the offending commit reverted, which
allows Origin to work fine without encountering the downloading bug.

[Bug 48032] Origin often fails to install games (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

--- Comment #7 from Alexandr Oleynikov  ---
This is still an issue in newer versions of Wine

[Bug 48032] Origin often fails to install games (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

--- Comment #8 from Alexandr Oleynikov  ---
Still an issue as of 5.18. Should note that Origin is getting deprecated in the
near future, so this bug needs to be looked at at before then.

[Bug 48032] Origin often fails to install games (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

Filippe LeMarchand  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 48032] Origin often fails to install games (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

--- Comment #9 from Alexandr Oleynikov  ---
I understand that it may not be very easy to reproduce the issue without having
an Origin account which has a game with lots of DLCs for it, like Sims 4, so if
it's needed, I'm willing to temporarily provide access to my own account to aid
in fixing this issue, just contact me by email.

[Bug 48032] Origin often fails to install games (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from joaopa  ---
Does the bug still occur with wine-7.0-rc2?

[Bug 48032] Origin often fails to install games (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

--- Comment #11 from Alexandr Oleynikov  ---
This was fixed during the 6.0 code freeze, so yes, I just forgot about this
bug.

[Bug 48032] Origin often fails to install games (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

--- Comment #12 from joaopa  ---
Reported fixed. Can an administrator close this bug as FIXED?

(@reporter: you can close your own bug)

[Bug 48032] Origin often fails to install games (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #13 from Louis Lenders  ---
(In reply to Alexandr Oleynikov from comment #11)
> This was fixed during the 6.0 code freeze, so yes, I just forgot about this
> bug.

Ok , closing as fixed then.

regards

[Bug 48032] Origin often fails to install games (regression)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48032

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard  ---
Closing bugs fixed in 7.0-rc3.