[Bug 48962] New: Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

Bug ID: 48962
           Summary: Save file dialog doesn't show full label text for some
                    locales
           Product: Wine
           Version: 5.4
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: comdlg32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 66937
  --> https://bugs.winehq.org/attachment.cgi?id=66937
Win7 screenshot

See screenshots.

Affected locales are for example fr_FR and de_DE.

[Bug 48962] Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

--- Comment #1 from Fabian Maurer  ---
Created attachment 66938
  --> https://bugs.winehq.org/attachment.cgi?id=66938
Wine screenshot

[Bug 48962] Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66938|0                           |1
        is obsolete|                            |

--- Comment #2 from Fabian Maurer  ---
Created attachment 66939
  --> https://bugs.winehq.org/attachment.cgi?id=66939
Wine screenshot

See highlight for affected label.

[Bug 48962] Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://jira.reactos.org/br
                   |                            |owse/CORE-16890

[Bug 48962] Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

Kyle_Katarn  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Kyle_Katarn  ---
This is likely due to a too narrow IDC_LOOKINSTATICdefinition in NEWFILEOPENORD
ressource

[Bug 48962] Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

--- Comment #4 from Kyle_Katarn  ---
(In reply to Kyle_Katarn from comment #3)
> This is likely due to a too narrow IDC_LOOKINSTATICdefinition in
> NEWFILEOPENORD ressource

My mistake, This is due to a too narrow array "WCHAR buf[16];" in filedlg.c
ComDlg ressource.

WCHAR buf[16] ==>       WCHAR buf[24];

/* change Open to Save */
  if (fodInfos->DlgInfos.dwDlgProp & FODPROP_SAVEDLG)
  {
      WCHAR buf[16];
      LoadStringW(COMDLG32_hInstance, IDS_SAVE_BUTTON, buf, ARRAY_SIZE(buf));
      SetDlgItemTextW(hwnd, IDOK, buf);
      LoadStringW(COMDLG32_hInstance, IDS_SAVE_IN, buf, ARRAY_SIZE(buf));
      SetDlgItemTextW(hwnd, IDC_LOOKINSTATIC, buf);
  }

[Bug 48962] Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

--- Comment #5 from Kyle_Katarn  ---
Dear Wine team, do tou validate the proposed solution ? (array size increased
up to [24])

[Bug 48962] Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Zebediah Figura  ---
Perhaps better would be to pass 0 as the final argument.

[Bug 48962] Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

--- Comment #7 from Kyle_Katarn  ---
(In reply to Zebediah Figura from comment #6)
> Perhaps better would be to pass 0 as the final argument.

Final argument to what ?

[Bug 48962] Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

--- Comment #8 from Zebediah Figura  ---
(In reply to Kyle_Katarn from comment #7)
> (In reply to Zebediah Figura from comment #6)
> > Perhaps better would be to pass 0 as the final argument.
>
> Final argument to what ?

As the final argument to LoadStringW(). In that case it will return a constant
pointer to the resource in the third argument.

[Bug 48962] Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

--- Comment #9 from Kyle_Katarn  ---
OK but the point here to is change  WCHAR buf[16] in to  WCHAR buf[24] in order
to accept longer strings.

[Bug 48962] Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

--- Comment #10 from Kyle_Katarn  ---
(In reply to Kyle_Katarn from comment #9)
> OK but the point here to is change  WCHAR buf[16] in to  WCHAR buf[24] in
> order to accept longer strings.

Good point.... i'll che(In reply to Zebediah Figura from comment #8)
> (In reply to Kyle_Katarn from comment #7)
> > (In reply to Zebediah Figura from comment #6)
> > > Perhaps better would be to pass 0 as the final argument.
> >
> > Final argument to what ?
>
> As the final argument to LoadStringW(). In that case it will return a
> constant pointer to the resource in the third argument.

Good point indeed. I'll check !

[Bug 48962] Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

--- Comment #11 from Fabian Maurer  ---
Still present as of wine-7.20.

[Bug 48962] Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

--- Comment #12 from Kyle_Katarn  ---
(In reply to Fabian Maurer from comment #11)
> Still present as of wine-7.20.

Fixed locally in ReactOS and working fine, waiting for a later fix in Wine :
https://github.com/reactos/reactos/commit/9c682e4c1670be4f23d02503b21256886e...

[Bug 48962] Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

--- Comment #13 from Fabian Maurer  ---
> Fixed locally in ReactOS and working fine, waiting for a later fix in Wine

I don't see how that would help, the problem is that the label is too small.
Even with the patch from ROS, it still doesn't work for me using Wine.

[Bug 48962] Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

--- Comment #14 from Kyle_Katarn  ---
(In reply to Fabian Maurer from comment #13)
> > Fixed locally in ReactOS and working fine, waiting for a later fix in Wine
>
> I don't see how that would help, the problem is that the label is too small.
> Even with the patch from ROS, it still doesn't work for me using Wine.

Do you have a specific test case / screenshot ? I'd be pleased to test ReactOS
against it

[Bug 48962] Save file dialog doesn't show full label text for some locales

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48962

--- Comment #15 from Fabian Maurer  ---
> Do you have a specific test case / screenshot ? I'd be pleased to test
> ReactOS against it

Well, the one attached here: Export in Regedit.