[Bug 14812] New: dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

Summary: dsound bug causes games to crash
           Product: Wine
           Version: 1.1.2
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: directx-dsound
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

example

command and conquer - tiberian dawn
in game, everything works, until the sound crashes

see log

after sound crashes, ingame continues to work (although silently), though any
further action (abort game, finish map, etc) when loading next section causes
game to crash and get 100% cpu, requiring force quit of program.

upon googling it, it seems that SEVERAL games have this problem and there is no
fix.

http://www.google.com/search?hl=en&q=err%3Adsound%3ADSOUND_MixOne&bt...

other games effected
counterstrike
wow
warcraft 3
zdoom
pharaoh
eve online
super cosplay war ultra
worms armagedon
(the list continues)

i believe this to be a major problem with directx sound which probably effects
most games that use directx.

please see attached file <log.txt>
like 7 & 9 where the sound breaks
"err:dsound:DSOUND_MixOne Fatal error. Under/Overflow?"

[Bug 14812] dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

--- Comment #1 from Ben Trusty   2008-08-10 00:22:20 ---
Created an attachment (id=15363)
 --> (http://bugs.winehq.org/attachment.cgi?id=15363)
command and conquer - tiberian dawn audio dsound crash log

[Bug 14812] dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

Maarten Lankhorst  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Maarten Lankhorst   2008-08-10 00:28:57 ---
I don't know whether this is a directsound error or not, but I doubt it is.
Sound underflow/overflows usually don't cause crashes, and I don't see anything
here that indicates it's a sound problem.

If you still think it's a problem, edit dlls/winealsa.drv/dsoutput.c

Change
snd_pcm_uframes_t used = This->mmap_buflen_frames -
snd_pcm_avail_update(This->pcm);
To
        snd_pcm_sframes_t used = This->mmap_buflen_frames -
snd_pcm_avail_update(This->pcm);

if (used < 0)
        {
            snd_pcm_forward(This->pcm, -used);
            used = 0;
        }

I've sent this patch to wine-patches, but AJ is on vacation. If there really is
an underrun this will at least recover from it.

[Bug 14812] dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal

--- Comment #3 from Dmitry Timoshkov   2008-08-10 04:37:05 ---
Nothing critical.

[Bug 14812] dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

--- Comment #4 from Ben Trusty   2008-08-10 19:04:32 ---
(In reply to comment #3)
> Nothing critical.

9+ games breaking due to sound bug during gameplay not critical?

[Bug 14812] dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

[Bug 14812] dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

--- Comment #5 from Ben Trusty   2008-08-11 07:14:21 ---
did code change suggested by Maarten Lankhorst,
>

Change
snd_pcm_uframes_t used = This->mmap_buflen_frames -
snd_pcm_avail_update(This->pcm);
To
        snd_pcm_sframes_t used = This->mmap_buflen_frames -
snd_pcm_avail_update(This->pcm);

if (used < 0)
        {
            snd_pcm_forward(This->pcm, -used);
            used = 0;
        }
>

complied, ran

it worked, though some sound clips got truncated and glitched between two sound
tracks within game play. will have to test further tonight after work.

but the game never dropped sound completely.
and never locked up because of it. i was able to play C&C for 30 minutes
without losing sound and then the rest of the game. just need to figure out the
overlap / lack of simultaneous streams so that the sound does not sound
glitchy.

thanks

[Bug 14812] dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

--- Comment #6 from Maarten Lankhorst   2008-08-11 08:26:08 ---
What does uname -r say?

[Bug 14812] dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

--- Comment #7 from Ben Trusty   2008-08-11 18:58:43 ---
(In reply to comment #6)
> What does uname -r say?

2.6.24-19-generic

latest from synaptic

[Bug 14812] dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

--- Comment #8 from Ben Trusty   2008-08-11 23:54:57 ---
(In reply to comment #7)
> (In reply to comment #6)
> > What does uname -r say?
>
> 2.6.24-19-generic
>
> latest from synaptic

after playing C&C again tonight, it does not completely fix the problem
i played for about 20-30 minutes and then the sound died, same error message as
before. once the sound goes out, attempting to close the game just sits there
(left it for 5 minutes) then force quit it.

oh well, back to the drawing board.

[Bug 14812] dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

--- Comment #9 from sven   2008-08-19 06:21:05 ---
workaround / fix:

tested with wine 1.0 / debian lenny / world of warcraft

switch hardware acceleration to standard instead of full on the audio tab of
winecfg

played about an hour and the error did not occur again.

[Bug 14812] dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

--- Comment #10 from Maarten Lankhorst   2008-08-19 06:51:52 ---
That's just make believe. There is no difference between 'full' and 'standard'
only thing it cares about is whether it's 'emulation' or not.

[Bug 14812] dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

--- Comment #11 from Austin English   2009-02-16 02:27:30 ---
Is this still an issue in current (1.1.15 or newer) wine?

[Bug 14812] dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

Marco Túlio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Marco Túlio   2009-04-17 14:28:16 ---
I'm playing Pharaoh in wine 1.1.19 and i've never found this bug.

[Bug 14812] dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Austin English   2009-04-17 14:39:11 ---
Reported fixed.

[Bug 14812] dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

Marco Túlio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]     |

[Bug 14812] dsound bug causes games to crash

http://bugs.winehq.org/show_bug.cgi?id=14812

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard   2009-04-24 12:15:33 ---
Closing bugs fixed in 1.1.20.