[Bug 31519] New: App installer that uses fc.exe and find.exe fails because they don't exist

http://bugs.winehq.org/show_bug.cgi?id=31519

Bug #: 31519
           Summary: App installer that uses fc.exe and find.exe fails
                    because they don't exist
           Product: Wine
           Version: 1.5.11
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

A user emailed me privately with the log of an installer that had failed.
The first problem was it had executed the command

fc /b foo.bar c:\windows\system32\foo.bar | FIND /I "FC: no differences
encountered" > nul

and expected status 0.

[Bug 31519] App installer that uses fc.exe and find.exe fails because they don't exist

http://bugs.winehq.org/show_bug.cgi?id=31519

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Installer

[Bug 31519] App installer that uses fc.exe and find.exe fails because they don't exist

http://bugs.winehq.org/show_bug.cgi?id=31519

--- Comment #1 from Dan Kegel  2012-08-22 11:28:53 CDT ---
Created attachment 41456
  --> http://bugs.winehq.org/attachment.cgi?id=41456
First draft of stub fc to make this installer happy

[Bug 31519] App installer that uses fc.exe and find.exe fails because they don't exist

http://bugs.winehq.org/show_bug.cgi?id=31519

--- Comment #2 from Dan Kegel  2012-08-23 08:53:16 CDT ---
Created attachment 41466
  --> http://bugs.winehq.org/attachment.cgi?id=41466
Draft patch implementing just enough of fc and find

[Bug 31519] App installer that uses fc.exe and find.exe fails because they don't exist

https://bugs.winehq.org/show_bug.cgi?id=31519

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #3 from Austin English  ---
Still unimplemented (though findstr is now present).

[Bug 31519] App installer that uses fc.exe and find.exe fails because they don't exist

https://bugs.winehq.org/show_bug.cgi?id=31519

Kaipeng Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 31519] Multiple applications need 'fc.exe' (file compare) command line tool with support for binary comparison

https://bugs.winehq.org/show_bug.cgi?id=31519

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|App installer that uses     |Multiple applications need
                   |fc.exe and find.exe fails   |'fc.exe' (file compare)
                   |because they don't exist    |command line tool with
                   |                            |support for binary
                   |                            |comparison
           Keywords|Installer                   |
                 CC|                            |[e-mail]

--- Comment #4 from Anastasius Focht  ---
Hello folks,

separating the issue into two: missing 'fc.exe' and 'find.exe'.

Obviously still present.

Command line usage: https://ss64.com/nt/fc.html

$ wine --version
wine-3.6

Regards

[Bug 31519] Multiple applications need 'fc.exe' (file compare) command line tool with support for binary comparison

https://bugs.winehq.org/show_bug.cgi?id=31519

--- Comment #5 from Anastasius Focht  ---
Hello folks,

I've created bug 44975 ("Multiple applications need 'find.exe' command line
tool (ConEmu)") to track 'find.exe'.

Regards

[Bug 31519] Multiple applications need 'fc.exe' (file compare) command line tool with support for binary comparison

https://bugs.winehq.org/show_bug.cgi?id=31519

tokktokk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 31519] Multiple applications need 'fc.exe' (file compare) command line tool with support for binary comparison

https://bugs.winehq.org/show_bug.cgi?id=31519

--- Comment #6 from Anastasius Focht  ---
Hello folks,

commit
https://source.winehq.org/git/wine.git/commitdiff/96a616577622cdc0ad04beea3c...
added 'fc.exe' stub program.

The minimum requested functionality still missing though: binary comparison
between two files (see comment #1 draft).

Regards

[Bug 31519] Multiple applications need 'fc.exe' (file compare) command line tool with support for binary comparison

https://bugs.winehq.org/show_bug.cgi?id=31519

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Fabian Maurer  ---
I'm starting to work on a proper implementation now.

However, there still is an issue with localisation - the message "FC: no
differences encountered" is translated into german on my german VM.
Do you know how the installer handles that case? Because if it really just
hardcoded the english string, it will be locale dependent whether it works.
Might make for an interesting test case though.

[Bug 31519] Multiple applications need 'fc.exe' (file compare) command line tool with support for binary comparison

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=31519

--- Comment #8 from Anastasius Focht  ---
Hello folks,

revisiting, program still a stub.

https://source.winehq.org/git/wine.git/blob/0c27d244f76ad90301c5db09d738b3a0...

$ wine --version
wine-5.7-141-g0c27d244f7

Regards

[Bug 31519] Multiple applications need 'fc.exe' (file compare) command line tool with support for binary comparison

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=31519

--- Comment #9 from Fabian Maurer  ---
This should be mostly implemented now, can we close this?

[Bug 31519] Multiple applications need 'fc.exe' (file compare) command line tool with support for binary comparison

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=31519

--- Comment #10 from Hans Leidekker  ---
(In reply to Fabian Maurer from comment #9)
> This should be mostly implemented now, can we close this?

The bug title mentions binary comparison which is still missing, so I think we
should keep this open.