[Bug 34755] New: strsafe.h functions are lacking

http://bugs.winehq.org/show_bug.cgi?id=34755

Bug #: 34755
           Summary: strsafe.h functions are lacking
           Product: Wine
           Version: unspecified
          Platform: x86
               URL: http://msdn.microsoft.com/en-us/library/windows/deskto
                    p/ms647466%28v=vs.85%29.aspx
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

I tried to compile the latest version of TweakPNG
(http://entropymine.com/jason/tweakpng/) with Wine today. Apparently, the
strsafe.h header provided by Wine is only a dummy and seems to lack most of the
functions.

If I'm reading correctly, this header (and all its functions) has been part of
the Windows API since XPSP2, so I guess Wine should aim to provide that
functionality as well.

[Bug 34755] strsafe.h functions are lacking

https://bugs.winehq.org/show_bug.cgi?id=34755

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source
                 CC|                            |[e-mail]

--- Comment #1 from Austin English  ---
Still in 1.7.37.

[Bug 34755] strsafe.h functions are lacking

https://bugs.winehq.org/show_bug.cgi?id=34755

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from [e-mail] ---
still an issue 1.7.51

[Bug 34755] strsafe.h functions are lacking

https://bugs.winehq.org/show_bug.cgi?id=34755

Mark Jansen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Mark Jansen  ---
How about
https://git.reactos.org/?p=reactos.git;a=blob;f=reactos/include/psdk/strsafe...

That seems usable.

[Bug 34755] strsafe.h functions are lacking

https://bugs.winehq.org/show_bug.cgi?id=34755

--- Comment #4 from Nikolay Sivov  ---
If anything mingw-w64 should be referenced
http://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-header...,
and definitely not reactos.

Main concern is amount of inline code there I think, with no way to test it,
except building with Windows SDK

[Bug 34755] strsafe.h functions are lacking

https://bugs.winehq.org/show_bug.cgi?id=34755

--- Comment #5 from Rimas Kudelis  ---
I wonder what's worse: having code not covered with tests, or having no code at
all. At least to me, untested code that works seems like a better choice.

[Bug 34755] strsafe.h functions are lacking

https://bugs.winehq.org/show_bug.cgi?id=34755

--- Comment #6 from Nikolay Sivov  ---
The point is to base implementation on tests results, instead of deriving it
one way or another from copyrighted sources. In the meantime a trivial
workaround for you is to use this file from SDK, or mingw-w64 package.

[Bug 34755] strsafe.h functions are lacking

https://bugs.winehq.org/show_bug.cgi?id=34755

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.7.4
          Component|-unknown                    |build-env