http://bugs.winehq.org/show_bug.cgi?id=26494
Summary: Office 2007 installer crashes on start Product: Wine Version: 1.3.16 Platform: x86 OS/Version: Linux Status: NEW Keywords: regression Severity: normal Priority: P2 Component: msxml3 AssignedTo: wine-bugs@winehq.org ReportedBy: dimesio@earthlink.net
Doesn't even make it to the splash screen.
710b643b2ffe56f1ab754d030cbc651220919bfa is the first bad commit commit 710b643b2ffe56f1ab754d030cbc651220919bfa Author: Nikolay Sivov nsivov@codeweavers.com Date: Thu Mar 10 04:19:29 2011 +0300
msxml3: Some get_attributes() tests.
:040000 040000 84e170cc3739dbd1bddbb9e28256e18167a32ae9 d97763783886a9a1be55e5ba81f8dbc5e8124f34 M dlls
The patch doesn't revert cleanly.
http://bugs.winehq.org/show_bug.cgi?id=26494
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bunglehead@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=26494
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Office 2007 installer |Office 2007 installer |crashes on start |terminates on start
http://bugs.winehq.org/show_bug.cgi?id=26494
--- Comment #1 from Rosanne DiMesio dimesio@earthlink.net 2011-03-20 08:42:00 CDT --- Created an attachment (id=33732) --> (http://bugs.winehq.org/attachment.cgi?id=33732) +msxml log
Attaching +msxml log.
Winetricks msxml3 works around the problem.
http://bugs.winehq.org/show_bug.cgi?id=26494
--- Comment #2 from Nikolay Sivov bunglehead@gmail.com 2011-03-20 09:07:41 CDT --- I wasn't sure anything uses attributes from <?xml. Could you try to revert pi.c part only? If it doesn't revert automatically, it's really simple to revert it manually.
http://bugs.winehq.org/show_bug.cgi?id=26494
--- Comment #3 from Rosanne DiMesio dimesio@earthlink.net 2011-03-20 18:47:51 CDT --- (In reply to comment #2)
I wasn't sure anything uses attributes from <?xml. Could you try to revert pi.c part only? If it doesn't revert automatically, it's really simple to revert it manually.
I'm sure it is simple for someone who knows what they're doing, but that's not necessarily me. I'm not even quite sure what you mean by "automatically."
I did try building Wine despite the message about failed thunks. That produced an actual crash. Unlike before, the splash screen appeared, but it got no further. I can upload the backtrace if that's what you're looking for. Otherwise, I'm going to need clearer instructions on how to revert part of a patch.
http://bugs.winehq.org/show_bug.cgi?id=26494
--- Comment #4 from Nikolay Sivov bunglehead@gmail.com 2011-03-20 19:04:14 CDT --- (In reply to comment #3)
I'm sure it is simple for someone who knows what they're doing, but that's not necessarily me.
Sure, I'll explain.
I'm not even quite sure what you mean by "automatically."
I mean cleanly.
I did try building Wine despite the message about failed thunks. That produced an actual crash. Unlike before, the splash screen appeared, but it got no further. I can upload the backtrace if that's what you're looking for. Otherwise, I'm going to need clearer instructions on how to revert part of a patch.
As I understand 'git revert' fails because of test changes. You need to revert only pi.c changes, for this case it's ok to revert all pi.c changes starting mentioned commit. To do that you can do:
'git diff 710b643b2ffe56f1ab754d030cbc651220919bfa^ dlls/msxml3/pi.c | patch -p1 -R'
This will leave uncommitted changes in your tree unlike 'git revert', to easily clean up after you're done with reproducing crash do:
'git diff | patch -p1 -R'
this will revert reverted changes and make 'git diff' output empty.
http://bugs.winehq.org/show_bug.cgi?id=26494
--- Comment #5 from Rosanne DiMesio dimesio@earthlink.net 2011-03-20 21:29:32 CDT --- Created an attachment (id=33737) --> (http://bugs.winehq.org/attachment.cgi?id=33737) crash after reverting pi.c
Thanks for the howto; that's useful to know. It did revert cleanly following your instructions; I'm attaching the crash log.
http://bugs.winehq.org/show_bug.cgi?id=26494
--- Comment #6 from Nikolay Sivov bunglehead@gmail.com 2011-03-21 04:16:58 CDT --- Created an attachment (id=33739) --> (http://bugs.winehq.org/attachment.cgi?id=33739) patch
Try this one, it should revert to state before any of my recent nodemap changes. Map won't work anyway and never did, that's why I disabled this. To properly implement this I need to customized map implementation, will try to find time for that.
http://bugs.winehq.org/show_bug.cgi?id=26494
--- Comment #7 from Rosanne DiMesio dimesio@earthlink.net 2011-03-21 12:46:00 CDT --- The patch works.
http://bugs.winehq.org/show_bug.cgi?id=26494
--- Comment #8 from Nikolay Sivov bunglehead@gmail.com 2011-03-29 00:32:52 CDT --- This should work again (64e5a6a2576ea784a9df204c78f0593fbda2b267).
http://bugs.winehq.org/show_bug.cgi?id=26494
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #9 from Rosanne DiMesio dimesio@earthlink.net 2011-03-29 07:57:22 CDT --- Yes, it's fixed in wine-1.3.16-74-g7ee63f0.
http://bugs.winehq.org/show_bug.cgi?id=26494
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #10 from Alexandre Julliard julliard@winehq.org 2011-04-01 12:40:26 CDT --- Closing bugs fixed in 1.3.17.