[Bug 9926] New: gdi32.dll should not have exported function pointers

http://bugs.winehq.org/show_bug.cgi?id=9926

Summary: gdi32.dll should not have exported function pointers
           Product: Wine
           Version: CVS/GIT
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: wine-gdi-(printing)
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
            Blocks: 219

These two pointers are not present on the native systems:
@ extern pfnRealizePalette
@ extern pfnSelectPalette

This causes some code in SafeDisk 3.x to crash dereferencing these pointers.
They should be replaced with function calls to get/set them instead.

[Bug 9926] gdi32.dll should not have exported function pointers

http://bugs.winehq.org/show_bug.cgi?id=9926

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.0.0

--- Comment #1 from Vitaliy Margolen   2007-10-06 13:44:29 ---
Should be in 1.0.0

[Bug 9926] gdi32.dll should not have exported function pointers

http://bugs.winehq.org/show_bug.cgi?id=9926

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Anastasius Focht   2007-11-02 02:50:18 ---
Hello,

are you sure that this is a show stopper for SafeDisc 3.x?
As I have already mentioned in http://bugs.winehq.org/show_bug.cgi?id=10273
SafeDisc's 2.x entry point code analyzer/disassembler (which might be present
in 3.x too) probably mistreats the data exports as normal API code.
Depending on pointer values at the point of analysis (runtime), invalid/unknown
opcode sequences or invalid (cond) jump destinations might result from this.
AFAIK the disassembler/tracer has it's own exception handler, catching any
problematic tracer state.

Unfortunately I have no SafeDisc 3.x target to verify this (only guess)...

Regards

[Bug 9926] gdi32.dll should not have exported function pointers

http://bugs.winehq.org/show_bug.cgi?id=9926

--- Comment #3 from Vitaliy Margolen   2007-11-02 07:27:14 ---
I'm not 100% sure on this one. As the game still doesn't run as-is. Or with
these two pointers removed. It was one area of concern when I was debugging SD.
Since it really does lead to some bogus opcodes/addresses.

[Bug 9926] gdi32.dll should not have exported function pointers

http://bugs.winehq.org/show_bug.cgi?id=9926

--- Comment #4 from James Pahlmeyer   2008-01-30 11:27:17 ---
Hi
Is there any easy way to tell which copy protection or what version of copy
protection a program uses?

[Bug 9926] gdi32.dll should not have exported function pointers

http://bugs.winehq.org/show_bug.cgi?id=9926

--- Comment #5 from Anastasius Focht   2008-01-30 12:46:12 ---
Hello,

--- snip ---
Is there any easy way to tell which copy protection or what version of copy
protection a program uses?
--- snip ---

In most cases yes.
There are several copy protection ID tools available.

Here is an updated guide for the most (in)famous ones:
http://club.cdfreaks.com/f81/copy-protection-identifying-guides-updated-janu...

For games I use "Protection ID" and "A-Ray Scanner" to quickly identify game
copy protection type and version used.

For custom protections, e.g. exe/pe-protectors, packers and the like I use
"peid".
Though there are several "mutations" or newer versions of protectors in the
wild which fail the scan for known signatures.
That's where the knowledge of advanced reversers comes in ;-)

Regards

[Bug 9926] gdi32.dll should not have exported function pointers

http://bugs.winehq.org/show_bug.cgi?id=9926

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
   Target Milestone|1.0.0                       |1.2.0

--- Comment #6 from Dan Kegel   2008-03-30 19:38:27 ---
If we're not sure, probably best not to mark it for 1.0, then?

[Bug 9926] gdi32.dll should not have exported function pointers

http://bugs.winehq.org/show_bug.cgi?id=9926

--- Comment #7 from Austin English   2008-10-06 00:45:35 ---
Is this still an issue in current (1.1.5 or newer) wine?

[Bug 9926] gdi32.dll should not have exported function pointers

http://bugs.winehq.org/show_bug.cgi?id=9926

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |ABANDONED

--- Comment #8 from Vitaliy Margolen   2008-10-18 14:18:10 ---
I'll close this as abandoned. The version of SafeDisk I had the problem with
works fine now. It still doesn't make those entries correct, but it seems they
don't adversely affect SafeDisk as I thought before.

[Bug 9926] gdi32.dll should not have exported function pointers

http://bugs.winehq.org/show_bug.cgi?id=9926

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Vitaliy Margolen   2008-10-18 14:18:45 ---
Closing.

[Bug 9926] gdi32.dll should not have exported function pointers

http://bugs.winehq.org/show_bug.cgi?id=9926

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified