[Bug 47217] New: Adobe Lightroom crashes in d2d: d2d_device_context_DrawImage

https://bugs.winehq.org/show_bug.cgi?id=47217

Bug ID: 47217
           Summary: Adobe Lightroom crashes in
                    d2d:d2d_device_context_DrawImage
           Product: Wine
           Version: 4.8
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: d2d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 64488
  --> https://bugs.winehq.org/attachment.cgi?id=64488
gzipped console log

When the GPU Acceleration is switched on in the Lightroom configuration,
opening Import module crashes wine. This bug has been sitting there for some
time, spanning from Lightroom releases 7.2, 7.5 and 8.1 (all 64b) and wine
releases back to 3.20 AFAIR. Switching the GPU Acceleration off makes the
Import module work as expected (albeit slow).

Not exactly sure this is a D2D issue, the traces usually look like this:
> 0029:fixme:d2d:d2d_device_context_CreateEffect iface 0x401aa400, effect_id {1feb6d69-2fe6-4ac9-8c58-1d7f93e7a6a5}, effect 0x23e1e0 stub!
> 0029:fixme:d2d:d2d_effect_SetInput iface 0x7ff01d4c8780, index 0, input 0x7ff03fb35380, invalidate 1 stub!
> 0029:fixme:d2d:d2d_effect_SetValue iface 0x7ff01d4c8780, index 2, type 0, value 0x23e370, value_size 4 stub!
> 0029:fixme:d2d:d2d_effect_SetValue iface 0x7ff01d4c8780, index 0, type 0, value 0x23e370, value_size 4 stub!
> 0029:fixme:d2d:d2d_effect_GetOutput iface 0x7ff01d4c8780, output 0x23e370 stub!
> 0029:fixme:d2d:d2d_device_context_DrawImage iface 0x401aa400, image (nil), target_offset {2.66799965e+01, 1.46500000e+02}, image_rect (null), interpolation_mode 0x1, composite_mode 0 stub!
> wine: Unhandled page fault on read access to 0x00000000 at address 0x572ebed (thread 0029), starting debugger...

Let me know in case any other information is needed.

[Bug 47217] Adobe Lightroom crashes in d2d:d2d_device_context_DrawImage

https://bugs.winehq.org/show_bug.cgi?id=47217

--- Comment #1 from Henri Verbeet  ---
It's probably not crashing in DrawImage() itself, since that just prints a
FIXME. DrawImage() does get called with a NULL ID2D1Image pointer though, which
was likely returned by the preceding d2d_effect_GetOutput() call. My guess
would be that the application is crashing while trying to call some method from
that NULL image.

If that's the issue, it shouldn't be terribly hard to implement. I'm unlikely
to have the time for that myself in the near term though, so anyone who would
like to pick this up would be welcome to.

[Bug 47217] Adobe Lightroom crashes in d2d:d2d_device_context_DrawImage

https://bugs.winehq.org/show_bug.cgi?id=47217

pattietreutel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 47217] Adobe Lightroom 7.2, 7.5 and 8.1 with GPU Acceleration enabled crash when opening import module (d2d_effect_GetValue is a stub)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47217

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
            Summary|Adobe Lightroom crashes in  |Adobe Lightroom 7.2, 7.5
                   |d2d:d2d_device_context_Draw |and 8.1 with GPU
                   |Image                       |Acceleration enabled crash
                   |                            |when opening import module
                   |                            |(d2d_effect_GetValue is a
                   |                            |stub)
                 CC|                            |[e-mail]
     Ever confirmed|0                           |1
                URL|                            |https://prodesigntools.com/
                   |                            |prdl-download/Nimbus/8B6881
                   |                            |3B39A14CCD91DDCE8D93225574/
                   |                            |1548399558333/LRCC_2.1_2018
                   |                            |1129-0106-61a316d_win64_Rel
                   |                            |ease_ESD.zip
           Keywords|                            |download

--- Comment #2 from Anastasius Focht  ---
Hello folks,

confirming. Refining some fields.

Direct download link for 'Lightroom CC 2019':

https://prodesigntools.com/adobe-cc-2019-direct-download-links.html

https://prodesigntools.com/prdl-download/Nimbus/8B68813B39A14CCD91DDCE8D9322...

Wine source:

https://source.winehq.org/git/wine.git/blob/e377786a71c3b6eab5bc11c0b1c9c7c3...

--- snip ---
 132 static HRESULT STDMETHODCALLTYPE d2d_effect_GetValue(ID2D1Effect *iface,
UINT32 index, D2D1_PROPERTY_TYPE type,
 133         BYTE *value, UINT32 value_size)
 134 {
 135     FIXME("iface %p, index %u, type %#x, value %p, value_size %u stub!\n",
iface, index, type,
 136             value, value_size);
 137 
 138     return E_NOTIMPL;
 139 }
--- snip ---

$ sha1sum LRCC_2.1_20181129-0106-61a316d_win64_Release_ESD.zip 
bff2ef23ed6e90b57072129d55a5f81a2ca00bc9 
LRCC_2.1_20181129-0106-61a316d_win64_Release_ESD.zip

$ du -sh LRCC_2.1_20181129-0106-61a316d_win64_Release_ESD.zip 
909M    LRCC_2.1_20181129-0106-61a316d_win64_Release_ESD.zip

$ wine --version
wine-6.0-rc4

Regards

[Bug 47217] Adobe Lightroom 7.2, 7.5 and 8.1 with GPU Acceleration enabled crash when opening import module (d2d_effect_GetValue is a stub)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47217

--- Comment #3 from Tomáš Bžatek  ---
FYI the newer versions of Lightroom have changed GPU handling significantly.
The vkd3d work is on a good way perhaps, though lot of work will be needed to
implement all required D3D features to make LR actually useable.

[Bug 47217] Adobe Lightroom 7.2, 7.5 and 8.1 with GPU Acceleration enabled crash when opening import module (d2d_effect_GetValue is a stub)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47217

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|https://prodesigntools.com/ |https://web.archive.org/web
                   |prdl-download/Nimbus/8B6881 |/20190408040518/http://prdl
                   |3B39A14CCD91DDCE8D93225574/ |-download.adobe.com/Nimbus/
                   |1548399558333/LRCC_2.1_2018 |8B68813B39A14CCD91DDCE8D932
                   |1129-0106-61a316d_win64_Rel |25574/1548399558333/LRCC_2.
                   |ease_ESD.zip                |1_20181129-0106-61a316d_win
                   |                            |64_Release_ESD.zip

[Bug 47217] Adobe Lightroom 7.2, 7.5 and 8.1 with GPU Acceleration enabled crash when opening import module (d2d_effect_GetValue is a stub)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47217

--- Comment #4 from Jactry Zeng  ---
d2d_effect_GetValue() was implemented by commit
77930f1fe2544eb24390e9f8be3ab9a1a633ca70, I think it would be worth retesting
this with the current Wine again.

[Bug 47217] Adobe Lightroom 7.2, 7.5 and 8.1 with GPU Acceleration enabled crash when opening import module (d2d_effect_GetValue is a stub)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47217

Tomáš Bžatek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ABANDONED
             Status|NEW                         |RESOLVED

--- Comment #5 from Tomáš Bžatek  ---
Recent Lightroom versions have changed GPU handling and I'm not seeing this
problem anymore. However, there are lots of new crashes, I'll be opening
bugreports for those.

I have no way to retest this with the old Lightroom version, I guess this can
be closed.

[Bug 47217] Adobe Lightroom 7.2, 7.5 and 8.1 with GPU Acceleration enabled crash when opening import module (d2d_effect_GetValue is a stub)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47217

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Austin English  ---
Closing.