https://bugs.winehq.org/show_bug.cgi?id=51327
Bug ID: 51327 Summary: GdipCreateFont initializes font with ANSI_CHARSET Product: Wine Version: 6.11 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: gdiplus Assignee: wine-bugs@winehq.org Reporter: galtgendo@o2.pl Distribution: ---
I'm not sure whether it's a bug or not, but wouldn't DEFAULT_CHARSET be a more proper initial value for the charset field ?
Depending on locale, these two may differ.
https://bugs.winehq.org/show_bug.cgi?id=51327
Esme Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=51327
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source
https://bugs.winehq.org/show_bug.cgi?id=51327
Bartosz gang65@poczta.onet.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gang65@poczta.onet.pl
https://bugs.winehq.org/show_bug.cgi?id=51327
--- Comment #1 from Bartosz gang65@poczta.onet.pl --- The function is implemented here: https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/gdiplus/font.c?ref_ty...
more information: https://learn.microsoft.com/en-us/windows/win32/api/gdiplusheaders/nf-gdiplu...)
https://bugs.winehq.org/show_bug.cgi?id=51327
--- Comment #2 from Bartosz gang65@poczta.onet.pl --- According to documentation, default charset is LANG_NEUTRAL: https://learn.microsoft.com/en-us/windows/win32/api/gdiplusheaders/nf-gdiplu...
Could you explain where it is set to ANSI_CHARSET?
https://bugs.winehq.org/show_bug.cgi?id=51327
--- Comment #3 from Rafał Mużyło galtgendo@o2.pl --- Well, obviously in this line:
memset(&lfw, 0, sizeof(lfw));
- quirk of enum values.
https://bugs.winehq.org/show_bug.cgi?id=51327
--- Comment #4 from Rafał Mużyło galtgendo@o2.pl --- Note, that currently in wine
GdipGetFamilyName(fontFamily, lfw.lfFaceName, LANG_NEUTRAL);
is pretty much a no-op wrt. last arg.
https://bugs.winehq.org/show_bug.cgi?id=51327
--- Comment #5 from Rafał Mużyło galtgendo@o2.pl --- Also, on a semi-random note, it seems update_font_code_page in win32u was written based upon how things are supposed to work, not how they actually work in wine (bugs like my bug 42606 might be a result of that).
Just sticking with CP_ACP would likely be more consistent.
https://bugs.winehq.org/show_bug.cgi?id=51327
--- Comment #6 from Bartosz gang65@poczta.onet.pl --- GdipGetFamilyName doesn't support different languages:
https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/gdiplus/font.c#L798
https://bugs.winehq.org/show_bug.cgi?id=51327
--- Comment #7 from Rafał Mużyło galtgendo@o2.pl --- Indeed. I never said it did, just making sure *you* knew it didn't.
https://bugs.winehq.org/show_bug.cgi?id=51327
Jeff Smith whydoubt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |whydoubt@gmail.com
--- Comment #8 from Jeff Smith whydoubt@gmail.com --- The behavior was changed with this commit: https://gitlab.winehq.org/wine/wine/-/commit/a51c15ff720f414fe383b62a3047a42...
This bug item should now be closed.
https://bugs.winehq.org/show_bug.cgi?id=51327
Esme Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |a51c15ff720f414fe383b62a304 | |7a4208d489bb8 Status|UNCONFIRMED |RESOLVED
--- Comment #9 from Esme Povirk madewokherd@gmail.com --- Reported fixed.
https://bugs.winehq.org/show_bug.cgi?id=51327
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #10 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 8.17.