[Bug 15638] New: Adobe Photoshop CS4 installer crashes on unimplemented GetProductInfo if run in Vista mode
http://bugs.winehq.org/show_bug.cgi?id=15638
Summary: Adobe Photoshop CS4 installer crashes on unimplemented GetProductInfo if run in Vista mode Product: Wine Version: 1.1.6 Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: kernel32 AssignedTo: wine-bugs@winehq.org ReportedBy: dank@kegel.com
GetProductInfo is a new kernel32 function in vista.
If you try to install Photoshop CS4 with wine in vista mode, the installer does a GetProcAddress on GetProductInfo and promptly crashes because the function isn't there.
http://bugs.winehq.org/show_bug.cgi?id=15638
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Installer
http://bugs.winehq.org/show_bug.cgi?id=15638
--- Comment #1 from Alexander Nicolaysen Sørnes alex@thehandofagony.com 2008-10-16 17:04:31 --- Created an attachment (id=16687) --> (http://bugs.winehq.org/attachment.cgi?id=16687) Proposed patch
Does the following patch work? I'll add the defines before sending it in
http://bugs.winehq.org/show_bug.cgi?id=15638
--- Comment #2 from Dan Kegel dank@kegel.com 2008-10-16 19:28:02 --- Nope, doesn't seem to help.
fixme:ver:GetProductInfo (6,0,0,0,0x32f908): stub wine: Unhandled page fault on write access to 0x0000007c at address 0x45c068 (thread 000b), starting debugger...
Can't tell why, though. Unlike before, now it continues through this problem when +relay is set. Perhaps the problem is now elsewhere, can't say.
http://bugs.winehq.org/show_bug.cgi?id=15638
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=15638
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net
--- Comment #3 from Anastasius Focht focht@gmx.net 2008-10-17 09:01:55 --- Hello,
the problem is most likely the missing 'WINAPI'. Omitting stdcall will imbalance the stack because the app expects the callee to clean up.
Regards
http://bugs.winehq.org/show_bug.cgi?id=15638
--- Comment #4 from Dan Kegel dank@kegel.com 2008-10-17 10:23:55 --- Indeed, adding the missing WINAPI makes the stub work, and cs4's installer continues.
AF, Schutzengel alle Wineentwickler :-)
http://bugs.winehq.org/show_bug.cgi?id=15638
Julian W. Speedator@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |Speedator@gmx.de
http://bugs.winehq.org/show_bug.cgi?id=15638
--- Comment #5 from Ken Sharp kennybobs@o2.co.uk 2009-06-10 11:01:17 --- Was a patch ever sent/accepted for this?
http://bugs.winehq.org/show_bug.cgi?id=15638
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kennybobs@o2.co.uk
http://bugs.winehq.org/show_bug.cgi?id=15638
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://trials.adobe.com/App | |lications/Photoshop/CS4/Win | |/ADBEPHSPCS4_LS1.7z
--- Comment #6 from Ken Sharp kennybobs@o2.co.uk 2009-06-13 14:57:59 --- Still unimplemented. Alexander, any chance you can send your patch with the WINAPI included?
http://bugs.winehq.org/show_bug.cgi?id=15638
Alexander Nicolaysen Sørnes alex@thehandofagony.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alex@thehandofagony.com
--- Comment #7 from Alexander Nicolaysen Sørnes alex@thehandofagony.com 2009-06-22 08:38:41 --- I thought attaching a patch would add me to the CC list, but apparently not.
I'll send the patch quite soon.
http://bugs.winehq.org/show_bug.cgi?id=15638
--- Comment #8 from Alexander Nicolaysen Sørnes alex@thehandofagony.com 2009-06-26 12:19:59 --- I sent a patch yesterday, but it hasn't been applied yet.
http://bugs.winehq.org/show_bug.cgi?id=15638
--- Comment #9 from Nikolay Sivov bunglehead@gmail.com 2009-10-11 15:06:10 --- Hi, Alexander.
You patch needs some cleanup (including fix for calling convention of course). First of all it isn't allowed to use cpp comment style, you should also add a bunch of defines to winnt.h to avoid use of magic numbers. Do you plan to resend? or I can do it if you don't mind.
http://bugs.winehq.org/show_bug.cgi?id=15638
--- Comment #10 from Alexander Nicolaysen Sørnes alex@thehandofagony.com 2009-10-11 15:59:57 --- I've been meaning to make an updated version of the patch, but I sort of forgot it.
I think I can have a new patch ready in a few days. By the way, here is the version I sent in June, which includes the proper defines (although in the wrong place):
http://www.winehq.org/pipermail/wine-patches/2009-June/074908.html http://www.winehq.org/pipermail/wine-patches/2009-June/074909.html
http://bugs.winehq.org/show_bug.cgi?id=15638
--- Comment #11 from Alexander Nicolaysen Sørnes alex@thehandofagony.com 2009-10-25 09:28:33 --- I've sent a new patch set
http://bugs.winehq.org/show_bug.cgi?id=15638
--- Comment #12 from Alexander Nicolaysen Sørnes alex@thehandofagony.com 2009-10-26 10:43:18 --- The patch series was committed today. Can anyone confirm that it works now?
http://bugs.winehq.org/show_bug.cgi?id=15638
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20492
http://bugs.winehq.org/show_bug.cgi?id=15638
--- Comment #13 from Ken Sharp kennybobs@o2.co.uk 2009-10-27 14:38:52 --- Blocked by Bug 20492, unless someone can work around it.
http://bugs.winehq.org/show_bug.cgi?id=15638
--- Comment #14 from Austin English austinenglish@gmail.com 2009-10-27 14:49:35 --- (In reply to comment #13)
Blocked by Bug 20492, unless someone can work around it.
Native jscript should work around that.
http://bugs.winehq.org/show_bug.cgi?id=15638
--- Comment #15 from Ken Sharp kennybobs@o2.co.uk 2009-10-27 16:21:07 --- Forgot about natives! Anyway, native jscript causes a page fault, unfortunately.
http://bugs.winehq.org/show_bug.cgi?id=15638
Bug 15638 depends on bug 20492, which changed state.
Bug 20492 Summary: Adobe CS4 installer hangs in memory and has to be killed http://bugs.winehq.org/show_bug.cgi?id=20492
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
http://bugs.winehq.org/show_bug.cgi?id=15638
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #16 from Ken Sharp kennybobs@o2.co.uk 2009-12-08 08:55:11 --- Fixed in latest git.
http://bugs.winehq.org/show_bug.cgi?id=15638
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #17 from Alexandre Julliard julliard@winehq.org 2009-12-18 13:07:19 --- Closing bugs fixed in 1.1.35.
http://bugs.winehq.org/show_bug.cgi?id=15638
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |fca16bc519f55f5c2703b1054d6 | |c5fd8ad9a1871 Hardware|Other |x86 OS|other |Linux
-
wine-bugs＠winehq.org