[Bug 51770] New: digikam-7.1.0 freezes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51770

Bug ID: 51770
           Summary: digikam-7.1.0 freezes on start
           Product: Wine
           Version: 6.17
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Steps to reproduce:

1) Run
2) Click Next, Next, Next, Next, Next
3) It freezes

If you attempt to start it again, it just freezes without showing anything.

[Bug 51770] digikam-7.1.0 freezes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51770

Artem S. Tashkinov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://download.kde.org/At
                   |                            |tic/digikam/7.1.0/digiKam-7
                   |                            |.1.0-Win32.tar.xz
           Keywords|                            |download, source

[Bug 51770] digikam-7.1.0 freezes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51770

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Bernhard Übelacker  ---
I could reproduce the issue and digikam.exe does a DeviceIoControl
with IOCTL_STORAGE_GET_DEVICE_NUMBER.
This call is done with in_buff=NULL correctly, but incorrectly in_count=4.

Therefore the request in server_ioctl_file to wineserver is not sent,
but yet the wait_async is called, which unfortunately not returns.

The submitted patch avoids requests to wineserver with null pointer but
invalid size. With this digikam opens and looks usable.

[1]
https://github.com/KDE/solid/blob/6a2fe937420347178184d708c89baf03cd41f2e4/s...

[2] https://www.winehq.org/pipermail/wine-devel/2021-December/202913.html

[Bug 51770] digikam-7.1.0 freezes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51770

--- Comment #2 from Bernhard Übelacker  ---
Short addition:
In #47521 for digikam 6.10 I could observe the same hang.
But found, at least there, one can get over it by just
pressing enter in the console window that started digikam.exe.

[Bug 51770] digikam-7.1.0 freezes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51770

--- Comment #3 from Artem S. Tashkinov  ---
(In reply to Bernhard Übelacker from comment #2)
> Short addition:
> In #47521 for digikam 6.10 I could observe the same hang.
> But found, at least there, one can get over it by just
> pressing enter in the console window that started digikam.exe.

I'm curious why your patch hasn't seemingly been merged.

[Bug 51770] digikam-7.1.0 freezes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51770

--- Comment #4 from Bernhard Übelacker  ---
> I'm curious why your patch hasn't seemingly been merged.

Sadly it fell of the patches list without comments,
maybe it was considered too risky before the wine release ...

I resubmitted now:
https://www.winehq.org/pipermail/wine-devel/2022-April/213866.html

[Bug 51770] digikam-7.1.0 freezes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51770

--- Comment #5 from Bernhard Übelacker  ---
Submitted again:
https://gitlab.winehq.org/wine/wine/-/merge_requests/3007

[Bug 51770] digikam-7.1.0 freezes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51770

--- Comment #6 from Bernhard Übelacker  ---
Created attachment 75984
  --> https://bugs.winehq.org/attachment.cgi?id=75984
fixing-commit-search.txt

I cannot observe this hang after this commit:
commit 4b63e888945b8ada2ddc043e435b9358a0be811c
Author: Eric Pouech 
Date:   Fri Nov 17 11:54:18 2023 +0100

ntdll: Don't create Unix console for GUI apps.

Note: GUI apps using std I/O (this is not common) will
    no longer print on unix console.
    If such a behavior is needed, for an app started from
    Unix shell, one can either redirect output to a file, or pipe output:
    ./wine app | cat

Signed-off-by: Eric Pouech

The first release which contains this commit is wine-9.0-rc1.

Therefore I think this bug can be resolved fixed?

[Bug 51770] digikam-7.1.0 freezes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51770

Artem S. Tashkinov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #7 from Artem S. Tashkinov  ---
Confirming fixed.

[Bug 51770] digikam-7.1.0 freezes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51770

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |4b63e888945b8ada2ddc043e435
                   |                            |b9358a0be811c

[Bug 51770] digikam-7.1.0 freezes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51770

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  ---
Closing bugs fixed in 9.2.