[Bug 43057] New: Final Fantasy XIV DX9 Creates an invalid GLSL shader

https://bugs.winehq.org/show_bug.cgi?id=43057

Bug ID: 43057
           Summary: Final Fantasy XIV DX9 Creates an invalid GLSL shader
           Product: Wine
           Version: 2.8
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3dx9
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ArchLinux

Created attachment 58225
  --> https://bugs.winehq.org/attachment.cgi?id=58225
section of debug output

The D3DX9-to-OpenGL process appears to create a shader that fails to compile.
The responsible error appears to be logged at the final line of the attached
debug log, and additionally appeared throughout the original debug output
(which was over 2mb in size and could not be uploaded in whole):

fixme:d3d_shader:print_glsl_info_log     error: Input block `shader_in_out' is
not an output of the previous stage

This bug results in ugly visuals on the main menu, and causes no visuals to
display when in the main game.

[Bug 43057] Final Fantasy XIV DX9 Creates an invalid GLSL shader

https://bugs.winehq.org/show_bug.cgi?id=43057

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|directx-d3dx9               |directx-d3d
                 CC|                            |[e-mail]
     Ever confirmed|0                           |1

--- Comment #1 from Józef Kucia  ---
(In reply to Isaac Witherspoon from comment #0)
> The D3DX9-to-OpenGL process appears to create a shader that fails to
> compile. The responsible error appears to be logged at the final line of the
> attached debug log, and additionally appeared throughout the original debug
> output (which was over 2mb in size and could not be uploaded in whole):

You can compress logs before uploading them.
> fixme:d3d_shader:print_glsl_info_log     error: Input block `shader_in_out'
> is not an output of the previous stage

What is your GPU/driver/version?

[Bug 43057] Final Fantasy XIV DX9 Creates an invalid GLSL shader

https://bugs.winehq.org/show_bug.cgi?id=43057

--- Comment #2 from Isaac Witherspoon  ---
> What is your GPU/driver/version?

AMD RX 470 using Mesa 17.2.0-devel (git-f52e63069a)

Let me guess, this is actually an issue on my end?

[Bug 43057] Final Fantasy XIV DX9 Creates an invalid GLSL shader

https://bugs.winehq.org/show_bug.cgi?id=43057

--- Comment #3 from Józef Kucia  ---
(In reply to Isaac Witherspoon from comment #2)
> > What is your GPU/driver/version?
>
> AMD RX 470 using Mesa 17.2.0-devel (git-f52e63069a)
>
> Let me guess, this is actually an issue on my end?

This appears to be a Mesa bug. I'll report the problem to Mesa after more
investigation. For now, you can unset MaxGLVersion to workaround this problem.

[Bug 43057] Final Fantasy XIV DX9 Creates an invalid GLSL shader

https://bugs.winehq.org/show_bug.cgi?id=43057

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 43057] Final Fantasy XIV DX9 Creates an invalid GLSL shader

https://bugs.winehq.org/show_bug.cgi?id=43057

Isaac Witherspoon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOTOURBUG
             Status|NEW                         |RESOLVED

--- Comment #4 from Isaac Witherspoon  ---
> For now, you can unset MaxGLVersion to workaround this problem.

Checked, this is a functioning workaround and the visuals are now functional
again, with no GLSL compilation errors appearing in debug output.

Since this isn't an issue with Wine itself, and it only appears with a
non-default registry entry, I'll change this to resolved.

[Bug 43057] Final Fantasy XIV DX9 Creates an invalid GLSL shader

https://bugs.winehq.org/show_bug.cgi?id=43057

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Józef Kucia  ---
*** Bug 43101 has been marked as a duplicate of this bug. ***

[Bug 43057] Mesa fails to link GLSL shaders generated for SM3 shaders when core contexts are enabled

https://bugs.winehq.org/show_bug.cgi?id=43057

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Final Fantasy XIV DX9       |Mesa fails to link GLSL
                   |Creates an invalid GLSL     |shaders generated for SM3
                   |shader                      |shaders when core contexts
                   |                            |are enabled

[Bug 43057] Mesa fails to link some GLSL shaders generated for SM3 shaders when core contexts are enabled

https://bugs.winehq.org/show_bug.cgi?id=43057

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Mesa fails to link GLSL     |Mesa fails to link some
                   |shaders generated for SM3   |GLSL shaders generated for
                   |shaders when core contexts  |SM3 shaders when core
                   |are enabled                 |contexts are enabled

[Bug 43057] Mesa fails to link some GLSL shaders generated for SM3 shaders when core contexts are enabled

https://bugs.winehq.org/show_bug.cgi?id=43057

--- Comment #6 from Józef Kucia  ---
Created attachment 58311
  --> https://bugs.winehq.org/attachment.cgi?id=58311
Workaround

It would be interesting to know if the attached patch fixes the issue. It's a
possible workaround for the Mesa bug.

[Bug 43057] Mesa fails to link some GLSL shaders generated for SM3 shaders when core contexts are enabled

https://bugs.winehq.org/show_bug.cgi?id=43057

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]      |[e-mail]
           See Also|                            |https://bugs.freedesktop.or
                   |                            |g/show_bug.cgi?id=101247

[Bug 43057] Mesa fails to link some GLSL shaders generated for SM3 shaders when core contexts are enabled

https://bugs.winehq.org/show_bug.cgi?id=43057

--- Comment #7 from Isaac Witherspoon  ---
(In reply to Józef Kucia from comment #6)
> Created attachment 58311 [details]
> Workaround
>
> It would be interesting to know if the attached patch fixes the issue. It's
> a possible workaround for the Mesa bug.

Compiled Wine 2.9-staging with patch applied after staging. With both unset
MaxGLVersion and MaxGLVersion set to 4.5 core context, FFXIV DX9 renders as
expected, and there are no shader link errors appearing in the debug logs.
Looks good.

[Bug 43057] Mesa fails to link some GLSL shaders generated for SM3 shaders when core contexts are enabled

https://bugs.winehq.org/show_bug.cgi?id=43057

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Józef Kucia  ---
*** Bug 43144 has been marked as a duplicate of this bug. ***

[Bug 43057] Mesa fails to link some GLSL shaders generated for SM3 shaders when core contexts are enabled

https://bugs.winehq.org/show_bug.cgi?id=43057

--- Comment #9 from Henri Verbeet  ---
(In reply to Józef Kucia from comment #6)
> It would be interesting to know if the attached patch fixes the issue. It's
> a possible workaround for the Mesa bug.

For what it's worth, we'll want to make sure the Mesa bug gets fixed of course,
but the patch seems legitimate enough.

[Bug 43057] Mesa fails to link some GLSL shaders generated for SM3 shaders when core contexts are enabled

https://bugs.winehq.org/show_bug.cgi?id=43057

--- Comment #10 from Józef Kucia  ---
(In reply to Henri Verbeet from comment #9)
> (In reply to Józef Kucia from comment #6)
> > It would be interesting to know if the attached patch fixes the issue. It's
> > a possible workaround for the Mesa bug.
>
> For what it's worth, we'll want to make sure the Mesa bug gets fixed of
> course, but the patch seems legitimate enough.

Sure, I've submitted a bug report and a piglit test for the problem. I don't
plan to work on the fix myself though.

[Bug 43057] Mesa fails to link some GLSL shaders generated for SM3 shaders when core contexts are enabled

https://bugs.winehq.org/show_bug.cgi?id=43057

--- Comment #11 from Matteo Bruni  ---
*** Bug 43144 has been marked as a duplicate of this bug. ***

[Bug 43057] Mesa fails to link some GLSL shaders generated for SM3 shaders when core contexts are enabled

https://bugs.winehq.org/show_bug.cgi?id=43057

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Austin English  ---
Closing.

[Bug 43057] Mesa fails to link some GLSL shaders generated for SM3 shaders when core contexts are enabled

https://bugs.winehq.org/show_bug.cgi?id=43057

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |RESOLVED

--- Comment #13 from Austin English  ---
This was inadvertently caught up in my unclosed bugs filter. NOTOURBUG should
only be closed when fixed upstream.

Setting back to RESOLVED NOTOURBUG.

Sorry for the spam.

[Bug 43057] Mesa fails to link some GLSL shaders generated for SM3 shaders when core contexts are enabled

https://bugs.winehq.org/show_bug.cgi?id=43057

Matteo Bruni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Matteo Bruni  ---
Fixed in Mesa 18.1.8 / 18.2.0.