[Bug 33456] New: D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

List overview All Threads

newer

older

[Bug 38558] New: cmd.exe bundled...

[Bug 26653] New: Function VarRound...

wine-bugs＠winehq.org

25 Apr 2013 25 Apr '13

6:53 a.m.

http://bugs.winehq.org/show_bug.cgi?id=33456

Bug #: 33456 Summary: D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used Product: Wine Version: unspecified Platform: x86 OS/Version: Linux Status: NEW Keywords: testcase Severity: normal Priority: P2 Component: directx-d3dx9 AssignedTo: wine-bugs@winehq.org ReportedBy: kgbricola@web.de CC: wine-bugs@winehq.org Classification: Unclassified

Created attachment 44286 --> http://bugs.winehq.org/attachment.cgi?id=44286 D3DXMatrixTransformation test case - 22 failed tests

While trying to improve the speed of D3DXMatrixTransformation(), I found that the calculation when using scalingrotation and scaling at the same time is wrong.

The full formula is (according to msdn): Mout = (Msc)-1 * (Msr)-1 * Ms * Msr * Msc * (Mrc)-1 * Mr * Mrc * Mt while the failing part is: (Msr)-1 * Ms * Msr

So this might not be the correct equivalent: ... D3DXMatrixRotationQuaternion(&m4, pscalingrotation); //Msr D3DXMatrixInverse(&m2, NULL, &m4); //Msr-1 D3DXMatrixScaling(&m3, pscaling->x, pscaling->y, pscaling->z); //Ms ... D3DXMatrixMultiply(&m1, &m1, &m2); D3DXMatrixMultiply(&m1, &m1, &m3); D3DXMatrixMultiply(&m1, &m1, &m4); ...

This may affect other functions as well (e.g. D3DXMatrixTransformation2D()).

-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

Show replies by date

wine-bugs＠winehq.org

23 Feb 23 Feb

6:30 a.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

--- Comment #1 from Austin English austinenglish@gmail.com --- This is your friendly reminder that there has been no bug activity for over a year. Is this still an issue in current (1.7.37 or newer) wine? If so, please attach the terminal output in 1.7.37 (see http://wiki.winehq.org/FAQ#get_log).

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

25 Jun 25 Jun

12:10 p.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

joaopa jeremielapuree@yahoo.fr changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree@yahoo.fr

--- Comment #2 from joaopa jeremielapuree@yahoo.fr --- Bug still there in current wine

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

16 Mar 16 Mar

3:41 a.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

17 Mar 17 Mar

6:27 a.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

Paul Gofman gofmanp@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |gofmanp@gmail.com

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

19 Mar 19 Mar

7:28 p.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

--- Comment #3 from joaopa jeremielapuree@yahoo.fr --- Created attachment 53994 --> https://bugs.winehq.org/attachment.cgi?id=53994 Fix for D3DXMatrixTransformation

This patches fixes the Rico's tests and a bunch of new added tests.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

19 Apr 19 Apr

11:10 p.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair@hotmail.com

--- Comment #4 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- (In reply to joaopa from comment #3)

...

Created attachment 53994 [details] Fix for D3DXMatrixTransformation

This patches fixes the Rico's tests and a bunch of new added tests.

Was this patch ever sent to wine-patches?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

11:45 p.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

--- Comment #5 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- All test pass. http://testbot.winehq.org/JobDetails.pl?Key=22350

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

20 Apr 20 Apr

2:56 a.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

--- Comment #6 from joaopa jeremielapuree@yahoo.fr ---

...

Was this patch ever sent to wine-patches?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

4 Feb 4 Feb

2:25 a.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

--- Comment #7 from joaopa jeremielapuree@yahoo.fr --- Bug still there in current wine

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

23 Oct 23 Oct

6:26 a.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

--- Comment #8 from joaopa jeremielapuree@yahoo.fr --- Bug still there in current wine.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

25 Oct 25 Oct

11:56 a.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

--- Comment #9 from Gijs Vermeulen gijsvrm@gmail.com --- (In reply to joaopa from comment #8)

Would you consider sending your patch to wine-devel? Or maybe it could be considered for addition in staging?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

9 Nov 9 Nov

2:41 a.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

joaopa jeremielapuree@yahoo.fr changed:

--- Comment #10 from joaopa jeremielapuree@yahoo.fr --- Created attachment 62754 --> https://bugs.winehq.org/attachment.cgi?id=62754 Updated patch

Patch was sent to wine-devel. But it does not appear in listing of submitted patches. So attaching it here to not lose it.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

13 Nov 13 Nov

11:31 p.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

26 Jan 26 Jan

7:12 a.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

--- Comment #11 from joaopa jeremielapuree@yahoo.fr --- Matteo's patch is in GIT. Can an administrator close this bug as FIXED?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

7:36 a.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:

--- Comment #12 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Fixed by https://source.winehq.org/git/wine.git/?a=commit;h=f54260a789387ab40de3d8029...

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

4 Feb 4 Feb

7:30 p.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

Alexandre Julliard julliard@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #13 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 4.1.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

7 Apr 7 Apr

7:58 p.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

Michael Stefaniuc mstefani@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |4.0.x

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

15 May 15 May

8:03 p.m.

New subject: [Bug 33456] D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used

https://bugs.winehq.org/show_bug.cgi?id=33456

Michael Stefaniuc mstefani@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.0.x |---

--- Comment #14 from Michael Stefaniuc mstefani@winehq.org --- Removing the 4.0.x milestone from bug fixes included in 4.0.1.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

2072

Age (days ago)

4283

Last active (days ago)

wine-bugs@winehq.org

18 comments

1 participants

tags (0)

participants (1)

wine-bugs＠winehq.org