[Bug 29883] New: Game created with RPG Tkool VX Ace (Japanese version of RPG Maker VX Ace): can not write save data (Save*.rvdata2)

http://bugs.winehq.org/show_bug.cgi?id=29883

Bug #: 29883
           Summary: Game created with RPG Tkool VX Ace (Japanese version
                    of RPG Maker VX Ace): can not write save data
                    (Save*.rvdata2)
           Product: Wine
           Version: 1.4-rc3
          Platform: x86-64
               URL: http://tkool.jp/products/rpgvxace/
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: kernel32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified
   Regression SHA1: f67b0377abd491bfe4cc2713ee644119a3e00218

"Save" function does not work. Loading data works fine.

Steps to reproduce:
1. Download sample game from "www.famitsu.com/freegame/vxace/0001.html"
   (Note: RTP is not needed to play the game)
2. Extract files from Notbrave2.exe (run it or use cabextract)
3. Run Game.exe
4. Select "ニューゲーム (New game)"
5. After starting the game, open menu
6. Select "セーブ (Save)"
7. Choose file number -> FAIL

Result of regression test:
f67b0377abd491bfe4cc2713ee644119a3e00218 is the first bad commit
commit f67b0377abd491bfe4cc2713ee644119a3e00218
Author: Eric Pouech 
Date:   Sun Nov 7 19:14:46 2010 +0100

kernel32: Use fd availability for testing whether a console handle refers
to a bare console.

:040000 040000 ba84ca5000322180567de19b120c0ed551a3ab3e
6bcfdb2687ebad0c64cfca17fb196787ca5e3be4 M      dlls

[Bug 29883] Game created with RPG Tkool VX Ace (Japanese version of RPG Maker VX Ace): can not write save data (Save*.rvdata2)

http://bugs.winehq.org/show_bug.cgi?id=29883

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

[Bug 29883] Game created with RPG Tkool VX Ace (Japanese version of RPG Maker VX Ace): can not write save data (Save*.rvdata2)

http://bugs.winehq.org/show_bug.cgi?id=29883

--- Comment #1 from Sagawa  2012-02-15 06:45:50 CST ---
Created attachment 38886
  --> http://bugs.winehq.org/attachment.cgi?id=38886
a patch for more console tests

I confirmed the problem. I found out that RPG Tkool VX Ace uses WriteConsole
before saving a file and it expects to be failed. Although this is strange, the
program works fine on Windows.

I made the attached patch to do more tests for console. It shows that
WriteConsole currently succeeds even if the handle is normal file handle (not
bare handle). Before the commit f67b0377abd491bfe4cc2713ee644119a3e00218, it
was an error in that case.

[Bug 29883] Game created with RPG Tkool VX Ace (Japanese version of RPG Maker VX Ace): can not write save data (Save*.rvdata2)

http://bugs.winehq.org/show_bug.cgi?id=29883

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sagawa.aki+winebugs@gmail.c
                   |                            |om

[Bug 29883] Game created with RPG Tkool VX Ace (Japanese version of RPG Maker VX Ace): can not write save data (Save*.rvdata2)

http://bugs.winehq.org/show_bug.cgi?id=29883

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 29883] Game created with RPG Tkool VX Ace (Japanese version of RPG Maker VX Ace): can not write save data (Save*.rvdata2)

http://bugs.winehq.org/show_bug.cgi?id=29883

Eric Pouech  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
         AssignedTo|[e-mail]        |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #2 from Eric Pouech  2012-02-16 14:33:08 CST ---
Created attachment 38914
  --> http://bugs.winehq.org/attachment.cgi?id=38914
tentative patch

the attached patch should fix this issue
can you test it ?
A+

[Bug 29883] Game created with RPG Tkool VX Ace (Japanese version of RPG Maker VX Ace): can not write save data (Save*.rvdata2)

http://bugs.winehq.org/show_bug.cgi?id=29883

--- Comment #3 from Sagawa  2012-02-17 03:43:18 CST ---
(In reply to comment #2)
> the attached patch should fix this issue
> can you test it ?

Great! It works fine in my environment. Thank you.
Should I send my previous patch to wine-patches?

[Bug 29883] Game created with RPG Tkool VX Ace (Japanese version of RPG Maker VX Ace): can not write save data (Save*.rvdata2)

http://bugs.winehq.org/show_bug.cgi?id=29883

--- Comment #4 from [e-mail] 2012-02-17 06:27:46 CST ---
It works fine for me too. Thanks for the fix.

[Bug 29883] Game created with RPG Tkool VX Ace (Japanese version of RPG Maker VX Ace): can not write save data (Save*.rvdata2)

http://bugs.winehq.org/show_bug.cgi?id=29883

--- Comment #5 from Eric Pouech  2012-02-17 14:57:05 CST ---
you can post your patch once mine is committed (otherwise the test will fail)
A+

[Bug 29883] Game created with RPG Tkool VX Ace (Japanese version of RPG Maker VX Ace): can not write save data (Save*.rvdata2)

http://bugs.winehq.org/show_bug.cgi?id=29883

Eric Pouech  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Eric Pouech  2012-02-25 09:52:17 CST ---
fixed in git
945e16c281fc8bc3d6ead7ba95b34b24af39d1d3

[Bug 29883] Game created with RPG Tkool VX Ace (Japanese version of RPG Maker VX Ace): can not write save data (Save*.rvdata2)

http://bugs.winehq.org/show_bug.cgi?id=29883

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |945e16c281fc8bc3d6ead7ba95b
                   |                            |34b24af39d1d3

[Bug 29883] Game created with RPG Tkool VX Ace (Japanese version of RPG Maker VX Ace): can not write save data (Save*.rvdata2)

http://bugs.winehq.org/show_bug.cgi?id=29883

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  2012-03-02 13:02:47 CST ---
Closing bugs fixed in 1.4-rc6.