[Bug 46148] New: In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

Bug ID: 46148
           Summary: In World of Warcraft 8 background and water are solid
                    color and flashes of various color appear many times
                    per second
           Product: Wine-staging
           Version: 3.20
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail]
      Distribution: ---

World of Warcraft 8.0.1 (28153)(Release x64)

OS is Ubuntu, both show the same symptoms and were fine before Wine 3.20
(Staging):

Linux kevin-desktop 4.15.0-39-generic #42~16.04.1-Ubuntu SMP Wed Oct 24
17:09:54 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
  Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz
  16GB
  Intel HD Graphics 4000 (Ivybridge) (on motherboard, no expansion slot)

Linux kgrittn-Precision-7720 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
  Intel(R) Xeon(R) CPU E3-1505M v6 @ 3.00GHz
  32GB RAM
  NVIDIA GeForce GTX 470

Symptoms in WoW:

- Backgrounds such as terrain show as a single color (always black?) with no
"litter" or detail -- a roadway looks the same as wild ground which is the same
as the side of a cliff.
- Water shows as a single block of color with no shorline features, reflection,
or transparency to underlying features.
- Random patches of color appear, apparently changing with each screen draw.
- Small animated areas like torch flames show lots of rectangle enclosing the
area with little or none of the normal animation.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

Kevin Grittner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Kevin Grittner  ---
Created attachment 62787
  --> https://bugs.winehq.org/attachment.cgi?id=62787
Scaled-down (to fit allowed attachment size) screenshot of WoW showing Wine bug

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #2 from Kevin Grittner  ---
Also, performance in WoW (the only use I make of Wine) is far worse after
updating to Wine 3.20 (Staging) from the previous Wine version.  This is
especially noticeable on the i7 with the Ivybridge graphics, where it can take
many seconds for a keystroke or mouse movement to have any visible affect.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #3 from Zebediah Figura  ---
Well, it'd be nice to know if this is a Staging bug or a regression in upstream
Wine. As far as I am aware WoW needs several Staging patches to run, but if
these are known then the most helpful thing to do would be to compile Staging
with only those patches, and check if the regression is still present.

Unless of course there is any intuition from the D3D developers as to what
might have changed.

(In reply to Kevin Grittner from comment #2)
> Also, performance in WoW (the only use I make of Wine) is far worse after
> updating to Wine 3.20 (Staging) from the previous Wine version.  This is
> especially noticeable on the i7 with the Ivybridge graphics, where it can
> take many seconds for a keystroke or mouse movement to have any visible
> affect.

I guess this should be filed as a separate bug, unless this seems likely to be
related.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #4 from Kevin Grittner  ---
(In reply to Zebediah Figura from comment #3)
> Well, it'd be nice to know if this is a Staging bug or a regression in
> upstream Wine. As far as I am aware WoW needs several Staging patches to
> run, but if these are known then the most helpful thing to do would be to
> compile Staging with only those patches, and check if the regression is
> still present.

I'm not clear on whether you are requesting that I try this, or suggesting to
the Wine developers.  I've never built Wine from source, so it might take a bit
to get set up for that.
> Unless of course there is any intuition from the D3D developers as to what
> might have changed.

I was hoping that someone would have some idea what changes in this Wine
Staging release might cause this.
> I guess this should be filed as a separate bug, unless this seems likely to
> be related.

I would give odds that the performance hit is the result of the graphics bug;
but I have no evidence other than the fact that they both appeared at the same
time so I may be making the classic error of jumping from correlation to an
assumption about causality without enough evidence.

Hopefully this staging release will be held back from GA until this is
resolved.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #5 from Zebediah Figura  ---
(In reply to Kevin Grittner from comment #4)
> (In reply to Zebediah Figura from comment #3)
> > Well, it'd be nice to know if this is a Staging bug or a regression in
> > upstream Wine. As far as I am aware WoW needs several Staging patches to
> > run, but if these are known then the most helpful thing to do would be to
> > compile Staging with only those patches, and check if the regression is
> > still present.
>
> I'm not clear on whether you are requesting that I try this, or suggesting
> to the Wine developers.  I've never built Wine from source, so it might take
> a bit to get set up for that.

Well, I certainly can't, as I don't have the game ;-)
> > Unless of course there is any intuition from the D3D developers as to what
> > might have changed.
>
> I was hoping that someone would have some idea what changes in this Wine
> Staging release might cause this.

If I did, I would have shared them. As things stand, we haven't really made any
modifications to d3d-related patches (or, IIRC, any patches?) that would have
caused this regression. On the other hand, we may have messed up a rebase
somewhere.

I think it's probably more likely that something was broken upstream, but I
have no intuition as to what that might be, as this seems to be a D3D bug and I
have not worked on that area. Hence my request for comment from the D3D
developers.
> Hopefully this staging release will be held back from GA until this is
> resolved.

I'm not sure what you mean by GA, but given the wide field of applications that
Wine (and by extension Wine-Staging) supports, we don't defer releases for a
regression in one of them.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #6 from Henri Verbeet  ---
(In reply to Zebediah Figura from comment #5)
> If I did, I would have shared them. As things stand, we haven't really made
> any modifications to d3d-related patches (or, IIRC, any patches?) that would
> have caused this regression. On the other hand, we may have messed up a
> rebase somewhere.

Alistair mentioned the rcp thing for SpinTires in the 3.20 announcement, which
I'd expect to have a performance impact, but not as severe as described here.
> I think it's probably more likely that something was broken upstream, but I
> have no intuition as to what that might be, as this seems to be a D3D bug
> and I have not worked on that area. Hence my request for comment from the
> D3D developers.

Sorry, nothing comes to mind. We did have a decent number of D3D patches in
wine-3.20, but they're more architectural than changing application visible
behaviour.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #7 from Zebediah Figura  ---
(In reply to Henri Verbeet from comment #6)
> (In reply to Zebediah Figura from comment #5)
> > If I did, I would have shared them. As things stand, we haven't really made
> > any modifications to d3d-related patches (or, IIRC, any patches?) that would
> > have caused this regression. On the other hand, we may have messed up a
> > rebase somewhere.
>
> Alistair mentioned the rcp thing for SpinTires in the 3.20 announcement,
> which I'd expect to have a performance impact, but not as severe as
> described here.

That's a good point, thanks. For lack of any better ideas, Kevin, can you
please try reverting that patch?

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #8 from Kevin Grittner  ---
(In reply to Zebediah Figura from comment #7)
> For lack of any better ideas, Kevin, can you please try reverting that patch?

How would I go about doing that?  The broken version was installed by following
the instructions on this page: https://wiki.winehq.org/Ubuntu -- which seems to
be:
> sudo dpkg --add-architecture i386
> wget -nc https://dl.winehq.org/wine-builds/Release.key
> sudo apt-key add Release.key
> sudo apt-add-repository https://dl.winehq.org/wine-builds/ubuntu/
> sudo apt-add-repository 'deb https://dl.winehq.org/wine-builds/ubuntu/ xenial main'
> sudo apt-get upgrade
> sudo apt-get update

I have never built Wine from source, and am unlikely to be able to do so soon. 
If there is an apt-get command to get a version without that patch, I'll
happily test that.  Or if someone can provide a build they want me to test,
with installation instructions, I can do that.  If I had clear build
instructions (including how to omit the patch in question) I could even give
that a shot; but I find the instructions on the web site to be a nearly
impenetrable maze of alternatives, with conditions for choosing a path and
instructions for what to do often using jargon that means nothing to me.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Severity|major                       |normal

--- Comment #9 from Olivier F. R. Dierick  ---
severity is not major.

Looks similar to bug 46141.

I have the game and would do a regression test, if only I could get past bug
42874 (Unable to update the game client).

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #10 from Kevin Grittner  ---
(In reply to Olivier F. R. Dierick from comment #9)
> severity is not major.

A definition of what qualifies for each level would be helpful.  To me, a
regression changing a program which has been "gold" for years to completely
unusable seemed more severe than "normal".  Is that really a normal thing to
have occur in a new release?
> Looks similar to bug 46141.

Possibly a different manifestation of the same bug.  As you can see from my
screenshot, though, there is a lot more than black and white in my case.
> I have the game and would do a regression test, if only I could get past bug
> 42874 (Unable to update the game client).

There have been times where I needed to completely delete the .wine directory
and start over with a fresh download of the launcher and game.  That takes a
few hours, but it can solve a lot of problems.  Currently I have to then use
the workaround of copying a cache directory from a Windows machine (which
people have uploaded) to get past the "stream" errors.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #11 from Kevin Grittner  ---
Since World of Warcraft is no longer playable on any machines available to me I
have canceled my subscription to it; so if there's any Wine version you would
like me to test in relation to this bug, it will have to be before November
21st, when the cancellation becomes effective.  I'll keep an eye on this bug
report until then.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

Anthony Jagers  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Anthony Jagers  ---
I'll just chime in with problem that I have been having with release 3.20.
The steam client is currently borked with 3.20.  I get steams  login dialog
box. After typing in my password, nothing appears. The wine server just quits
as well. I took the liberty to bisect and came up with a commit. 
That commit only modifies  dlls/wined3d/surface.c. This seems related to
problem with WoW.  I'm thinking about creating a separate bug report. But, I'll
have to think about gathering some log output. I already tried +wined3d and
didn't get any meaningful output.

commit c130a028fcf61b57a63ded6ce0cdbed47df1e5bb (HEAD)
Author: Henri Verbeet 
Date:   Mon Oct 29 10:47:07 2018 +0330

wined3d: Don't bother trying to blit from discarded textures.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #13 from Henri Verbeet  ---
(In reply to Anthony Jagers from comment #12)
> I'll just chime in with problem that I have been having with release 3.20.
> The steam client is currently borked with 3.20.  I get steams  login dialog
> box. After typing in my password, nothing appears. The wine server just quits
> as well. I took the liberty to bisect and came up with a commit. 
> That commit only modifies  dlls/wined3d/surface.c. This seems related to
> problem with WoW.  I'm thinking about creating a separate bug report. But,
> I'll have to think about gathering some log output. I already tried +wined3d
> and didn't get any meaningful output.
>
> commit c130a028fcf61b57a63ded6ce0cdbed47df1e5bb (HEAD)
> Author: Henri Verbeet 
> Date:   Mon Oct 29 10:47:07 2018 +0330
> wined3d: Don't bother trying to blit from discarded textures.

If you simply remove the "return WINED3D_OK;" line introduced by that commit,
does that help?

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #14 from Anthony Jagers  ---
I commented out line 3121 for dlls/wined3d/surface.c to no effect.
Sorry.

P.S., I don't use lutris nor the staging patches. I currently use nvidia's
closed drivers at version 410.78. Perhaps you should try and load steam and see
what happens.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #15 from Zebediah Figura  ---
(In reply to Anthony Jagers from comment #14)
> P.S., I don't use lutris nor the staging patches. I currently use nvidia's
> closed drivers at version 410.78. Perhaps you should try and load steam and
> see what happens.

In that case I guess you're experiencing bug 45948. Staging has a patch
attached to that bug that will allow Steam to log in again.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #16 from Zebediah Figura  ---
Kevin, I'm sorry things are difficult for you. Rest assured they are difficult
for us too.
> I have never built Wine from source, and am unlikely to be able to do so
> soon.  If there is an apt-get command to get a version without that patch,
> I'll happily test that.  Or if someone can provide a build they want me to
> test, with installation instructions, I can do that.  If I had clear build
> instructions (including how to omit the patch in question) I could even give
> that a shot; but I find the instructions on the web site to be a nearly
> impenetrable maze of alternatives, with conditions for choosing a path and
> instructions for what to do often using jargon that means nothing to me.

Well, it'd be nice to know what in specific is difficult to understand about
the build instructions, rather than a generic "it's an impenetrable maze of
alternatives". I won't deny that they could use improvement, but, being on the
other side of all of the jargon, I don't really know how.

Staging build instructions exist here: https://wiki.winehq.org/Wine-Staging.
In this case you'd want to use the '--all -W wined3d-Improved_RCP_Support'
options to patchinstall.sh. Yes, these instructions more clearly could use
improvement (and visibility), but we only have so much time on our hands (and
we prefer to spend it developing).

Anyway, since this seems to be the easiest way we'll get through this, I've
compiled 32- and 64-bit wined3d.dll.so libraries with the RCP patch reverted:

http://www.cs.grinnell.edu/~figuraze/wined3d-bug-46148.tar.gz

Please try replacing your existing wined3d.dll.so with these (backing them up
first, I imagine, and replacing the -32/-64 extension as appropriate).
Hopefully this will work.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #17 from Zebediah Figura  ---
(In reply to Kevin Grittner from comment #10)
> (In reply to Olivier F. R. Dierick from comment #9)
> > severity is not major.
>
> A definition of what qualifies for each level would be helpful.  To me, a
> regression changing a program which has been "gold" for years to completely
> unusable seemed more severe than "normal".  Is that really a normal thing to
> have occur in a new release?

The definition you're looking for is listed on https://wiki.winehq.org/Bugs,
which should be linked from the "file a new bug" page. Specifically:
> *Major* for major loss of functionality for a wide range of applications

I won't pretend it's "normal" for a commit to break a popular application, but
it can happen, and because Wine supports a huge range of applications, we don't
really stop everything to deal with one. That's not to say that a regression
doesn't get special attention, though. Personally, as a developer, I'm much
more concerned with bugs tagged 'regression' than those tagged 'major', but
perhaps others differ.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

Vitalii Stoianov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vitalii.stoianov.ua@gmail.c
                   |                            |om

--- Comment #18 from Vitalii Stoianov  ---
Have same bug with WoW app after yesterday update of wine.

Also noticed that now in wine stdout I can see this error message:

0112:err:d3d:wined3d_debug_callback 0x17ec6020: "GL_INVALID_OPERATION in
glUseProgram(program 183 not linked)"

Replace of wined3d*.dll.so with attached in this thread didn't help.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #19 from Vitalii Stoianov  ---
While wow is not playable on winehq-staging=3.20 you still can play it on
winehq-staging=3.19.0~bionic

For that purpose I installed "aptitude" pkg as It has better dependencies
resolution than "apt-get" pkg and installed winehq-staging=3.19.0~bionic before
doing install I removed all previous version of wine that was installed on my
system. This solution works for me now game is playable again no issue with
textures.
> > sudo aptitude install winehq-staging=3.19.0~bionic

Also you can froze this pkg from updates till they fix winehg-staging to work
with wow in future versions.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW

--- Comment #20 from Józef Kucia  ---
The "wined3d-Improved-RCP_Support" patch from staging breaks WoW shaders.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #21 from Kevin Grittner  ---
Created attachment 62819
  --> https://bugs.winehq.org/attachment.cgi?id=62819
Attempt to revert version to 3.19 using aptitude

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #22 from Kevin Grittner  ---
(In reply to Vitalii Stoianov from comment #19)
> sudo aptitude install winehq-staging=3.19.0~bionic

Thanks, but I must be doing something wrong.  I uninstalled all wine packages
(using Synaptic Package Manager) and tried the above statement with the results
in the attachment I just added.

Any suggestions?

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #23 from Vitalii Stoianov  ---
(In reply to Kevin Grittner from comment #22)
> (In reply to Vitalii Stoianov from comment #19)
> > sudo aptitude install winehq-staging=3.19.0~bionic
>
> Thanks, but I must be doing something wrong.  I uninstalled all wine
> packages (using Synaptic Package Manager) and tried the above statement with
> the results in the attachment I just added.
>
> Any suggestions?

ok let me explain what is going on:
For winehq-staging=3.20~bionic system update installed all required pkgs that
maybe in conflict with versions that is required for version
winehq-staging=3.19~bionic.

So when you try to do same with apt-get install it will fail with broken
dependencies.
When you run aptitude it ask you if you want to get dependencies hell resolved
for you and to do so it suggest set of actions. If you ok with that actions
('y') it will remove all libs that is in conflict mainly because of
winehq-stage=3.20~bionic install and will install all required libs.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

Sveinar Søpler  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #24 from Sveinar Søpler  ---
I might be cussing in church by suggesting this in here.. But if you have no
idea, or any plans on compiling wine yourself, the best bet would be something
like lutris.

This lets you set up "bottles" that are your wineprefixes + choose from various
pre-compiled wine versions that do not touch the system wine version.

Easier than messing with the system version of wine atleast.
> From your earlier error message where you have :

Unable to find a version "3.19.0~bionic" for the package "winehq-staging"

And it seem to revert to ubuntu default repo and some old version breaking
stuff.

Perhaps try "sudo apt clean" and then "sudo apt update" before trying
"apt-cache madison winehq-staging"
Could be some crud in your package cache perhaps :)

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

--- Comment #25 from Zebediah Figura  ---
The RCP patch is disabled in version 3.21; please try again with Staging 3.21
release.

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

Kevin Grittner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #26 from Kevin Grittner  ---
Problem resolved in 3.21.

Thanks for the attention.  I tried the various suggested workaround, but could
not coax them into working for one reason or another.  Glad to see the fix!

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #27 from Gijs Vermeulen  ---
*** Bug 46204 has been marked as a duplicate of this bug. ***

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

Matteo Bruni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #28 from Matteo Bruni  ---
*** Bug 46141 has been marked as a duplicate of this bug. ***

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |e89028830ede3e0137f39264770
                   |                            |3be14996362b9

[Bug 46148] In World of Warcraft 8 background and water are solid color and flashes of various color appear many times per second

https://bugs.winehq.org/show_bug.cgi?id=46148

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #29 from Alistair Leslie-Hughes  ---
Closing Fixed Staging bugs.