http://bugs.winehq.org/show_bug.cgi?id=21379
Summary: File open dialog is extremely slow since wine 1.1.34 Product: Wine Version: 1.1.34 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: filejunkie@gmail.com
File open dialog becomes extremely slow in wine 1.1.34 (clicking "Open file" or "Save file" in applications hangs them for a long period of time which depends on file count in current directory). 1.1.35 and 1.1.36 have this bug, 1.1.33 does not.
http://bugs.winehq.org/show_bug.cgi?id=21379
Ilya "FileJunkie" Ershov filejunkie@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |filejunkie@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=21379
--- Comment #1 from Nikolay Sivov bunglehead@gmail.com 2010-01-15 14:25:38 --- Perform regression test then http://wiki.winehq.org/RegressionTesting.
http://bugs.winehq.org/show_bug.cgi?id=21379
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bunglehead@gmail.com Summary|File open dialog is |File open dialog is |extremely slow since wine |extremely slow |1.1.34 |
http://bugs.winehq.org/show_bug.cgi?id=21379
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|bunglehead@gmail.com, | |filejunkie@gmail.com |
http://bugs.winehq.org/show_bug.cgi?id=21379
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
http://bugs.winehq.org/show_bug.cgi?id=21379
Ilya "FileJunkie" Ershov filejunkie@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bunglehead@gmail.com Version|1.1.34 |1.1.35
--- Comment #2 from Ilya "FileJunkie" Ershov filejunkie@gmail.com 2010-01-15 15:56:18 --- Oops.. I was wrong, this bug appeared in 1.1.35. That is the buggy patch:
filejunkie@phenom ~/wine/wine-git $ git bisect good c2a7535e9d112989abe687255b4f0da9a597678e is the first bad commit commit c2a7535e9d112989abe687255b4f0da9a597678e Author: Nikolay Sivov bunglehead@gmail.com Date: Wed Dec 9 15:17:12 2009 +0300
comctl32/listview: Update item width every time new item is inserted.
This prevents retaining previously stored width and unexpected item displaying collapsing with ending ellipsis.
:040000 040000 fd7e8633a82910fc726cfc8f34341a4ebb07d485 9e27dcc9495c97276274e41ff236aa031a47b400 M dlls
http://bugs.winehq.org/show_bug.cgi?id=21379
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |comctl32
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com 2010-01-15 16:21:08 --- (In reply to comment #2)
commit c2a7535e9d112989abe687255b4f0da9a597678e Author: Nikolay Sivov bunglehead@gmail.com Date: Wed Dec 9 15:17:12 2009 +0300
comctl32/listview: Update item width every time new item is inserted. This prevents retaining previously stored width and unexpected item displaying collapsing with ending ellipsis.
Could be a cause indeed. With this patch a whole loop executed at each insert. I think a kind of marking item dimensions dirty (to delay recalculation when it's time to paint) could be a solution.
Did you try to revert it?
P.S. Using report mode should be faster actually.
http://bugs.winehq.org/show_bug.cgi?id=21379
--- Comment #4 from Ilya "FileJunkie" Ershov filejunkie@gmail.com 2010-01-15 23:31:35 --- Just tried. Reverting the patch helped bug to go away.
http://bugs.winehq.org/show_bug.cgi?id=21379
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|1.1.35 |1.1.34
--- Comment #5 from Dmitry Timoshkov dmitry@codeweavers.com 2010-01-18 22:21:31 --- Please don't change the reported Wine version.
http://bugs.winehq.org/show_bug.cgi?id=21379
sT331h0rs3@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #6 from sT331h0rs3@gmail.com 2010-01-20 06:32:43 --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=21379
sT331h0rs3@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sT331h0rs3@gmail.com
--- Comment #7 from sT331h0rs3@gmail.com 2010-01-20 06:36:50 --- Wine 1.1.36, hangs for unknown time when open/save dialog is used. Confirmed.
http://bugs.winehq.org/show_bug.cgi?id=21379
--- Comment #8 from Ilya "FileJunkie" Ershov filejunkie@gmail.com 2010-01-23 05:06:50 --- Still broken in 1.1.37.
http://bugs.winehq.org/show_bug.cgi?id=21379
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dimesio@earthlink.net
--- Comment #9 from Rosanne DiMesio dimesio@earthlink.net 2010-02-06 19:00:34 --- This also affects Word, Excel, and Powerpoint 2003 when trying to browse the clipart directory from Insert=>Picture=>From File. That has previously been the workaround for bug 14966, but it is no longer possible to do that, because the dialog hangs trying to open /drive_c/Program Files/Microsoft Office/CLIPART/PUB60COR. A regression test identified the patch listed in comment #2, and reverting it solves the problem.
Tested in 1.1.38.
http://bugs.winehq.org/show_bug.cgi?id=21379
--- Comment #10 from Nikolay Sivov bunglehead@gmail.com 2010-02-06 19:04:58 --- (In reply to comment #9)
This also affects Word, Excel, and Powerpoint 2003 when trying to browse the clipart directory from Insert=>Picture=>From File. That has previously been the workaround for bug 14966, but it is no longer possible to do that, because the dialog hangs trying to open /drive_c/Program Files/Microsoft Office/CLIPART/PUB60COR. A regression test identified the patch listed in comment #2, and reverting it solves the problem.
Tested in 1.1.38.
Ok. Will revert it, cause it apparently caused more trouble than solved. A patch to be sent next week, Monday.
http://bugs.winehq.org/show_bug.cgi?id=21379
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #11 from Nikolay Sivov bunglehead@gmail.com 2010-02-08 09:01:01 --- Patch sent:
http://www.winehq.org/pipermail/wine-patches/2010-February/084683.html
http://bugs.winehq.org/show_bug.cgi?id=21379
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #12 from Nikolay Sivov bunglehead@gmail.com 2010-02-08 11:21:32 --- Should be "fixed" by commit 057267d85e14b1954f5a6735a53a5287962a8a3c.
http://bugs.winehq.org/show_bug.cgi?id=21379
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #13 from Alexandre Julliard julliard@winehq.org 2010-02-19 12:32:26 --- Closing bugs fixed in 1.1.39.
http://bugs.winehq.org/show_bug.cgi?id=21379
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |057267d85e14b1954f5a6735a53 | |a5287962a8a3c Regression SHA1| |c2a7535e9d112989abe687255b4 | |f0da9a597678e