[Bug 10531] New: Windows Calculator: Color in buttons missing

Summary: Windows Calculator: Color in buttons missing Product: Wine Version: 0.9.49. Platform: Other OS/Version: other Status: UNCONFIRMED Severity: minor Priority: P2 Component: wine-misc AssignedTo: wine-bugs@winehq.org ReportedBy: bammzilla@gabriana.com

Created an attachment (id=9282) --> (http://bugs.winehq.org/attachment.cgi?id=9282) How it looks in my Windows XP box

In Windows Calculator CALC.EXE the button texts should be color coded but all appear black in Wine.

-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

Show replies by date

wine-bugs＠winehq.org

22 Nov 22 Nov

11:20 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #1 from Bamm Gabriana bammzilla@gabriana.com 2007-11-22 05:20:24 --- Created an attachment (id=9283) --> (http://bugs.winehq.org/attachment.cgi?id=9283) How it looks in Wine

Wine doesn't show colors in button text.

-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

wine-bugs＠winehq.org

7:56 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

Alexander Nicolaysen Sørnes alex@thehandofagony.com changed:

--- Comment #2 from Alexander Nicolaysen Sørnes alex@thehandofagony.com 2007-11-22 13:56:49 --- Confirming. Does not happen with win98se calc.

-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

wine-bugs＠winehq.org

6 Feb 6 Feb

2:31 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #3 from Andre Wisplinghoff andre.wisplinghoff@gmail.com 2008-02-06 08:31:32 --- Created an attachment (id=10636) --> (http://bugs.winehq.org/attachment.cgi?id=10636) Calc from Windows 98 without wine-drawn buttons

I commented out the PB_Paint function to test for owner-drawn Buttons. Calc from Win98 handels button painting itself, doesn't make a difference.

-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

wine-bugs＠winehq.org

2:34 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #4 from Andre Wisplinghoff andre.wisplinghoff@gmail.com 2008-02-06 08:34:31 --- Created an attachment (id=10637) --> (http://bugs.winehq.org/attachment.cgi?id=10637) Calc from XP withouth wine-drawn buttons

When trying XP calc with the same change, the buttons dissappear. I am not sure if there is a way to get colored buttons without drawing the button yourself? As far as I know this isn't possible in Windows GDI.

wine-bugs＠winehq.org

9:08 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

http://msdn2.microsoft.com/en-us/library/bb761847(VS.85).aspx http://msdn2.microsoft.com/en-us/library/bb761817(VS.85).aspx

Anastasius Focht focht@gmx.net changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net

--- Comment #5 from Anastasius Focht focht@gmx.net 2008-02-06 15:08:37 --- Hello,

well it's simple ... wine's button control lacks NM_CUSTOMDRAW notification support.

The BS_OWNERDRAWN style might have worked for Win9X but not for Windows XP - it's handled differently (assuming comctl32 ver >= 6). XP controls use WM_NOTIFY -> NM_CUSTOMDRAW notifications (sent to the parent) for that purpose. Use some windows/message spy to observe the behaviour (calc returns CDRF_SKIPDEFAULT to indicate it draws the entire item by itself).

See:

for further information.

Implement custom draw notification messages and you will coloured buttons.

Regards

wine-bugs＠winehq.org

9 Feb 9 Feb

11:49 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #6 from Bamm Gabriana bammzilla@gabriana.com 2008-02-09 05:49:47 ---

well it's simple ... wine's button control lacks NM_CUSTOMDRAW notification support.

Implement custom draw notification messages and you will coloured buttons.

May I know which dll I should copy over and set as native to have this NM_CUSTOMDRAW notification messages support?

wine-bugs＠winehq.org

12:41 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #7 from Anastasius Focht focht@gmx.net 2008-02-09 06:41:55 --- Hello,

although certain ui controls are implemented in comctl32.dll one cannot expect them to work exactly as in windows by just replacing builtin with native dll. If you replace one part you obviously need to replace other integral parts of wine too, which isn't feasible. The combination of builtin and native dlls doesn't resemble windows in all aspects, e.g. inter-module interactions might be different due to implementation details (call sequences, messages/order of messages sent and the like).

In short: there is no simple "native override" fix.

Regards

wine-bugs＠winehq.org

12 Feb 12 Feb

12:17 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

Andre Wisplinghoff andre.wisplinghoff@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |andre.wisplinghoff@gmail.com

--- Comment #8 from Andre Wisplinghoff andre.wisplinghoff@gmail.com 2008-02-11 18:17:23 --- Thanks a lot, Anastasius, I tried what you suggested and it's working. I'll try to make make up a nice patch (don't have that much experience yet.)

wine-bugs＠winehq.org

17 Feb 17 Feb

11:02 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #9 from Andre Wisplinghoff andre.wisplinghoff@gmail.com 2008-02-17 17:02:56 --- OK, I've got the patch ready, so far.

However in my opinion MSDN documentation isn't entirely correct. WinXP Calc sends CDRF_SKIPDEFAULT in response to the CDDS_PREPAINT notification. According to the documentation this means that the control should not do any drawing at all. But: I tried it like that and the result was, that there was colored text without the surroundings of buttons (frame etc).

So in my current implementation the button sends CDDS_PREPAINT after the frame was drawn, but before the label is drawn. If CDRF_SKIPDEFAULT is send in response, the label isn't drawn by the control.

If somebody has an explanation for this other than MSDN being incorrect, please let me know. Otherwise I'm going to send in the patch on Tuesday.

wine-bugs＠winehq.org

18 Feb 18 Feb

4:56 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #10 from Dmitry Timoshkov dmitry@codeweavers.com 2008-02-17 22:56:00 ---

So in my current implementation the button sends CDDS_PREPAINT after the frame was drawn, but before the label is drawn. If CDRF_SKIPDEFAULT is send in response, the label isn't drawn by the control.

There are 3 phases of painting: 1. non-client area (WM_NCPAINT) - caption, border 2. background (WM_ERASEBKGND) 3. client area (WM_PAINT)

You need to add a test case to dlls/user32/tests/msg.c to make sure that your patch is correct.

wine-bugs＠winehq.org

4:59 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #11 from Dmitry Timoshkov dmitry@codeweavers.com 2008-02-17 22:59:28 --- Also MSDN mentions that WM_NOTIFY/NM_CUSTOMDRAW notification is sent only to an application with appropriate manifest, and WM_DRAWITEM otherwise. So, manifests must be handled by your patch.

wine-bugs＠winehq.org

16 Jun 16 Jun

10:02 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #12 from Austin English austinenglish@gmail.com 2008-06-16 17:02:01 --- Is this still an issue in current (1.0-rc5 or newer) wine?

wine-bugs＠winehq.org

22 Jun 22 Jun

5:45 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #13 from Bamm Gabriana bammzilla@gabriana.com 2008-06-22 00:45:02 ---

Is this still an issue in current (1.0-rc5 or newer) wine?

Still present in Wine 1.0.

wine-bugs＠winehq.org

23 Dec 23 Dec

1:01 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #14 from Austin English austinenglish@gmail.com 2008-12-23 07:01:01 --- Is this still an issue in current (1.1.11 or newer) wine?

wine-bugs＠winehq.org

10 Feb 10 Feb

9:27 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

Dan Kegel dank@kegel.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com

--- Comment #15 from Dan Kegel dank@kegel.com 2009-02-10 03:27:45 --- Andre, did you say you had a patch?

wine-bugs＠winehq.org

11:59 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #16 from Andre Wisplinghoff andre.wisplinghoff@gmail.com 2009-02-10 17:59:11 --- Hi, I don't have it anymore and I think, reading the other comments again, it was wrong anyway (only showing the correct result). It also didn't have a testcase and no manifest handling. Somebody else will have to implement it properly.

wine-bugs＠winehq.org

13 Aug 13 Aug

5:58 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #17 from Austin English austinenglish@gmail.com 2009-08-13 12:58:39 --- Is this still an issue in current (1.1.27 or newer) wine?

wine-bugs＠winehq.org

29 Dec 29 Dec

9:46 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

Nikolay Sivov bunglehead@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |comctl32

--- Comment #18 from Nikolay Sivov bunglehead@gmail.com 2009-12-29 15:46:19 --- Cause native comctl32 takes care of buttons itself this is a common controls bug, but class redirection should be implemented first for this to work as it should.

wine-bugs＠winehq.org

30 Mar 30 Mar

12:29 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #19 from Austin English austinenglish@gmail.com 2011-03-29 19:29:53 CDT --- This is your friendly reminder that there has been no bug activity for 6 months. Is this still an issue in current (1.3.16 or newer) wine?

wine-bugs＠winehq.org

26 Apr 26 Apr

5:26 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

Carlo Bramini carlo.bramix@libero.it changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |carlo.bramix@libero.it

--- Comment #20 from Carlo Bramini carlo.bramix@libero.it 2011-04-26 12:26:32 CDT --- This bug is still valid. Tested XP Calculator on Ubuntu 10.04 and WINE-1.3.17

wine-bugs＠winehq.org

4 Jul 4 Jul

2:34 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

Ruslan Kabatsayev b7.10110111@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |b7.10110111@gmail.com

--- Comment #21 from Ruslan Kabatsayev b7.10110111@gmail.com 2013-07-04 09:34:47 CDT --- Strangely, the bug is still present with wine-1.6-rc4-22-g2d0653e.

wine-bugs＠winehq.org

3:11 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #22 from Nikolay Sivov bunglehead@gmail.com 2013-07-04 10:11:35 CDT --- (In reply to comment #21)

Strangely, the bug is still present with wine-1.6-rc4-22-g2d0653e.

There was no attempt yet to duplicate builtin controls in comctl32, in other words class redirection is not implemented, so it obviously doesn't work.

wine-bugs＠winehq.org

5 Jul 5 Jul

1:23 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #23 from Bamm Gabriana bammzilla@astronomy.com.ph 2013-07-04 20:23:59 CDT --- So what needs to be done in order to implement this?

wine-bugs＠winehq.org

3:47 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #24 from Nikolay Sivov bunglehead@gmail.com 2013-07-04 22:47:40 CDT --- Some loader magic is needed, when manifest is found it should load specified module and register all classes mentioned in manifest with this module using RegisterClassNameW call. Last time I tried to make a reliable test for that I lost a battle with activation contexts as I remember. I should probably try again eventually.

wine-bugs＠winehq.org

8:06 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

Qian Hong fracting@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |fracting@gmail.com

--- Comment #25 from Qian Hong fracting@gmail.com 2013-07-05 03:06:21 CDT --- (In reply to comment #24)

Some loader magic is needed, when manifest is found it should load specified module and register all classes mentioned in manifest with this module using RegisterClassNameW call. Last time I tried to make a reliable test for that I lost a battle with activation contexts as I remember. I should probably try again eventually.

Interesting, is the loader magic you mentioned related to Bug 25340?

wine-bugs＠winehq.org

8:52 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #26 from Nikolay Sivov bunglehead@gmail.com 2013-07-05 03:52:01 CDT --- No, this is different, but supplied with manifest resource/file too. I tested it again just now and it's probably easier than I thought - it doesn't register everything on load but on first class use with CreateWindow(). That means user32 has to check for current (or not only current?) context data and then override registration with RegisterClassNameW, another thing is that it probably alters context to mark class are re-registered, cause this function is called only once.

wine-bugs＠winehq.org

17 Apr 17 Apr

9:52 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

Frédéric Delanoy frederic.delanoy@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic.delanoy@gmail.com

--- Comment #27 from Frédéric Delanoy frederic.delanoy@gmail.com --- Is this still an issue in latest wine (1.7.16 or later)?

I couldn't find any downloadable version of XP calculator.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

9:54 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #28 from Nikolay Sivov bunglehead@gmail.com --- (In reply to Frédéric Delanoy from comment #27)

Is this still an issue in latest wine (1.7.16 or later)?

Yes.

I couldn't find any downloadable version of XP calculator.

I don't think it exist, unless it was updated with some SP.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

8 Sep 8 Sep

5:29 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

Austin English austinenglish@gmail.com changed:

--- Comment #29 from Austin English austinenglish@gmail.com --- (In reply to Nikolay Sivov from comment #28)

(In reply to Frédéric Delanoy from comment #27)

...
Is this still an issue in latest wine (1.7.16 or later)?

Yes.

...
I couldn't find any downloadable version of XP calculator.

I don't think it exist, unless it was updated with some SP.

It was updated in win7sp1, but it doesn't work for me in wine-1.7.51-23-g07cc9a3 (silently exits). There's https://www.microsoft.com/en-us/download/details.aspx?id=21622, but it has different graphics.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

1 Jan 1 Jan

4:36 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #30 from Frédéric Delanoy frederic.delanoy@gmail.com --- Still in 1.9.0 (tested with WinXP calc)

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

30 Aug 30 Aug

6:31 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #31 from Ruslan Kabatsayev b7.10110111@gmail.com --- Still present in wine-2.15-74-g083e61f with WinXP calc.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

8 Mar 8 Mar

12:19 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

Gabriel Ivăncescu gabrielopcode@gmail.com changed:

--- Comment #32 from Gabriel Ivăncescu gabrielopcode@gmail.com --- Fixed by 4b85740ebf94a05aafb8e6c55c3b5a2826ac2b69 and related patch series.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

3:29 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #33 from Ruslan Kabatsayev b7.10110111@gmail.com --- Great! Confirming that it's fixed.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

15 Mar 15 Mar

8:23 p.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

Alexandre Julliard julliard@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #34 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 4.4.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

29 May 29 May

10:32 a.m.

New subject: [Bug 10531] Windows Calculator: Color in buttons missing

--- Comment #35 from Anastasius Focht focht@gmx.net --- *** Bug 31572 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

10:33 a.m.

New subject: [Bug 10531] Multiple applications lack text and/or color on buttons (missing NM_CUSTOMDRAW support)(Windows Calculator, SUPERAntiSpyware)

Anastasius Focht focht@gmx.net changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

19 May 19 May

2:26 p.m.

New subject: [Bug 10531] Multiple applications lack text and/or color on buttons (missing NM_CUSTOMDRAW support)(Windows Calculator, SUPERAntiSpyware)