http://bugs.winehq.org/show_bug.cgi?id=16269
Summary: InternetCreateUrl does not encode URL_COMPONENTS.lpszExtraInfo Product: Wine Version: 1.1.9 Platform: PC-x86-64 OS/Version: Windows XP Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: wininet AssignedTo: wine-bugs@winehq.org ReportedBy: winehq.5.tahtu@spamgourmet.com
InternetCreateUrl does not encode URL_COMPONENTS.lpszExtraInfo it just ignore this value.
How to reproduce (I tried to write a C++ code, but since I code C++ very rarely please excuse small syntax problems):
URL_COMPONENTS URLComponents; char[128] URL; DWORD Size;
ZeroMemory(&URLComponents, SizeOf(URLComponents)); URLComponents.lpszScheme = 'http'; URLComponents.dwSchemeLength = strlen(URLComponents.lpszExtraInfo); URLComponents.lpszHostName = 'localhost'; URLComponents.dwHostNameLength = strlen(URLComponents.lpszExtraInfo); URLComponents.nPort = 80; URLComponents.lpszUrlPath = '/'; URLComponents.dwUrlPathLength = strlen(URLComponents.lpszUrlPath); URLComponents.lpszExtraInfo = '?test=123'; URLComponents.dwExtraInfoLength = strlen(URLComponents.lpszExtraInfo);
Size = 128; InternetCreateUrl(URLComponents, ICU_ESCAPE, URL, Size);
URL has the value 'http://localhost/' instead of 'http://localhost/?test=123' under Microsoft Windows.
http://bugs.winehq.org/show_bug.cgi?id=16269
--- Comment #1 from Tahtu winehq.5.tahtu@spamgourmet.com 2008-11-29 13:47:49 --- On the console I found this line:
err:mmio:MMIO_ParseExtA No . in szFileName: "Z:\home\jars\Desktop\"
... don't know if it relates to this bug.
http://bugs.winehq.org/show_bug.cgi?id=16269
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OS/Version|Windows XP |other
http://bugs.winehq.org/show_bug.cgi?id=16269
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com
--- Comment #2 from Dan Kegel dank@kegel.com 2008-11-29 19:14:08 --- What app does this affect?
http://bugs.winehq.org/show_bug.cgi?id=16269
--- Comment #3 from Tahtu winehq.5.tahtu@spamgourmet.com 2008-11-30 01:02:25 --- The question which program is affected does not help in any case to fix a bug.
I reported the bug directly based on the API call - so everybody is able to reproduce this bug easily.
If somebody things known bugs can be ignored since no application is know which uses this API call I'm the wrong one to support the Wine project with my bug reports.
Please fee free to close this bug if you are not interessed to fix it and if you think this is the right way to make Wine better.
http://bugs.winehq.org/show_bug.cgi?id=16269
--- Comment #4 from Dan Kegel dank@kegel.com 2008-11-30 01:04:10 --- Relax, I was just curious. Is there some reason you don't want to say what app it is? Knowing the app helps us, partly because it might make it easier to reproduce.
http://bugs.winehq.org/show_bug.cgi?id=16269
--- Comment #5 from Tahtu winehq.5.tahtu@spamgourmet.com 2008-11-30 01:06:41 --- (In reply to comment #4)
Is there some reason you don't want to say what app it is?
Yes! It's absolutely uninteressed!
The easiest way to reproduce a bug is explaining how to call the API function to get the bug.
http://bugs.winehq.org/show_bug.cgi?id=16269
--- Comment #6 from Dan Kegel dank@kegel.com 2008-11-30 01:08:57 --- Whatever. Well, somebody might come along and have a look. Thanks for providing the pseudocode, at least. You'll get faster service if you turn it into a conformance test, see http://www.winehq.org/site/docs/winedev-guide/testing
http://bugs.winehq.org/show_bug.cgi?id=16269
Tahtu winehq.5.tahtu@spamgourmet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID
--- Comment #7 from Tahtu winehq.5.tahtu@spamgourmet.com 2008-11-30 01:13:04 --- (In reply to comment #6)
You'll get faster service if you turn it into a conformance test, see
Looks there is a misunderstanding about my bug reporting. I reported bugs to assist the Wine project. But if here is not a truth motivation to honor the work of bug reporting I think I'm not longer interessed to report bugs.
T not bother anybody further more with this bug report I set the status to INVALID - so nobody has to take a look on it.
http://bugs.winehq.org/show_bug.cgi?id=16269
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|INVALID |
--- Comment #8 from Dan Kegel dank@kegel.com 2008-11-30 10:43:56 --- We're interested in fixing bugs. We love bug reports.
It helps to have high quality bug reports. The best ones either mention which real-world app is affected, or some with conformance tests. So we encourage people who submit bugs to provide that extra information, in hopes they will tiptoe down the path of becoming wine contributors.
But even without those, bug reports can be valid. It just might take a little more time for somebody to look at them and generate a conformance test.
http://bugs.winehq.org/show_bug.cgi?id=16269
--- Comment #9 from Dan Kegel dank@kegel.com 2008-11-30 10:44:54 --- (typo: should have been "come with conformance tests". Sorry for the fat fingers.)
http://bugs.winehq.org/show_bug.cgi?id=16269
Tahtu winehq.5.tahtu@spamgourmet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |ABANDONED
--- Comment #10 from Tahtu winehq.5.tahtu@spamgourmet.com 2008-11-30 10:48:46 --- (In reply to comment #8)
It helps to have high quality bug reports.
Indeed it's helps to get as much as possible.
By requesting this you showed to me not to be interessed to honor my work. So you will not get any further bug report from me.
... maybe you will think about, if you strategie is the best one to make Wine stable.
http://bugs.winehq.org/show_bug.cgi?id=16269
--- Comment #11 from Dan Kegel dank@kegel.com 2008-11-30 10:58:29 --- Thank you for your bug report. I've copied the info into a new bug, bug 16287, so that we can look at it without disturbing you.
http://bugs.winehq.org/show_bug.cgi?id=16269
--- Comment #12 from Austin English austinenglish@gmail.com 2008-11-30 12:27:05 --- It's not that we're uninterested, but there are currently 4446 open bugs. Time and effort are obviously focused on areas that affect lots of programs, or are easy to fix. The testcode helps with that, making it easier to fix, but without knowing which apps (if any) are affected, it's not as high of a priority.
http://bugs.winehq.org/show_bug.cgi?id=16269
--- Comment #13 from Tahtu winehq.5.tahtu@spamgourmet.com 2008-11-30 12:30:36 --- I will not bother you with further bugs, since I understood you do not be able to honor my work of it.
http://bugs.winehq.org/show_bug.cgi?id=16269
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #14 from Austin English austinenglish@gmail.com 2008-12-01 02:18:02 --- Closing.
http://bugs.winehq.org/show_bug.cgi?id=16269
--- Comment #15 from Austin English austinenglish@gmail.com 2008-12-02 16:50:19 --- A patch was committed today that should fix this. Please retest in git.
http://bugs.winehq.org/show_bug.cgi?id=16269
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|ABANDONED |FIXED
--- Comment #16 from Dan Kegel dank@kegel.com 2008-12-02 17:38:00 --- Fix committed, please retest.
http://bugs.winehq.org/show_bug.cgi?id=16269
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |UNCONFIRMED Resolution|FIXED |
--- Comment #17 from Dmitry Timoshkov dmitry@codeweavers.com 2008-12-02 22:48:01 --- Reopening.
http://bugs.winehq.org/show_bug.cgi?id=16269
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #18 from Dmitry Timoshkov dmitry@codeweavers.com 2008-12-02 22:48:13 --- Marking as fixed.
http://bugs.winehq.org/show_bug.cgi?id=16269
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #19 from Alexandre Julliard julliard@winehq.org 2008-12-05 11:16:34 --- Closing bugs fixed in 1.1.10.