[Bug 49748] New: Multisim 14.2 installer fails with "Directory name invalid"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49748

Bug ID: 49748
           Summary: Multisim 14.2 installer fails with "Directory name
                    invalid"
           Product: Wine
           Version: 5.15
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

When running the installer, it terminates with a MessageBox showing "Directory
name invalid".

[Bug 49748] Multisim 14.2 installer fails with "Directory name invalid"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49748

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://download.ni.com/sup
                   |                            |port/nipkg/products/ni-c/ni
                   |                            |-cds-educational/14.2/offli
                   |                            |ne/ni-cds-educational_14.2.
                   |                            |0_offline.iso
           Keywords|                            |download

--- Comment #1 from Fabian Maurer  ---
The trial is free, can be downloaded from
https://www.ni.com/de-de/support/downloads/software-products/download.multis...

Make sure to use the ISO offline installer
(https://download.ni.com/support/nipkg/products/ni-c/ni-cds-educational/14.2/...)

[Bug 49748] Multisim 14.2 installer fails with "Directory name invalid"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49748

--- Comment #2 from Fabian Maurer  ---
Created attachment 68050
  --> https://bugs.winehq.org/attachment.cgi?id=68050
Test case

Adding a small test case. The problem here is ShellExecute.

When there are two executables with the same name, and one is in a subfolder,
the shell execute logic messes up.

AFAIK there's two problems here:
1) Shell execute with a relative path doesn't work properly, because it passes
the same relative path to CreateProcessW
2) When normalizing the path, CreateProcessW searches in the current directly
before the specified directory, leading to the exe starting itself endlessly

Can someone with more experience than me please look into that? Loading path
order is pretty complicated...

[Bug 49748] Multisim 14.2 installer fails with "Directory name invalid"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49748

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase
          Component|-unknown                    |shell32

[Bug 49748] Multisim 14.2 installer fails with "Directory name invalid"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49748

qsniyg  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from qsniyg  ---
Created attachment 68179
  --> https://bugs.winehq.org/attachment.cgi?id=68179
ShellExecute patch

Thanks for the test case!

Could you test the attached patch? It appears to fix problem #1 with the test
case you attached.

If I understand it correctly, problem #2 also occurs under Windows 10 for me.
If I run test.exe without dir/test.exe existing in the same directory, it will
start itself endlessly under both wine and Windows 10.

[Bug 49748] Multisim 14.2 installer fails with "Directory name invalid"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49748

--- Comment #4 from Fabian Maurer  ---
> Could you test the attached patch? It appears to fix problem #1 with the
> test case you attached.

I'm not sure if it's really ok if we don't pass lpDirectory to CreateProcessW.
> If I run test.exe without dir/test.exe existing in the same directory,
> it will start itself endlessly under both wine and Windows 10.

Great... I can confirm, my Win7 VM behaves different from my Windows 10 VM.

[Bug 49748] Multisim 14.2 installer fails with "Directory name invalid"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49748

--- Comment #5 from qsniyg  ---
(In reply to Fabian Maurer from comment #4)
> > Could you test the attached patch? It appears to fix problem #1 with the
> > test case you attached.
>
> I'm not sure if it's really ok if we don't pass lpDirectory to
> CreateProcessW.

I'll have to test it more, but my reasoning behind this change is that it has
already called SetCurrentDirectory to that directory, so passing the directory
doesn't appear to be useful.

[Bug 49748] Multisim 14.2 installer fails with "Directory name invalid"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49748

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from [e-mail] ---
Recently I ran into this issue with Wine 6.0 on (K)Ubuntu 20.10. Is there any
news about fixing the problem?

[Bug 49748] Multisim 14.2 installer fails with "Directory name invalid"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49748

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                 CC|                            |[e-mail]