[Bug 26772] New: Bad charset setting in CreateFont makes characters as block.

http://bugs.winehq.org/show_bug.cgi?id=26772

Summary: Bad charset setting in CreateFont makes characters as
                    block.
           Product: Wine
           Version: 1.3.17
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Many windows programs using wrong charset in CreateFont[1] function, like
ANSI_CHARSET. Wine accept the wrong charset, and draw the string as the
programmer requested. It makes the characters look like `block'.

It seems Windows chose differnt encoding for strings, it basically ignore the
charset settings in CreateFont. Every strings painted correctly on Windows.

You can download a test program from github[4], and binary[5] for test.

Effected hifree[2], PPStream[3] and other Chinese (or CJK) softwares.

Credit: ptpt52, http://forum.ubuntu.org.cn/viewtopic.php?f=121&t=291611
[1] http://msdn.microsoft.com/en-us/library/dd183499%28v=vs.85%29.aspx
[2] http://appdb.winehq.org/objectManager.php?sClass=version&iId=23197
[3] http://appdb.winehq.org/objectManager.php?sClass=version&iId=19269
[4] https://github.com/chihchun/winfont
[5] http://www.mediafire.com/?zmv694e6410grzk

[Bug 26772] Bad charset setting in CreateFont makes characters as block.

http://bugs.winehq.org/show_bug.cgi?id=26772

--- Comment #1 from Rex Tsai  2011-04-14 05:11:49 CDT ---
Created an attachment (id=34105)
 --> (http://bugs.winehq.org/attachment.cgi?id=34105)
winfont test program in Traditional Chinese Windows XP

[Bug 26772] Bad charset setting in CreateFont makes characters as block.

http://bugs.winehq.org/show_bug.cgi?id=26772

--- Comment #2 from Rex Tsai  2011-04-14 05:12:29 CDT ---
Created an attachment (id=34106)
 --> (http://bugs.winehq.org/attachment.cgi?id=34106)
wintfont test program in wine 1.3.17

[Bug 26772] Bad charset setting in CreateFont makes characters as block.

http://bugs.winehq.org/show_bug.cgi?id=26772

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
          Component|gdi32                       |-unknown
         Resolution|                            |DUPLICATE

--- Comment #3 from Dmitry Timoshkov  2011-04-14 05:13:07 CDT ---
Duplicate. Also make sure you are using correct locale settings.

*** This bug has been marked as a duplicate of bug 13829 ***

[Bug 26772] Bad charset setting in CreateFont makes characters as block.

http://bugs.winehq.org/show_bug.cgi?id=26772

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Dmitry Timoshkov  2011-04-14 05:13:21 CDT ---
Closing.

[Bug 26772] Bad charset setting in CreateFont makes characters as block.

http://bugs.winehq.org/show_bug.cgi?id=26772

--- Comment #5 from Rex Tsai  2011-04-14 05:13:52 CDT ---
Created an attachment (id=34107)
 --> (http://bugs.winehq.org/attachment.cgi?id=34107)
quick patch for using text charset from DC

No sure if there is side effect, I need some help on review and suggestions

[Bug 26772] Bad charset setting in CreateFont makes characters as block.

http://bugs.winehq.org/show_bug.cgi?id=26772

--- Comment #6 from Rex Tsai  2011-04-14 05:15:19 CDT ---
Created an attachment (id=34108)
 --> (http://bugs.winehq.org/attachment.cgi?id=34108)
hifree with wine 1.3.17

[Bug 26772] Bad charset setting in CreateFont makes characters as block.

http://bugs.winehq.org/show_bug.cgi?id=26772

--- Comment #7 from Rex Tsai  2011-04-14 05:15:43 CDT ---
Created an attachment (id=34109)
 --> (http://bugs.winehq.org/attachment.cgi?id=34109)
hifree with the patch for wine 1.3.17

[Bug 26772] Bad charset setting in CreateFont makes characters as block.

http://bugs.winehq.org/show_bug.cgi?id=26772

--- Comment #8 from Rex Tsai  2011-04-14 05:21:20 CDT ---
(In reply to comment #3)
> Duplicate. Also make sure you are using correct locale settings.
>
> *** This bug has been marked as a duplicate of bug 13829 ***

I am sure that I am using the correct locale settings, the issue is caused by
bad program. And it can not be fixed with Font Links and Font Replacements.

[Bug 26772] Bad charset setting in CreateFont makes characters as block.

http://bugs.winehq.org/show_bug.cgi?id=26772

Rex Tsai  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |UNCONFIRMED
          Component|-unknown                    |gdi32
         Resolution|DUPLICATE                   |

--- Comment #9 from Rex Tsai  2011-04-14 05:47:12 CDT ---
#13829 addressed the problem of font aliases issue, this bug report is to
discuss the problem on bad programing behavior (programmer uses ANSI_CHARSET
instend of DEFAULT_CHARSET)

[Bug 26772] Bad charset setting in CreateFont makes characters as block.

http://bugs.winehq.org/show_bug.cgi?id=26772

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|gdi32                       |-unknown

--- Comment #10 from Dmitry Timoshkov  2011-04-14 07:23:37 CDT ---
(In reply to comment #5)
> Created an attachment (id=34107)

--> (http://bugs.winehq.org/attachment.cgi?id=34107) [details]
> quick patch for using text charset from DC
>
> No sure if there is side effect, I need some help on review and suggestions

A need for the patch of that kind usually indicates that the locale is
wrong. dlls/gdi32/tests/font.c has quite a bit of charset and encoding
tests, if you could add a test there demonstrating the problem that would
be a good start.

[Bug 26772] Bad charset setting in CreateFont makes characters as block.

http://bugs.winehq.org/show_bug.cgi?id=26772

Qian Hong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Qian Hong  2013-08-03 09:11:09 CDT ---
Hi Rex Tsai,

Could you retest with Wine 1.6?

Many font rendering bugs have been fixed since the date you report this bug, I
hope this one is already fixed for you as well :)

Thanks for testing.

[Bug 26772] Bad charset setting in CreateFont makes characters as block.

https://bugs.winehq.org/show_bug.cgi?id=26772

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |ABANDONED

--- Comment #12 from Austin English  ---
(In reply to Qian Hong from comment #11)
> Hi Rex Tsai,
>
> Could you retest with Wine 1.6?
>
> Many font rendering bugs have been fixed since the date you report this bug,
> I hope this one is already fixed for you as well :)
>
> Thanks for testing.

Abandoned.

[Bug 26772] Bad charset setting in CreateFont makes characters as block.

https://bugs.winehq.org/show_bug.cgi?id=26772

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Austin English  ---
Closing.