https://bugs.winehq.org/show_bug.cgi?id=56655
Bug ID: 56655 Summary: Regression: X11 Driver fails to load Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: major Priority: P2 Component: winex11.drv Assignee: wine-bugs@winehq.org Reporter: bmcgrath@codeweavers.com Regression SHA1: f74900ad1a580eda8fd4923cbd4881b42b042733 Distribution: ---
Created attachment 76428 --> https://bugs.winehq.org/attachment.cgi?id=76428 Fix X11 driver
Building with the latest from master, I found the X11 driver fails to load. The attempt to load appears to enter a tight loop and Wine becomes unresponsive.
A git bisect led me to f74900ad1a580eda8fd4923cbd4881b42b042733.
I then further narrowed it down to the changes in xrandr10_get_modes.
It looks like the old code used to increment mode_idx, but the new code doesn't. The attached patch fixes this for me.
https://bugs.winehq.org/show_bug.cgi?id=56655
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal Keywords| |download, regression, | |source Version|unspecified |9.8 CC| |rbernon@codeweavers.com
--- Comment #1 from Ken Sharp imwellcushtymelike@gmail.com ---
winex11: Only request display modes driver data when needed.
Works fine here. Attaching the console output would help.
https://bugs.winehq.org/show_bug.cgi?id=56655
Grigory Vasilyev h0tc0d3@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |h0tc0d3@gmail.com
--- Comment #2 from Grigory Vasilyev h0tc0d3@gmail.com --- I also got an error under Wayland. And wine refuses to work through XWayland. Only native wayland mode works in wine. I confirm the regression.
0098:err:hid:udev_bus_init UDEV monitor creation failed r.exe: dlls/winex11.drv/xvidmode.c:164: xf86vm_free_modes: Assertion `modes[0].dmDriverExtra == sizeof(XF86VidModeModeInfo *)' failed.
Also this MR did not solve error. https://gitlab.winehq.org/wine/wine/-/merge_requests/5608
https://bugs.winehq.org/show_bug.cgi?id=56655
--- Comment #3 from Grigory Vasilyev h0tc0d3@gmail.com --- Upd. Solved. The problem is caused by the --without-xrandr build option. Before this commit, wine worked fine with this parameter.
https://bugs.winehq.org/show_bug.cgi?id=56655
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Regression: X11 Driver |X11 Driver fails to load |fails to load |
https://bugs.winehq.org/show_bug.cgi?id=56655
--- Comment #4 from Andrey Gusev andrey.goosev@gmail.com --- Metro Exodus crashes at launch for me with this fix.
While wineboot -u
0080:err:system:NtUserChangeDisplaySettings Changing L"\\.\DISPLAY2" display settings returned -2. 0080:err:explorer:initialize_display_settings Failed to initialize registry display settings for L"\\.\DISPLAY2". 0080:err:system:NtUserChangeDisplaySettings Changing (null) display settings returned -2. 0080:err:explorer:initialize_display_settings Failed to set primary display settings.
https://bugs.winehq.org/show_bug.cgi?id=56655
Brendan McGrath bmcgrath@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED
--- Comment #5 from Brendan McGrath bmcgrath@codeweavers.com --- I can confirm this is fixed for me with the following commit: f6791f59c3a5fe2aa178edc66861d358de912d22
https://bugs.winehq.org/show_bug.cgi?id=56655
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |f6791f59c3a5fe2aa178edc6686 | |1d358de912d22
https://bugs.winehq.org/show_bug.cgi?id=56655
--- Comment #6 from Brendan McGrath bmcgrath@codeweavers.com --- @Andrey Gusev . Do you still have an issue with Metro Exodus with f6791f59c3a5fe2aa178edc66861d358de912d22?
https://bugs.winehq.org/show_bug.cgi?id=56655
--- Comment #7 from Andrey Gusev andrey.goosev@gmail.com --- That's right. And also Horizon Zero Dawn Complete Edition doesn't show a loading window before the crash as expected as of now.
https://bugs.winehq.org/show_bug.cgi?id=56655
--- Comment #8 from Brendan McGrath bmcgrath@codeweavers.com --- OK, thanks for confirming. I guess you should create a new bug for this (given it is a different commit that is now causing a new regression).
Can I also confirm you tested with a new prefix? From memory, my fix didn't work for me until I tested in a new prefix.
https://bugs.winehq.org/show_bug.cgi?id=56655
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 9.9.
-
WineHQ Bugzilla