[Bug 29291] New: Tomb Raider III looses all the textures

http://bugs.winehq.org/show_bug.cgi?id=29291

Bug #: 29291
           Summary: Tomb Raider III looses all the textures
           Product: Wine
           Version: 1.3.34
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 37887
  --> http://bugs.winehq.org/attachment.cgi?id=37887
Screenshot from Tomb Raider 3

Tomb Raider III looses all the textures. To be able to Tomb Raider 3 in wine
1.3.34 i had to apply hack from bug 27482#c4.

1. I did a regression test between 1.3.33 and 1.3.34:

commit ca83e14aba73a2dfa6410331229fb155ba53c78f
Author: Matteo Bruni 
Date:   Wed Nov 23 01:31:41 2011 +0100

ddraw: Reorder formats in EnumTextureFormats.

:040000 040000 8b7874525a9af24f0398723237adeb93e3acab73
7f88527d900fb9489e41b0ae37918aded1857137 M      dlls

2. No other bug report suffers from this commit.

3. Revert of this patch after git checkout makes that problem go away.

[Bug 29291] Tomb Raider III looses all the textures

http://bugs.winehq.org/show_bug.cgi?id=29291

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail]

[Bug 29291] Tomb Raider III looses all the textures

http://bugs.winehq.org/show_bug.cgi?id=29291

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |ca83e14aba73a2dfa6410331229
                   |                            |fb155ba53c78f

[Bug 29291] Tomb Raider III looses all the textures

http://bugs.winehq.org/show_bug.cgi?id=29291

--- Comment #1 from Matteo Bruni  2012-01-19 09:14:12 CST ---
I tried to reproduce it with the "full" demo from
http://www.tombraiderchronicles.com/tr3/demo.html but it renders fine for me.
Does the demo suffer from the same issue for you?

Anyway, a +d3d_caps trace should go as a start. What GPU/drivers are you using?

[Bug 29291] Tomb Raider III looses all the textures

http://bugs.winehq.org/show_bug.cgi?id=29291

Sylvain Petreolle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 29291] Tomb Raider III looses all the textures

http://bugs.winehq.org/show_bug.cgi?id=29291

--- Comment #2 from Wylda  2012-05-13 09:37:03 CDT ---
Created attachment 40158
  --> http://bugs.winehq.org/attachment.cgi?id=40158
Console log from 1.5.4 + WINEDEBUG=+d3d_caps
> Does the demo suffer from the same issue for you?

Hi Matteo, both the demos (india_demo, southpacific_demo) works for me too.
> Anyway, a +d3d_caps trace should go as a start. What GPU/drivers are you using?

My config:
 * GeForce GT 240 with 1GB RAM
 * nVidia binary driver 275.09.07
 * Debian Squeeze 32bit

The issue is still present for full TR3 game and wine-1.5.4.

[Bug 29291] Tomb Raider III looses all the textures

http://bugs.winehq.org/show_bug.cgi?id=29291

--- Comment #3 from Matteo Bruni  2012-05-14 08:20:15 CDT ---
Thanks Wylda, I guess I thought the bug had to do with paletted texture formats
but it doesn't seem to be the case here.
Can I ask for a +ddraw,+d3d_caps log? I may also need the same log but with the
patch reverted...

[Bug 29291] Tomb Raider III looses all the textures

http://bugs.winehq.org/show_bug.cgi?id=29291

--- Comment #4 from Wylda  2012-05-14 15:51:09 CDT ---

Hi Matteo, i got it by pure accident :) I was cleaning the TR3's folder from
the old console logs (.txt) and accidentally deleted the config.txt. Without it
the game initially shows the window with resolution setting, zbuffer etc. I
left the default and the game run normally. So the key is the config.txt. Short
changing&trying of values showed me the bug - to "turn on" the bug set:

D3DTF 0

Good news is, you can reproduce it even with demo. But don't take the India
demo - it does not produce the config.txt, but rather every startup asks for
setting. So take TR3 South Pacific Demo and change the config.

With your patch under wine-1.5.4 there won't be any textures. You can revert
your patch cleanly under latest version and textures will be back.

**Let me know, if you prefer testing your self or you would like the requested
logs instead.**

PS: I don't know, what "D3DTF" stands for, but the zero can come from old wine
versions where some functionality was missing so TR3's default gave different
values for old wine. Or it could change during the years of regular testing
when it reach somewhat broken wine...

[Bug 29291] Tomb Raider III looses all the textures

http://bugs.winehq.org/show_bug.cgi?id=29291

--- Comment #5 from Matteo Bruni  2012-05-14 17:41:12 CDT ---
Oh, nice discovery. I guess the game stores the selected texture format as an
index and reordering the texture formats in ddraw "broke" it. Not the best
programming practice...

If I understand correctly, though, a fresh install of TR3 works fine (or
removing config.txt to force the game to redo its autoconfiguration), so I
think this is actually an invalid bug i.e. there is nothing to fix.

[Bug 29291] Tomb Raider III looses all the textures

http://bugs.winehq.org/show_bug.cgi?id=29291

--- Comment #6 from Sylvain Petreolle  2012-05-15 07:36:15 CDT ---
(In reply to comment #5)
> If I understand correctly, though, a fresh install of TR3 works fine (or
> removing config.txt to force the game to redo its autoconfiguration), so I
> think this is actually an invalid bug i.e. there is nothing to fix.

Does a fresh install with D3DTF 0 also work ?
Otherwise there is still something to fix.

[Bug 29291] Tomb Raider III looses all the textures

http://bugs.winehq.org/show_bug.cgi?id=29291

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID

--- Comment #7 from Wylda  2012-05-16 00:10:15 CDT ---

Important is, how it behaves under native OS. I freshly installed Tomb Raider 3
under WinXP and when setting D3DTF to 0 the textures are missing exactly like
in current wine. Thus invalid. Sorry for the noise.

Google gave me some forum, where was a wild guess, that D3DTF stands for
Trilinear Filtering.

But it's not the On/Off switch, but accepts at least values 0,1,2 and each
produces different picture/texture quality. And your patch also points TF to
Texture Format.

PS: Note for my potential future use - to avoid startup crash under WinXP,
sounds need to be disabled.

[Bug 29291] Tomb Raider III looses all the textures

http://bugs.winehq.org/show_bug.cgi?id=29291

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|regression                  |
    Regression SHA1|ca83e14aba73a2dfa6410331229 |
                   |fb155ba53c78f               |

--- Comment #8 from Wylda  2012-05-16 00:10:35 CDT ---

Closing.

[Bug 29291] Tomb Raider III looses all the textures

http://bugs.winehq.org/show_bug.cgi?id=29291

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Wylda  2012-05-16 00:11:08 CDT ---

Closing for real now :-/