[Bug 39794] New: incorrect GetICMProfileA() implementation

https://bugs.winehq.org/show_bug.cgi?id=39794

Bug ID: 39794
           Summary: incorrect GetICMProfileA() implementation
           Product: Wine
           Version: 1.8-rc3
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdi32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 53095
  --> https://bugs.winehq.org/attachment.cgi?id=53095
Fix GetICMProfile implementation

When digging problem with Nikon Capture NX2 I found incorrect implementation of
GetICMProfileA().

Attached patch fixed problem with "bluish" Capture NX2 screen images and all
other program that use GetICMProfileA() to acquire buffer-size before call
GetICMProfileW().

[Bug 39794] incorrect GetICMProfileA() implementation

https://bugs.winehq.org/show_bug.cgi?id=39794

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                 CC|                            |[e-mail]

--- Comment #1 from Sebastian Lackner  ---
Patches (especially when they are just a small bug fixes) should be submitted
to the wine-patches mailing list. Take a look here for more details regarding
the patch submission process: http://wiki.winehq.org/SubmittingPatches

In order to increase chances of getting your patch accepted, it would help to
add a test, too. dlls/gdi32/tests/icm.c already contains other tests for the
same function, for example.

[Bug 39794] incorrect GetICMProfileA() implementation

https://bugs.winehq.org/show_bug.cgi?id=39794

--- Comment #2 from Bruno Jesus  ---
I understand that you created a new bug to separate the patch from the bug
33140 discussion, is that right? If yes, that is not how it works in Wine's
bugzilla, you can just attach the patch to the correct bug and continue the
discussion there. This bug is a duplicate of the other bug if the above
question's answer is yes.

[Bug 39794] incorrect GetICMProfileA() implementation

https://bugs.winehq.org/show_bug.cgi?id=39794

--- Comment #3 from Nikolay Sivov  ---
The idea is correct, patch itself is wrong though, and mixes two separate
issues. Second part is handled by drivers already, except for last error, which
we don't necessary want to be set.

Also I agree, there's no reason to split it from bug 33140.

I just sent a test for initial problem
https://www.winehq.org/pipermail/wine-patches/2015-December/145178.html.

[Bug 39794] incorrect GetICMProfileA() implementation

https://bugs.winehq.org/show_bug.cgi?id=39794

--- Comment #4 from Andrey Melnikov  ---
Drop second part if it not need.

[Bug 39794] incorrect GetICMProfileA() implementation

https://bugs.winehq.org/show_bug.cgi?id=39794

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #5 from Austin English  ---
Dupe.

*** This bug has been marked as a duplicate of bug 33140 ***

[Bug 39794] incorrect GetICMProfileA() implementation

https://bugs.winehq.org/show_bug.cgi?id=39794

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Austin English  ---
Closing.