https://bugs.winehq.org/show_bug.cgi?id=40598
Bug ID: 40598 Summary: Warframe launcher connection timeout Product: Wine-staging Version: 1.9.9 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: thisismyid17@yahoo.com CC: erich.e.hoover@wine-staging.com, michael@fds-team.de, sebastian@fds-team.de Distribution: ---
Created attachment 54444 --> https://bugs.winehq.org/attachment.cgi?id=54444 launcher log
As of wine-staging 1.9.9, the non-steam Warframe launcher no longer functions. Instead of doing the usual patching and being able to play, it simply says Update Failed! Please try again later.
This did not happen in wine-staging 1.9.8 and previous, and I am able to start the launcher and the game just fine using my older wine 1.6.2 installation. I had thought that perhaps this was related to the libcef patch removal that was mentioned in the announcement for 1.9.9 since Warframe uses CEF3_1 for their launcher, however since that was added in 1.7.53 and it works fine in 1.6.2 that less likely.
This happens for both 32-bit and 64-bit.
https://bugs.winehq.org/show_bug.cgi?id=40598
Pentarctagon thisismyid17@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |content.warframe.com/dl/War | |frame.msi Distribution|--- |Mint
https://bugs.winehq.org/show_bug.cgi?id=40598
Pentarctagon thisismyid17@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
https://bugs.winehq.org/show_bug.cgi?id=40598
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |-unknown Product|Wine-staging |Wine
--- Comment #1 from Sebastian Lackner sebastian@fds-team.de --- Thanks for the bug report. Could you please test if this issue also occurs with the development version of Wine? If it occurs in both versions, the "Wine" product is more appropriate.
https://bugs.winehq.org/show_bug.cgi?id=40598
--- Comment #2 from Pentarctagon thisismyid17@yahoo.com --- It does not occur when using wine 1.8 as installed from the ubuntu-wine ppa.
https://bugs.winehq.org/show_bug.cgi?id=40598
--- Comment #3 from Sebastian Lackner sebastian@fds-team.de --- (In reply to Pentarctagon from comment #2)
It does not occur when using wine 1.8 as installed from the ubuntu-wine ppa.
It would be better to compare it with the development version 1.9.9. Check the WineHQ download page for instructions how to install it on Ubuntu.
https://bugs.winehq.org/show_bug.cgi?id=40598
--- Comment #4 from Pentarctagon thisismyid17@yahoo.com --- The same error occurs in the development version of 1.9.9.
https://bugs.winehq.org/show_bug.cgi?id=40598
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 CC| |dmitry@baikal.ru Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/wininet-Intern | |etCrackUrlW Status|UNCONFIRMED |STAGED
https://bugs.winehq.org/show_bug.cgi?id=40598
--- Comment #5 from Pentarctagon thisismyid17@yahoo.com --- Tested in 1.9.10-staging, and the error no longer occurs.
https://bugs.winehq.org/show_bug.cgi?id=40598
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com
--- Comment #6 from winetest@luukku.com --- This bug contains regression keyword. And wine is currently trying to fix regressions. Is there any possibility to get this in 2.0 release?
https://bugs.winehq.org/show_bug.cgi?id=40598
--- Comment #7 from Pentarctagon pentarctagon@tutamail.com --- Warframe is unplayable without this fix, so I'd say getting this into mainline Wine would definitely be a good thing.
https://bugs.winehq.org/show_bug.cgi?id=40598
--- Comment #8 from Sebastian Lackner sebastian@fds-team.de --- (In reply to Pentarctagon from comment #7)
Warframe is unplayable without this fix, so I'd say getting this into mainline Wine would definitely be a good thing.
I wouldn't mind if the patch accepted, but please note that it is more a workaround instead of a proper fix. As I explained in https://www.winehq.org/pipermail/wine-patches/2016-July/152110.html:
--- snip --- Reason for the failure is because after decoding a "/" is added, and it does not fit into the buffer anymore. Michael wrote a patch to dynamically allocate a buffer, however I do not think the "/" should be added in the first place. --- snip ---
https://bugs.winehq.org/show_bug.cgi?id=40598
--- Comment #9 from winetest@luukku.com --- Assuming then that proper patch would have some if checks of valid charachters.
https://bugs.winehq.org/show_bug.cgi?id=40598
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |wininet
https://bugs.winehq.org/show_bug.cgi?id=40598
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de Staged patchset|https://github.com/wine-com |https://github.com/wine-sta |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast |ster/patches/wininet-Intern |er/patches/wininet-Internet |etCrackUrlW |CrackUrlW
https://bugs.winehq.org/show_bug.cgi?id=40598
David Girón duhowpi@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |duhowpi@gmail.com
--- Comment #10 from David Girón duhowpi@gmail.com --- With Wine 3.12-staged + custom Lutris install script, I can run this without any problem.
(Note, disable bulk download to avoid data corruption while downloading the game)
https://bugs.winehq.org/show_bug.cgi?id=40598
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|regression |download CC| |focht@gmx.net URL|content.warframe.com/dl/War |http://content.warframe.com |frame.msi |/dl/Warframe.msi Summary|Warframe launcher |Warframe 'launcher.exe' |connection timeout |reports 'update failed' | |('InternetCrackUrlW' must | |resize buffer when URL | |canonicalization fails due | |to insufficient buffer)
--- Comment #11 from Anastasius Focht focht@gmx.net --- Hello folks,
revisiting, still present.
--- snip --- $ pwd /home/focht/.wine/drive_c/users/focht/Local Settings/Application Data/Warframe/Downloaded/Dev/Tools
$ WINEDEBUG=+seh,+relay,+wininet,+shell wine ./Launcher.exe >>log.txt 2>&1 ... 0058:trace:wininet:InternetCrackUrlW (L"http://origin.warframe.com" 0 10000000 0x1ed538) 0058:trace:wininet:InternetCanonicalizeUrlW (L"http://origin.warframe.com", 0xafcd648, 0xfb2fd3c, 0x30000000) buffer length: 27 0058:trace:shell:UrlCanonicalizeW (L"http://origin.warframe.com", 0xafcd648, 0xfb2fd3c, 0x90000000) *pcchCanonicalized: 27 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"ht"> 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"htt"> 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"http"> 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"http:"> 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"http://%22%3E 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"http://origin.warframe.com/%22%3E 0058:trace:shell:UrlUnescapeW (L"http://origin.warframe.com/", (nil), 0xfb2f9b4, 0x00100000) 0058:trace:shell:UrlUnescapeW result L"http://origin.warframe.com/" 0058:trace:wininet:InternetConnectW (0x1, L"", 0, L"", 0x1ed138, 3, 0, 0) 0058:trace:wininet:WININET_AddRef 0xafc6380 -> refcount = 2 0058:trace:wininet:get_handle_object handle 1 -> 0xafc6380 0058:trace:wininet:HTTP_Connect --> 0058:trace:wininet:WININET_Release object 0xafc6380 refcount = 1 0058:trace:wininet:InternetConnectW returning (nil) 0058:Call KERNEL32.OutputDebugStringW(004a5720 L"Could not open connection\n") ret=004178ba 0058:Ret KERNEL32.OutputDebugStringW() retval=0fb2eda0 ret=004178ba 0058:trace:wininet:InternetCloseHandle 0x1 ... --- snip ---
With patch:
--- snip --- ... 0058:trace:wininet:InternetCrackUrlW (L"http://origin.warframe.com" 0 10000000 0x1ed538) 0058:trace:wininet:InternetCanonicalizeUrlW (L"http://origin.warframe.com", 0x93f0fa8, 0xc0afd30, 0x30000000) buffer length: 27 0058:trace:shell:UrlCanonicalizeW (L"http://origin.warframe.com", 0x93f0fa8, 0xc0afd30, 0x90000000) *pcchCanonicalized: 27 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"ht"> 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"htt"> 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"http"> 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"http:"> 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"http://%22%3E 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"http://origin.warframe.com/%22%3E 0058:trace:shell:UrlUnescapeW (L"http://origin.warframe.com/", (nil), 0xc0af9a4, 0x00100000) 0058:trace:shell:UrlUnescapeW result L"http://origin.warframe.com/" 0058:trace:wininet:InternetCanonicalizeUrlW (L"http://origin.warframe.com", 0x951cd88, 0xc0afd30, 0x30000000) buffer length: 28 0058:trace:shell:UrlCanonicalizeW (L"http://origin.warframe.com", 0x951cd88, 0xc0afd30, 0x90000000) *pcchCanonicalized: 28 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"ht"> 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"htt"> 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"http"> 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"http:"> 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"http://%22%3E 0058:trace:shell:UrlCanonicalizeW Simplified, orig <L"http://origin.warframe.com%22%3E, simple <L"http://origin.warframe.com/%22%3E 0058:trace:shell:UrlUnescapeW (L"http://origin.warframe.com/", (nil), 0xc0af9a4, 0x00100000) 0058:trace:shell:UrlUnescapeW result L"http://origin.warframe.com/" 0058:trace:shell:UrlCanonicalizeW result L"http://origin.warframe.com/" 0058:trace:wininet:InternetCrackUrlW (L"http://origin.warframe.com/" 27 0 0x1ed538) 0058:trace:wininet:set_url_component (null) (0) 0058:trace:wininet:GetInternetSchemeW L"http" 4 0058:trace:wininet:set_url_component L"http" (4) 0058:trace:wininet:set_url_component (null) (0) 0058:trace:wininet:set_url_component (null) (0) 0058:trace:wininet:set_url_component L"origin.warframe.com" (19) 0058:trace:wininet:set_url_component L"/" (1) 0058:trace:wininet:InternetCrackUrlW L"http://origin.warframe.com/": scheme((null)) host(L"origin.warframe.com") path(L"/") extra((null)) 0058:trace:wininet:InternetConnectW (0x1, L"origin.warframe.com", 80, L"", 0x1ed138, 3, 0, 0) 0058:trace:wininet:WININET_AddRef 0x91be7c8 -> refcount = 2 0058:trace:wininet:get_handle_object handle 1 -> 0x91be7c8 0058:trace:wininet:HTTP_Connect --> 0058:trace:wininet:WININET_AddRef 0x91be7c8 -> refcount = 3 0058:trace:wininet:HTTP_Connect 0x91be7c8 --> 0x91ec4d0 0058:trace:wininet:WININET_Release object 0x91be7c8 refcount = 2 0058:trace:wininet:InternetConnectW returning 0x2 ... --- snip ---
--- quote --- I wouldn't mind if the patch accepted, but please note that it is more a workaround instead of a proper fix. As I explained in https://www.winehq.org/pipermail/wine-patches/2016-July/152110.html:
... Reason for the failure is because after decoding a "/" is added, and it does not fit into the buffer anymore. Michael wrote a patch to dynamically allocate a buffer, however I do not think the "/" should be added in the first place. --- quote ---
https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/shlwapi/url.c#l282
It seems the current implementation of 'UrlCanonicalizeW()' of adding the trailing slash is correct.
'http://origin.warframe.com' -> 0x1A characters (buffer size = 0x1B, includes NULL term)
Native will return 'ERROR_INSUFFICIENT_BUFFER' and have 'pcchCanonicalized' set to 0x1C (= includes space for trailing slash). The canonicalized URL will contain a trailing slash if buffer size 0x1C is passed: 'http://origin.warframe.com/'
$ sha1sum Warframe.msi 041c922c72dd18202b7aec65dc6dc3f27926b5cf Warframe.msi
$ du -sh Warframe.msi 39M Warframe.msi
$ wine --version wine-3.14
Regards
https://bugs.winehq.org/show_bug.cgi?id=40598
--- Comment #12 from Nikolay Sivov bunglehead@gmail.com --- This one was merged as bfe8510ec0c7bcef0be1f6990c56ad235d8bccd6. Please retest.
https://bugs.winehq.org/show_bug.cgi?id=40598
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|STAGED |RESOLVED Fixed by SHA1| |bfe8510ec0c7bcef0be1f6990c5 | |6ad235d8bccd6 Resolution|--- |FIXED
--- Comment #13 from Anastasius Focht focht@gmx.net --- Hello folks,
this is fixed by commit https://source.winehq.org/git/wine.git/commitdiff/bfe8510ec0c7bcef0be1f6990c...
Thanks Michael
$ wine --version wine-3.15-94-gbfe8510ec0
Regards
https://bugs.winehq.org/show_bug.cgi?id=40598
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #14 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 3.16.
https://bugs.winehq.org/show_bug.cgi?id=40598
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x
https://bugs.winehq.org/show_bug.cgi?id=40598
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.0.x |---
--- Comment #15 from Michael Stefaniuc mstefani@winehq.org --- Removing the 3.0.x milestone from bug fixes included in 3.0.4.
-
wine-bugs＠winehq.org