[Bug 23025] New: D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

Summary: D-Pad is not functional in epsxe
           Product: Wine
           Version: 1.2-rc2
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=28546)
 --> (http://bugs.winehq.org/attachment.cgi?id=28546)
Problem output.

Using epsxe (even after deleting registry entry) directional pad is not fully
functional.

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

mike  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
          Component|-unknown                    |directx-dinput
           Severity|trivial                     |normal

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Michael Stefaniuc   2010-06-07 04:53:13 ---
Why is this bug a regression? Was the application working before? If yes then
with what Wine version? Also please perform a regression test
(http://wiki.winehq.org/RegressionTesting).

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|regression                  |
          Component|directx-dinput              |-unknown

--- Comment #2 from Vitaliy Margolen   2010-06-07 08:54:36 ---
No idea why it's a regression.

What exactly isn't working completely? Describe what is the problem, how to
reproduce it. What registry entry are you talking about?

If you think it worked before, perform proper regression testing.

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

--- Comment #3 from mike   2010-06-07 10:01:05 ---
All I can say is that the specific error in question doesn't happen in wine
1.0.1 and happens in every subsequent version of wine released since. Is that
not a regression? I think it is.

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #4 from Michael Stefaniuc   2010-06-07 10:05:27 ---
Mike, you forgot to specify that it worked before.
Can you please do a regression test?
Is there a free downloadable test version that exhibits the same issue?

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

--- Comment #5 from mike   2010-06-07 14:53:28 ---
Vitaliy Margolen:

The registry that I am referring to is explained here:
http://appdb.winehq.org/objectManager.php?sClass=version&iId=12203&i...

Yes I am using a different OS, but those directions made this issue disappear
(if already configured in wine 1.0.1, nothing is wrong). What exactly isn't
working completely is the d-pad input within the epsxe application using every
subsequent version of wine after 1.0.1. It interferes with game play severely.

To reproduce it is simple:

1. download epsxe and all subsequent required dll files to run a psx game
properly.
2. get a PSX game.
3. run it through wine past 1.0.1, following a config wizard in order to
configure the program for playability.
4. During setup of gamepad, you will find that the d-pad is stuck and is the
only input allowed to register from within the application. The other button
can be affected by this as well, a workaround is to press & hold those buttons
then move on to the next button. That still doesn't fix the d-pad issue, but at
least you could use everything else.

Now, I'm having quite a bit of trouble running a regression test even using the
wiki starting with running the bisect. Help, please??

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

--- Comment #6 from mike   2010-06-07 14:55:24 ---
Created an attachment (id=28655)
 --> (http://bugs.winehq.org/attachment.cgi?id=28655)
Terminal output using wine from git

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

--- Comment #7 from mike   2010-06-07 15:31:38 ---
You can skip #2 and still visibly see a problem with the dinput.

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|regression                  |
           Severity|normal                      |trivial

--- Comment #8 from Dmitry Timoshkov   2010-06-08 01:51:19 ---
If you think this is a regression please post the results of your regression
testing: http://wiki.winehq.org/RegressionTesting

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

--- Comment #9 from mike   2010-06-08 15:03:29 ---
I'm in the process of doing regression testing, FWIW.
Finally...

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

--- Comment #10 from mike   2010-06-09 07:58:58 ---
(In reply to comment #9)
> I'm in the process of doing regression testing, FWIW.
> Finally...

Testing the functionality of the d-pad using the epsxe application on wine
1.1.19 is perfect. Wine 1.1.20 however offers the same lack of functionality
that's in 1.2-rc2 and every other version of wine after 1.1.20.

Hopefully I can get the testing data needed to show exactly what's wrong.

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

--- Comment #11 from mike   2010-06-09 13:00:13 ---
Created an attachment (id=28700)
 --> (http://bugs.winehq.org/attachment.cgi?id=28700)
Regression testing results

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #12 from Michael Stefaniuc   2010-06-09 14:14:52 ---
It is better to have those inline and not as attachment

aee42377984ab01c4aef0885780a707b606ec333 is the first bad commit
commit aee42377984ab01c4aef0885780a707b606ec333
Author: Vitaliy Margolen 
Date:   Sun Apr 19 20:33:25 2009 -0600

dinput: Remove redundant stuff.

:040000 040000 c78dc696232bc49723c4241ead34db250c284202
7bf1aeeb196ca7f2ee38eb29cad55b22e4b92e87 M    dlls

Mike, did you try to revert this patch on a current git to cross check that
indeed this patch is the culprit? "git revert
aee42377984ab01c4aef0885780a707b606ec333"will do.

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

--- Comment #13 from mike   2010-06-09 18:17:38 ---
(In reply to comment #12)
> It is better to have those inline and not as attachment
>
> aee42377984ab01c4aef0885780a707b606ec333 is the first bad commit
> commit aee42377984ab01c4aef0885780a707b606ec333
> Author: Vitaliy Margolen 
> Date:   Sun Apr 19 20:33:25 2009 -0600
> dinput: Remove redundant stuff.
>
> :040000 040000 c78dc696232bc49723c4241ead34db250c284202
> 7bf1aeeb196ca7f2ee38eb29cad55b22e4b92e87 M    dlls
>
> Mike, did you try to revert this patch on a current git to cross check that
> indeed this patch is the culprit? "git revert
> aee42377984ab01c4aef0885780a707b606ec333"will do.

No I did not. I don't know exactly how to do that, and just using the command
you gave me gives me the following:

Automatic revert failed.  After resolving the conflicts,
mark the corrected paths with 'git add <paths>' or 'git rm <paths>'
and commit the result.

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

--- Comment #14 from mike   2010-06-10 06:38:33 ---
I think I cross checked...

Git told me of the same patch

aee42377984ab01c4aef0885780a707b606ec333 is the first bad commit
commit aee42377984ab01c4aef0885780a707b606ec333
Author: Vitaliy Margolen 
Date:   Sun Apr 19 20:33:25 2009 -0600

dinput: Remove redundant stuff.

:040000 040000 c78dc696232bc49723c4241ead34db250c284202
7bf1aeeb196ca7f2ee38eb29cad55b22e4b92e87 M    dlls

And I checked the version of wine within the wine-git folder:

mack@mack-laptop:~/wine-git$ ./wine --version
wine-1.2-rc2-250-g950919e

I used the application and got perfect d-pad functionality.

However, using ./wine winecfg shows wine 1.1.19 so I am not sure if I did it
right or not. But that commit has come up twice now during regression testing.

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

--- Comment #15 from mike   2010-06-10 19:30:06 ---
OK, come to find out I was mistaken. I manually altered every file that the
first patch changed, and it made no difference.

Another test gave this result...

mack@mack-laptop:~/wine-git$ git bisect good
649c762f524c3fd8d62ff97aed623fa495b7b1f8 is the first bad commit
commit 649c762f524c3fd8d62ff97aed623fa495b7b1f8
Author: Vitaliy Margolen 
Date:   Sun Apr 19 20:33:29 2009 -0600

dinput: Convert evdev joystick to new base class.

:040000 040000 7c290c1ff76f202093e94e3ac09bf4add289267b
f4871167bc1c0711542944735c337be77c6b37f3 M    dlls
mack@mack-laptop:~/wine-git$ ./wine --version
wine-1.1.19-112-g3223798

Still can't run git revert though...

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

--- Comment #16 from mike   2010-06-11 16:40:54 ---
(In reply to comment #15)
> OK, come to find out I was mistaken. I manually altered every file that the
> first patch changed, and it made no difference.
>
> Another test gave this result...
>
> mack@mack-laptop:~/wine-git$ git bisect good
> 649c762f524c3fd8d62ff97aed623fa495b7b1f8 is the first bad commit
> commit 649c762f524c3fd8d62ff97aed623fa495b7b1f8
> Author: Vitaliy Margolen 
> Date:   Sun Apr 19 20:33:29 2009 -0600
> dinput: Convert evdev joystick to new base class.
>
> :040000 040000 7c290c1ff76f202093e94e3ac09bf4add289267b
> f4871167bc1c0711542944735c337be77c6b37f3 M    dlls
> mack@mack-laptop:~/wine-git$ ./wine --version
> wine-1.1.19-112-g3223798
>
> Still can't run git revert though...

I believe I reverted the 1st patch on a current git and it did not solve the
problem.

Reverting the 2nd patch causes severe problems in compiling wine. 
I can see why in reading everything deleted and added based on that patch. A
lot of that code the patch references isnt even there in the current
joystick_linuxinput.c file. Which doesn't even matter in this case cause this
error happens since that change, IMO.

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

--- Comment #17 from mike   2010-06-14 11:45:55 ---
It appears that this is fixed in 1.2-rc3. 
haven't done testing yet to determine what patch made it work, so i'm not
closing this issue yet.

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

mike  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #18 from mike   2010-06-21 17:10:24 ---
Also fixed in 1.2-rc4. I'm closing this issue based on that observation.

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #19 from Alexandre Julliard   2010-06-25 12:41:41 ---
Closing bugs fixed in 1.2-rc5.

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

mike  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |UNCONFIRMED
         Resolution|FIXED                       |

--- Comment #20 from mike   2010-06-28 05:45:54 ---
Not fixed in 1.2-rc5.

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #21 from Dmitry Timoshkov   2010-06-28 06:34:37 ---
(In reply to comment #20)
> Not fixed in 1.2-rc5.

You contradict yourself. If this is a regression since 1.2-rc4 then post
the results of your regression testing.1.2-rc4

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #22 from Dmitry Timoshkov   2010-06-28 06:34:47 ---
Closing.

[Bug 23025] D-Pad is not functional in epsxe

http://bugs.winehq.org/show_bug.cgi?id=23025

--- Comment #23 from mike   2010-06-28 20:26:07 ---
Well dmitry, my regression testing is ongoing.

However, initial testing shows that the bug is semi fixed.

Using one joystick port on my usb joystick adapter makes the d-pad 100 percent
non functional on every wine version except 1.1.19.

Using a different port makes the d-pad appear screwed up, yet offers full
functionality on every wine version.