https://bugs.winehq.org/show_bug.cgi?id=54728
Bug ID: 54728 Summary: Pro Evolution Soccer 2008 demo gets stuck extracting 'Pro Evolution Soccer 2008 DEMO.msi' Product: Wine Version: 7.4 Hardware: x86-64 URL: https://www.fileplanet.com/archive/p-32898/Pro-Evoluti on-Soccer-2008-Demo/download OS: Linux Status: NEW Keywords: download, regression Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: gijsvrm@gmail.com CC: zzhang@codeweavers.com Blocks: 10341 Distribution: ---
With wine-7.3 it takes around a minute and a half for it to finish successfully and open the next window to continue installation. With wine-7.4 it just gets stuck indefinitely, even after waiting 5mins. Bisection revealed:
ccc2c6c613264aa228bd6b113dffebc7bcf2c1f3 is the first bad commit commit ccc2c6c613264aa228bd6b113dffebc7bcf2c1f3 Author: Zhiyi Zhang zzhang@codeweavers.com Date: Wed Mar 2 14:21:48 2022 +0800
wine.inf: Enable Light theme by default.
Signed-off-by: Zhiyi Zhang zzhang@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
loader/wine.inf.in | 10 ++++++++++ 1 file changed, 10 insertions(+)
This seems like a weird one, but I can consistently reproduce it. Disabling the 'Light' theme with wine-8.4 (and -git) also works around.
https://bugs.winehq.org/show_bug.cgi?id=54728
temp82@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |temp82@luukku.com
--- Comment #1 from temp82@luukku.com --- indeed disabling the theme helps. still valid wine 8.4.
https://bugs.winehq.org/show_bug.cgi?id=54728
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |ccc2c6c613264aa228bd6b113df | |febc7bcf2c1f3
https://bugs.winehq.org/show_bug.cgi?id=54728
Zhiyi Zhang zzhang@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs@winehq.org |zzhang@codeweavers.com
https://bugs.winehq.org/show_bug.cgi?id=54728
--- Comment #2 from Zhiyi Zhang zzhang@codeweavers.com --- I am looking into this.
https://bugs.winehq.org/show_bug.cgi?id=54728
--- Comment #3 from Zhiyi Zhang zzhang@codeweavers.com --- Confirmed. The application makes ~570k calls to PROGRESS_Paint(). On Windows, there are ~1140k WM_PAINT messages for the progress control. So Wine actually makes half fewer calls. However, DrawThemeBackground() on Wine is more expensive than that on Windows and is causing the slowdown. If you wait ~9 mins, the installer can finish. When theming is off, FillRect() is used to draw the progress bar and has less overhead. I will see if I can optimize DrawThemeBackground(). This is also better reported to the application developer because making 1140k painting calls is definitely a bug.
https://bugs.winehq.org/show_bug.cgi?id=54728
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor
--- Comment #4 from Gijs Vermeulen gijsvrm@gmail.com --- Thanks for having a look.
Unfortunately I don't think a company like Konami is going to care about a demo for a game from 2007/2008 :/
I also don't think that this is worth spending a lot of time on to fix as this demo is just doing ridiculous things and it does succeed after a while. There is also an easy workaround.
https://bugs.winehq.org/show_bug.cgi?id=54728
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Pro Evolution Soccer 2008 |Pro Evolution Soccer 2008 |demo gets stuck extracting |demo takes +- 9 minutes to |'Pro Evolution Soccer 2008 |complete extracting 'Pro |DEMO.msi' |Evolution Soccer 2008 | |DEMO.msi' (disabling | |'Light' theme works around)
https://bugs.winehq.org/show_bug.cgi?id=54728
--- Comment #5 from Zhiyi Zhang zzhang@codeweavers.com --- Created attachment 74284 --> https://bugs.winehq.org/attachment.cgi?id=74284 fix
Please try this patch. You might need to recreate the wine prefix for it to take effect.
https://bugs.winehq.org/show_bug.cgi?id=54728
--- Comment #6 from Gijs Vermeulen gijsvrm@gmail.com --- (In reply to Zhiyi Zhang from comment #5)
Created attachment 74284 [details] fix
Please try this patch. You might need to recreate the wine prefix for it to take effect.
With this patch it takes 5min 30 seconds to complete the extracting step, which is definitely an improvement.
https://bugs.winehq.org/show_bug.cgi?id=54728
--- Comment #7 from Gijs Vermeulen gijsvrm@gmail.com --- Disregard my previous comment. With the patch it now takes 1 min 45 seconds, which is almost on par with a run with the 'Light' theme disabled.
https://bugs.winehq.org/show_bug.cgi?id=54728
Zhiyi Zhang zzhang@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |2960cf2e0616216fb8d01e11d7c | |a7475bfe26d97 Status|NEW |RESOLVED
--- Comment #8 from Zhiyi Zhang zzhang@codeweavers.com --- Fixed by 2960cf2e0616216fb8d01e11d7ca7475bfe26d97
https://bugs.winehq.org/show_bug.cgi?id=54728
Zhiyi Zhang zzhang@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|zzhang@codeweavers.com |wine-bugs@winehq.org
https://bugs.winehq.org/show_bug.cgi?id=54728
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 8.6.
https://bugs.winehq.org/show_bug.cgi?id=54728
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |8.0.x
https://bugs.winehq.org/show_bug.cgi?id=54728
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|8.0.x |---
--- Comment #10 from Michael Stefaniuc mstefani@winehq.org --- Removing the 8.0.x milestone from bug fixes included in 8.0.2.