http://bugs.winehq.org/show_bug.cgi?id=29986
Bug #: 29986 Summary: IE6 and IE4 have greenish toolbar icons Product: Wine Version: 1.4-rc4 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: trivial Priority: P2 Component: gdi32 AssignedTo: wine-bugs@winehq.org ReportedBy: RandomAccountName@mail.com CC: huw@codeweavers.com Classification: Unclassified Regression SHA1: 9b7ea6f417a68517745203123d9df0516ebc60b1
Created attachment 39036 --> http://bugs.winehq.org/attachment.cgi?id=39036 Screenshots
The toolbar buttons' icons in IE6 and IE4 are slightly greenish compared to Windows, especially the refresh and home buttons. This first occurred in 1.3.30, and regression testing indicated:
9b7ea6f417a68517745203123d9df0516ebc60b1 is the first bad commit commit 9b7ea6f417a68517745203123d9df0516ebc60b1 Author: Huw Davies huw@codeweavers.com Date: Tue Sep 27 16:13:39 2011 +0100
gdi32: Forward StretchBlt calls from the dib driver to the null driver.
:040000 040000 ce22d7943f0f7aecdda67e97b5812cb40b40cc96 c11b7ea6be9e5605ec4b3d2959af57b22ec7d54d M dlls
git checkout 9b7ea6f417a68517745203123d9df0516ebc60b1 -> bad git checkout 9b7ea6f417a68517745203123d9df0516ebc60b1^ -> good
To reproduce, install IE6 with 'winetricks ie6' and set it to display large toolbar icons (view -> toolbars -> customize -> icon options: large icons).
http://bugs.winehq.org/show_bug.cgi?id=29986
A Wine user RandomAccountName@mail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression
http://bugs.winehq.org/show_bug.cgi?id=29986
--- Comment #1 from A Wine user RandomAccountName@mail.com 2012-02-24 03:34:44 CST --- Created attachment 39037 --> http://bugs.winehq.org/attachment.cgi?id=39037 Terminal output
http://bugs.winehq.org/show_bug.cgi?id=29986
--- Comment #2 from Huw Davies huw@codeweavers.com 2012-02-24 18:13:08 CST --- Yes, this seems to be that the imagelist should acquire the dib colour table from the first added image.
http://bugs.winehq.org/show_bug.cgi?id=29986
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #3 from Austin English austinenglish@gmail.com 2013-08-06 21:44:21 CDT --- Still in 1.7.0.
https://bugs.winehq.org/show_bug.cgi?id=29986
--- Comment #4 from Austin English austinenglish@gmail.com --- Still in 1.7.30.
https://bugs.winehq.org/show_bug.cgi?id=29986
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40236
--- Comment #5 from Austin English austinenglish@gmail.com --- In wine-1.9.4-179-g846155f, the icons aren't showing at all for me in ie6. I filed bug 40236 for that.
https://bugs.winehq.org/show_bug.cgi?id=29986
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com
--- Comment #6 from winetest@luukku.com --- (In reply to Austin English from comment #5)
In wine-1.9.4-179-g846155f, the icons aren't showing at all for me in ie6. I filed bug 40236 for that.
Still needs staging patch. But do you think that patch fixes this issue too? I remember trying ie4 or ir6 before when there was no staging patch and when the buttons were still drawn. And I remember seeing some greenish thing. I can't replicate it anymore with winetricks -q ie6 and wine-staging.
https://bugs.winehq.org/show_bug.cgi?id=29986
--- Comment #7 from winetest@luukku.com --- (In reply to winetest from comment #6)
(In reply to Austin English from comment #5)
In wine-1.9.4-179-g846155f, the icons aren't showing at all for me in ie6. I filed bug 40236 for that.
Still needs staging patch. But do you think that patch fixes this issue too? I remember trying ie4 or ir6 before when there was no staging patch and when the buttons were still drawn. And I remember seeing some greenish thing. I can't replicate it anymore with winetricks -q ie6 and wine-staging.
I am adding wine version 2.0.rc3. It's hard to figure out the wine version based on dates. And staging which included a patch was 2.0.rc2.
https://bugs.winehq.org/show_bug.cgi?id=29986
--- Comment #8 from Huw Davies huw@codeweavers.com --- This should be fixed with commit 2dd0fb880c005cd5660928d1646a117407cec238
The actually see this bug, so that the icons actually load, the easiest way is to temporarily change WINE_FILEVERSION_MAJOR from 6 to 5 in dlls/shell32/version.h
https://bugs.winehq.org/show_bug.cgi?id=29986
Huw Davies h.davies1@physics.ox.ac.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED CC| |h.davies1@physics.ox.ac.uk
--- Comment #9 from Huw Davies h.davies1@physics.ox.ac.uk --- Fixed by 2dd0fb880c005cd5660928d1646a117407cec238
https://bugs.winehq.org/show_bug.cgi?id=29986
Huw Davies h.davies1@physics.ox.ac.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |2dd0fb880c005cd5660928d1646 | |a117407cec238
https://bugs.winehq.org/show_bug.cgi?id=29986
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #10 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 2.22.
https://bugs.winehq.org/show_bug.cgi?id=29986
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |2.0.x
https://bugs.winehq.org/show_bug.cgi?id=29986
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|2.0.x |---
--- Comment #11 from Michael Stefaniuc mstefani@winehq.org --- Removing the 2.0.x milestone from bugs included in 2.0.5.