[Bug 25263] New: Biet-O-Matic calculates shipping cost wrong for German locale (regression)
http://bugs.winehq.org/show_bug.cgi?id=25263
Summary: Biet-O-Matic calculates shipping cost wrong for German locale (regression) Product: Wine Version: 1.3.7 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: oleaut32 AssignedTo: wine-bugs@winehq.org ReportedBy: georg298@gmx.de
Using this app with German locale, the shipping cost is identified wrong: e.g. 400 instead of 4,00.
Reason: wine's oleaut32 has thousand separator support, but in German locale, the comma "," is the decimal separator.
A regression test revealed the buggy patch:
506ff74bb17742b3be5a8824dc081a3e294ccf1d is the first bad commit commit 506ff74bb17742b3be5a8824dc081a3e294ccf1d Author: Damjan Jovanovic damjan.jov@gmail.com Date: Mon Aug 25 20:40:20 2008 +0200
oleaut32: Thousands separator support for VarFormat.
:040000 040000 a35f267fdf244a3c1d2233c6a80641803c2f355e 5857b6570b3fbe95ff3c8cf6506d926e0cff1c1e M dlls
http://bugs.winehq.org/show_bug.cgi?id=25263
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |damjan.jov@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=25263
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Biet-O-Matic calculates |Biet-O-Matic calculates |shipping cost wrong for |shipping cost wrong for |German locale (regression) |German locale
http://bugs.winehq.org/show_bug.cgi?id=25263
--- Comment #1 from Nikolay Sivov bunglehead@gmail.com 2010-11-28 09:48:16 CST --- Please attach +variant log and specify download location if application is available for free.
http://bugs.winehq.org/show_bug.cgi?id=25263
--- Comment #2 from Georg Hennig georg298@gmx.de 2010-11-28 11:47:44 CST --- Download this GPL program from http://sourceforge.net/projects/bom/
Cannot upload +variant trace as text (48MB) or gzipped (1.2MB), maximum 1000KB allowed. So find it here (WINEDEBUG="+variant", adding one article with 4,00€ shipping cost): http://rapidshare.com/files/433699229/bom_log.txt.gz
http://bugs.winehq.org/show_bug.cgi?id=25263
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source URL| |http://sourceforge.net/proj | |ects/bom/
http://bugs.winehq.org/show_bug.cgi?id=25263
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com 2010-11-28 16:29:46 CST --- So the problem is:
- running with German locale; - your input in My Bid/Gebot cell "4,00" is interpreted as "400" by application logic?
Please describe steps to actually set a cell value to something and how to check that it works looking at app. GUI only.
http://bugs.winehq.org/show_bug.cgi?id=25263
--- Comment #4 from Georg Hennig georg298@gmx.de 2010-11-29 02:12:36 CST --- Actually, the problem can be reproduced in the following way:
- use German locale - use German ebay server strings (ebay.de) - use any article number from ebay.de and put it in one of the article input fields - the article will be read correctly, but shipping cost will be interpreted wrong (400€ instead of 4,00€). The price will be interpreted correctly, so this bug doesn't stop the app working, it's just a little annoying. And it's a bug in wine. You always have to add an article to see, if the bug disappeared!
http://bugs.winehq.org/show_bug.cgi?id=25263
--- Comment #5 from Georg Hennig georg298@gmx.de 2011-01-16 05:24:23 CST --- Bug still present in 1.3.11.
http://bugs.winehq.org/show_bug.cgi?id=25263
--- Comment #6 from Damjan Jovanovic damjan.jov@gmail.com 2011-07-10 06:24:40 CDT --- How do you run this application? First it won't start due to MSVBVM60.DLL missing, then when I install vbrun60 with winetricks it gives runtime error 372 and prints
err:ole:CoGetClassObject class {248dd896-bb45-11cf-9abc-0080c7e7b78d} not registered
I might have a patch, but without the ability to test it, I can't submit it.
http://bugs.winehq.org/show_bug.cgi?id=25263
Henri Verbeet hverbeet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |506ff74bb17742b3be5a8824dc0 | |81a3e294ccf1d
http://bugs.winehq.org/show_bug.cgi?id=25263
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de
--- Comment #7 from André H. nerv@dawncrow.de 2011-10-02 09:48:40 CDT --- Damjan: You can attach your patch for testing here and add tests with different locales to the testsuite
http://bugs.winehq.org/show_bug.cgi?id=25263
--- Comment #8 from Damjan Jovanovic damjan.jov@gmail.com 2011-10-03 02:20:21 CDT --- Created attachment 36680 --> http://bugs.winehq.org/attachment.cgi?id=36680 Use locale-specific thousands separator
Here is the patch. Note that the test fails on Windows, so whether it fixes anything on Wine is questionable.
http://bugs.winehq.org/show_bug.cgi?id=25263
--- Comment #9 from Georg Hennig georg298@gmx.de 2012-02-12 05:25:55 CST --- Thanks for your patch. However, it does not change anything (1.4_rc2). Bid-O-Matic runs from a clean wine prefix, without any additional dlls.
https://bugs.winehq.org/show_bug.cgi?id=25263
--- Comment #10 from Ken Sharp imwellcushtymelike@gmail.com --- Is this still an issue in Wine 1.7.45 or later?
https://bugs.winehq.org/show_bug.cgi?id=25263
--- Comment #11 from Georg Hennig georg298@gmx.de --- The error is the same for wine-1.7.45.
https://bugs.winehq.org/show_bug.cgi?id=25263
Piotr Caban piotr.caban@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |a6259d3182e4bd4441ca64a40c5 | |95a4a19740f9b Status|UNCONFIRMED |RESOLVED CC| |piotr.caban@gmail.com Resolution|--- |FIXED
--- Comment #12 from Piotr Caban piotr.caban@gmail.com --- It works for me now. Marking as fixed.
https://bugs.winehq.org/show_bug.cgi?id=25263
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #13 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.8-rc1.
-
wine-bugs＠winehq.org