https://bugs.winehq.org/show_bug.cgi?id=51570
Bug ID: 51570 Summary: Tetris (16bit) has regressions in gdi32 Product: Wine Version: 6.14 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: gdi32 Assignee: wine-bugs@winehq.org Reporter: dark.shadow4@web.de Distribution: ---
First, work around bug 51564.
Starting with 340a445289ed5777bfc177336fb6e315dfda273c, the program gets more and more graphical glitches. In the current git tree (and wine-6.14) it's completely black and broken. Sadly those changes don't revert cleanly, so I can't test that.
Download available,
https://bugs.winehq.org/show_bug.cgi?id=51570
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |340a445289ed5777bfc177336fb | |6e315dfda273c CC| |jacek@codeweavers.com Keywords| |regression URL| |https://archive.org/details | |/TETRIS_201612
--- Comment #1 from Fabian Maurer dark.shadow4@web.de --- Note that this is likely multiple regressions at once, although I have a hard time debugging that, due to the massive changes.
https://bugs.winehq.org/show_bug.cgi?id=51570
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |51564
https://bugs.winehq.org/show_bug.cgi?id=51570
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |win16
https://bugs.winehq.org/show_bug.cgi?id=51570
--- Comment #2 from Fabian Maurer dark.shadow4@web.de --- FWIW, the next regressions after the initial one are
0636b360130baf05025492eb59a806bbeffc3d33 - rectangles go missing cc7e7002ef8f92f47fe047d598dce057fcc2885b - text goes missing c129d13cbd49417078878573bd5f34a0f8f7410e - everything goes black
Although I still think all those are related.
https://bugs.winehq.org/show_bug.cgi?id=51570
--- Comment #3 from Jacek Caban jacek@codeweavers.com --- I guess that's because we check handle type before converting them to full handles. I think that we should make HDC_32 properly convert handles instead of doing that in gdi32. It should be doable now with GDI_SHARED_MEMORY, I will look at it.
https://bugs.winehq.org/show_bug.cgi?id=51570
--- Comment #4 from Jacek Caban jacek@codeweavers.com --- Created attachment 70429 --> https://bugs.winehq.org/attachment.cgi?id=70429 patch
Please try the attached patch. It seems to fix it for me, but I get a crash soon later (even if I revert to a pre-regression commit), so I didn't fully tested it.
https://bugs.winehq.org/show_bug.cgi?id=51570
--- Comment #5 from Fabian Maurer dark.shadow4@web.de --- Created attachment 70431 --> https://bugs.winehq.org/attachment.cgi?id=70431 Screenshot with patch applied
Please try the attached patch. It seems to fix it for me, but I get a crash soon later
Did you work around bug 51564? Anyways, the patch works mostly. Only thing off is the background of the text on the scoreboard to the left, see screenshot.
https://bugs.winehq.org/show_bug.cgi?id=51570
Jacek Caban jacek@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |5c8ac458bb72518a1c6f2ed05c7 | |83cee6c4a3b82 Status|NEW |RESOLVED
--- Comment #6 from Jacek Caban jacek@codeweavers.com --- This is fixed in git: https://source.winehq.org/git/wine.git/commitdiff/5c8ac458bb72518a1c6f2ed05c...
Please file a separated bug for the background problem.
https://bugs.winehq.org/show_bug.cgi?id=51570
--- Comment #7 from Fabian Maurer dark.shadow4@web.de --- Thank you! Follow up is bug 51624.
https://bugs.winehq.org/show_bug.cgi?id=51570
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.16.
https://bugs.winehq.org/show_bug.cgi?id=51570 Bug 51570 depends on bug 51564, which changed state.
Bug 51564 Summary: Can't run 16bit programs when built without mingw https://bugs.winehq.org/show_bug.cgi?id=51564
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED