[Bug 46829] New: Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

Bug ID: 46829
           Summary: Wizard101 crashes after playing the game after awhile.
           Product: Wine
           Version: 4.3
          Hardware: x86
                OS: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]

Created attachment 63859
  --> https://bugs.winehq.org/attachment.cgi?id=63859
Wizard101 crash logs for Wine 4.3 on macOS Mojave.

After playing Wizard101 (anywhere from 30 minutes to an hour or more), it
crashes unexpectedly. I have attached the terminal log below. This is a clean
install of wine 4.3 on macOS Mojave 10.14.3.

[Bug 46829] Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

Ken Thomases  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEEDINFO

--- Comment #1 from Ken Thomases  ---
That's showing memory address space exhaustion.  It's exceeding the amount of
memory a 32-bit process is capable of using.

Please, attach a proper log (a text file, not an image of text). Capture all of
the output, not just the end. You can see
https://wiki.winehq.org/FAQ#How_can_I_get_a_debugging_log_.28a.k.a._terminal_output.29.3F
for instructions.

Did Wizard101 used to work for you, such that this failure is new compared to
how it used to work?  If so, was that with an earlier version of Wine?  An
earlier version of macOS?  Did it just start after a game update?  In other
words, what changed between then and now?

[Bug 46829] Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

--- Comment #2 from James  ---
Created attachment 63860
  --> https://bugs.winehq.org/attachment.cgi?id=63860
Here's a log with the crash, without RtlEnter(leave)CriticalSection

I've had the crashing issue since using Wine 4.2 (devel). 4.1 worked just fine.
All using macOS Mojave 10.14.3.

[Bug 46829] Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

--- Comment #3 from James  ---
Created attachment 63876
  --> https://bugs.winehq.org/attachment.cgi?id=63876
Log #2 - Wine 4.3-2 build on macOS Mojave

[Bug 46829] Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

--- Comment #4 from Ken Thomases  ---
Yeah, this log also indicates it's running out of address space:
> libc++abi.dylib: terminating with uncaught exception of type std::bad_alloc: std::bad_alloc

This is a general issue with 32-bit graphically-intensive games, especially on
macOS where the memory for OpenGL resources comes out of the process's address
space.  Your best bet is to reduce graphics quality in the game's settings,
especially texture quality.

If and when Wizard101 comes out with a 64-bit client, that problem will go
away.

[Bug 46829] Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

--- Comment #5 from James  ---
I reinstalled wine 4.1 devel and do not experience the crashing issue on macOS
Mojave, even with high settings. I believe this issue is with wine because it
only happens with 4.2 and higher. On 4.2 and 4.3 the crashing issues occur
after about 30 minutes of gameplay, and on 4.1 I've been running the game for
over an hour with no crashing issues. Going into different areas, doing
multiple tasks and no crashing has occurred.

[Bug 46829] Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

Ken Thomases  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail]

--- Comment #6 from Ken Thomases  ---
OK.  Are you able to build Wine from source?  If so, it would be great if you
could do a regression test to identify the commit which introduced this
problem.
https://wiki.winehq.org/Regression_Testing

[Bug 46829] Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

--- Comment #7 from James  ---
I have found the bad commit when doing regression testing:

d2fa2624e94fc487b5656c9a8d4a4dc7e3193784 is the first bad commit
commit d2fa2624e94fc487b5656c9a8d4a4dc7e3193784
Author: Zebediah Figura 
Date:   Tue Feb 12 10:45:07 2019 -0600

wined3d: Store lights in the wined3d_stateblock_state structure.

Signed-off-by: Zebediah Figura 
    Signed-off-by: Henri Verbeet 
    Signed-off-by: Alexandre Julliard

:040000 040000 79ce80b595cc96f02d34d547dd9a9bff785584f5
e178f9985618d6988bca50658126d193a1959ad4 M    dlls

[Bug 46829] Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

James  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 46829] Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

Ken Thomases  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |directx-d3d
    Regression SHA1|                            |d2fa2624e94fc487b5656c9a8d4
                   |                            |a4dc7e3193784

[Bug 46829] Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

Ken Thomases  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|1                           |0
             Status|NEEDINFO                    |UNCONFIRMED

[Bug 46829] Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

--- Comment #8 from James  ---
Update: still crashes on wine 4.4 with the same errors.
Compiling with the bad commit reverted causes a compile error (error 1)

[Bug 46829] Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

--- Comment #9 from Zebediah Figura  ---
Hopefully fixed by
https://source.winehq.org/git/wine.git/commit/cc5c9e8dff4840769a6cddda890cbfdd666bf830,
please retest.

[Bug 46829] Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

--- Comment #10 from James  ---
I get a white screen when launching the game after compiling the latest one.
This is a different issue now as I compiled with your latest commit reverted,
and it still gets a white screen. Doing regression testing for that bug.

[Bug 46829] Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

--- Comment #11 from James  ---
Update: looks like the issue i'm having is for some reason libpng isn't
compiling in. I think the 10.14.4 update totally screwed my workarounds for
compiling 32 bit wine. I think i'll have to wait for 4.5 to test this or if
someone on High Sierra can package me a build.

[Bug 46829] Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

James  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |cc5c9e8dff4840769a6cddda890
                   |                            |cbfdd666bf830
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from James  ---
Tested wine 4.5 and it's fixed. No crashing issues at all on Mojave.

[Bug 46829] Wizard101 crashes after playing the game after awhile.

https://bugs.winehq.org/show_bug.cgi?id=46829

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard  ---
Closing bugs fixed in 4.6.