[Bug 54571] New: ImageList images hard to see or even invisible depending on COLOR_WINDOWTEXT

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54571

Bug ID: 54571
           Summary: ImageList images hard to see or even invisible
                    depending on COLOR_WINDOWTEXT
           Product: Wine
           Version: 8.2
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: comctl32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 74114
  --> https://bugs.winehq.org/attachment.cgi?id=74114
Visibility of images depending on Window Text color.

The lighter the Window Text color gets, the less visible the images in an
ImageList get.
This really affects people primarily using dark themes such as myself, as then
the text color is going to be so light the images will be invisible.
I'm not sure if this issue is present in other software, but in this case I am
experiencing this with the GSAE (GS Advanced Editor) tool shipped with Roland
sound modules.

I am able to see the images properly again if I replace what is currently line
1488 of `comctl32/imagelist.c` (ImageList_DrawIndirect) with `if (FALSE)`
instead of `if (himl->hbmMask)` so the else branch always runs (this will
likely break other software though, and in my case is just a temporary
measure).

[Bug 54571] ImageList images hard to see or even invisible depending on COLOR_WINDOWTEXT

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54571

DarkOK  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://archive.org/downloa
                   |                            |d/gsae4/gsae.zip
           Keywords|                            |download

[Bug 54571] ImageList images hard to see or even invisible depending on COLOR_WINDOWTEXT

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54571

--- Comment #1 from DarkOK  ---
Still occurs in Wine 9.17.

Attached will be an image of Wine and Windows side-by-side with the same theme,
with Windows showing the icons correctly and Wine not.

[Bug 54571] ImageList images hard to see or even invisible depending on COLOR_WINDOWTEXT

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54571

--- Comment #2 from DarkOK  ---
Created attachment 76369
  --> https://bugs.winehq.org/attachment.cgi?id=76369
Wine 9.7 and Windows comparison

[Bug 54571] ImageList images hard to see or even invisible depending on COLOR_WINDOWTEXT

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54571

Orin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Orin  ---
Thanks for this.

Confirmed in wine 9.22, using native comctl32 fixes the issue.

I will take a look at this now.

[Bug 54571] ImageList images hard to see or even invisible depending on COLOR_WINDOWTEXT

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54571

--- Comment #4 from Orin  ---
(In reply to DarkOK from comment #0)

Out of interest, which theme are you using?

[Bug 54571] ImageList images hard to see or even invisible depending on COLOR_WINDOWTEXT

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54571

--- Comment #5 from DarkOK  ---
Created attachment 77532
  --> https://bugs.winehq.org/attachment.cgi?id=77532
Theme shown in screenshot

[Bug 54571] ImageList images hard to see or even invisible depending on COLOR_WINDOWTEXT

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54571

--- Comment #6 from Orin  ---
Brilliant, thank you.